[homewizard] Fix issue with missing gas values #11666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
wborn
reviewed
Dec 1, 2021
...ding.homewizard/src/main/java/org/openhab/binding/homewizard/internal/HomeWizardHandler.java
Outdated
Show resolved
Hide resolved
Daniel-42
force-pushed
the
11639-gas-fix
branch
from
499c63b
to
4ba7179
Compare
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl>
Imported the (now slightly different) exception and feeding the numbers directly to a ZonedDateTime Signed-off-by: Daniël van Os <daniel@supercell.nl>
Daniel-42
force-pushed
the
11639-gas-fix
branch
from
ad49ce6
to
fcc7e2e
Compare
wborn
reviewed
Dec 1, 2021
...ding.homewizard/src/main/java/org/openhab/binding/homewizard/internal/HomeWizardHandler.java
Show resolved
Hide resolved
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl>
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
This commit fixes a crash that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp. Signed-off-by: Daniël van Os <daniel@supercell.nl> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a bugfix fixes a crash in the HomeWizard add on that happens when the smart meter does not provide gas values. The crash was caused by the empty timestamp.
Signed-off-by: Daniël van Os daniel@supercell.nl