Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[androiddebugbridge] Add channels for record events, open urls and doc improvements #11692

Merged
merged 8 commits into from
Dec 20, 2021

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Dec 2, 2021

Signed-off-by: Miguel Álvarez Díez miguelwork92@gmail.com
Minor additions for the androiddebugbridge binding:

  • Add the ability to record/send input events.
  • Add channel to open url
  • Allow start package with activity info.
  • Minor doc improvements and fixes.

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Dec 4, 2021
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from lolodomo December 8, 2021 13:48
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from lolodomo December 9, 2021 20:41
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Dec 18, 2021

@GiviMAD : really sorry for the delay I needed to understand your strange code to delete a thing property. Unfortunately I can't merge this PR until 3.2 is released, except if @kaikreuzer accepts a derogation.

@lolodomo lolodomo merged commit 208885d into openhab:main Dec 20, 2021
@lolodomo lolodomo added this to the 3.3 milestone Dec 20, 2021
mherwege pushed a commit to mherwege/openhab-addons that referenced this pull request Dec 23, 2021
…c improvements (openhab#11692)

* Add channels for record events, open urls and doc improvements

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…c improvements (openhab#11692)

* Add channels for record events, open urls and doc improvements

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…c improvements (openhab#11692)

* Add channels for record events, open urls and doc improvements

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
…c improvements (openhab#11692)

* Add channels for record events, open urls and doc improvements

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…c improvements (openhab#11692)

* Add channels for record events, open urls and doc improvements

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…c improvements (openhab#11692)

* Add channels for record events, open urls and doc improvements

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants