[wled] Fix Global OFF not turning lights/segments off. #11806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
I suppose you agree it does not fix a critical issue ? |
|
Thank you for the multiple quick approvals, apprieated. Critical no, but it will be the source of confusion for people and cause them to post for help. I do have the jar with all fixes in the marketplace already, but I would prefer to delete it from marketplace if this gets merged into 3.2 stable. |
mherwege
pushed a commit
to mherwege/openhab-addons
that referenced
this pull request
Dec 23, 2021
Signed-off-by: Matthew Skinner <matt@pcmus.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Matthew Skinner <matt@pcmus.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Matthew Skinner <matt@pcmus.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the global on/off control is not reflected in each light/segments true state.
Signed-off-by: Matthew Skinner matt@pcmus.com