Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LuxtronikHeatpump] fix channel type of newly defined unknown channels #11937

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

sgiehl
Copy link
Contributor

@sgiehl sgiehl commented Jan 2, 2022

Fixes an issue introduced with #11860

The new "unknown" channels are all using the same channel type. When a new thing is created the channels are rebuilt based on the available channels. Before the channel id and the channel type were always the same. This fails for the new channels.
This PR should fix this.

See #11860 (comment)

Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 2d32067 into openhab:main Jan 2, 2022
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jan 2, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 2, 2022
@sgiehl sgiehl deleted the luxtronikfixnewchannels branch January 2, 2022 17:22
@tmp-hallenser
Copy link

@sgiehl Is this fix already included in the latest docker snapshot image? (still remaining in 'unknown' state :( )

@sgiehl
Copy link
Contributor Author

sgiehl commented Jan 2, 2022

I'm not sure how often that is built. But you will need to remove and readd the thing.

@tmp-hallenser
Copy link

Docker image has been built like 2hrs ago; removed thing and added it again - still not working. Let's see if it's fixed in one of the next builds

@sgiehl
Copy link
Contributor Author

sgiehl commented Jan 3, 2022

I actually don't know what the docker image contains and wether this also includes the latest checkout of the add-ons. Maybe @lolodomo can answer that.

@lolodomo
Copy link
Contributor

lolodomo commented Jan 3, 2022

I believe it should be included in docker version 2472 built about 8 hours ago.

And for sure it is part of normal snapshot build 2673

@sgiehl
Copy link
Contributor Author

sgiehl commented Jan 3, 2022

@tmp-hallenser my problem actually is, that my heatpump doesn't serve those additional channels. So I'm not able to test that properly. I modified the code locally so the channels are added even if they aren't available and compiled the binding. Adding that to the latest docker snapshot works for me.

@tmp-hallenser
Copy link

I'm now seeing the new channels - seem like it wasn't immediately included into the docker image.

mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
openhab#11937)

Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
volkmarnissen pushed a commit to volkmarnissen/openhab-addons that referenced this pull request Mar 3, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
openhab#11937)

Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
openhab#11937)

Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants