-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LuxtronikHeatpump] fix channel type of newly defined unknown channels #11937
Conversation
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sgiehl Is this fix already included in the latest docker snapshot image? (still remaining in 'unknown' state :( ) |
I'm not sure how often that is built. But you will need to remove and readd the thing. |
Docker image has been built like 2hrs ago; removed thing and added it again - still not working. Let's see if it's fixed in one of the next builds |
I actually don't know what the docker image contains and wether this also includes the latest checkout of the add-ons. Maybe @lolodomo can answer that. |
I believe it should be included in docker version 2472 built about 8 hours ago. And for sure it is part of normal snapshot build 2673 |
@tmp-hallenser my problem actually is, that my heatpump doesn't serve those additional channels. So I'm not able to test that properly. I modified the code locally so the channels are added even if they aren't available and compiled the binding. Adding that to the latest docker snapshot works for me. |
I'm now seeing the new channels - seem like it wasn't immediately included into the docker image. |
openhab#11937) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
openhab#11937) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
openhab#11937) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
openhab#11937) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
openhab#11937) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
openhab#11937) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Fixes an issue introduced with #11860
The new "unknown" channels are all using the same channel type. When a new thing is created the channels are rebuilt based on the available channels. Before the channel id and the channel type were always the same. This fails for the new channels.
This PR should fix this.
See #11860 (comment)