[unifi] New site, wlan, wiredClient, and poePort. Discovery support

[Hilbrand]

New features:

• New Things: wiredClient, poePort, site and wlan.
• Added discovery support of things.
• Added guest, and experience channel to wireless thing.
• Added command channel named cmd to wireless thing as replacement for switch reconnect channel.
• Added Dutch translation.
• Also included some refactoring and bug fixes.

This change includes changes made by Matthew Bowman that he created on his own branch but were never completed.

Fixes:

• Closes [unifi] "java.lang.IllegalArgumentException: Buffering capacity 2097152 exceeded" #9609: Implemented async http call, which should fix the buffer overflow.
• Closes [unifi] StackOverflowError - long stacktrace in logfile #10375: At least should avoid the stack overflow.
• Closes [unifi] Binding should search for sid case insensitive #11964: Binding should search for sid case insensitive.

Also-by: Matthew Bowman mgb@otr.mx
Signed-off-by: Hilbrand Bouwkamp hilbrand@h72.nl

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/unifi-beta/131156/1

[jlaur]

@Hilbrand - I've just given this a test spin. It seems to reintroduce #7001 which was fixed by #11451. Two options:

• Either something went wrong when moving UniFiController from api/model to api - did you perhaps start your changes a long time ago and lost some changes happening in meantime?
• Or you deliberately refactored the client cache logic which accidentally caused this regression?

I would need to look deeper to understand what happened, but this might give you a clue. For reference:

openhab-addons/bundles/org.openhab.binding.unifi/src/main/java/org/openhab/binding/unifi/internal/api/model/UniFiController.java

Lines 183 to 190 in cf86044

	// Prefer lookups through _id, until initialized use cid.
	String id = cidToIdCache.get(cid);
	synchronized (this) {
	// mgb: first check active clients and fallback to insights if not found
	client = clientsCache.get(id != null ? id : cid);
	if (client == null) {
	client = insightsCache.get(id != null ? id : cid);
	}

changed back to:

openhab-addons/bundles/org.openhab.binding.unifi/src/main/java/org/openhab/binding/unifi/internal/api/cache/UniFiControllerCache.java

Lines 112 to 117 in 6b33a32

	synchronized (this) {
	// mgb: first check active clients and fallback to insights if not found
	client = clientsCache.get(cid);
	if (client == null) {
	client = insightsCache.get(cid);
	}

[Hilbrand]

@jlaur I did refactor this part, and also thought I handled this case. But didn't realize it keeps track of gone clients. I've updated the cache to not reset the map with references and use it to to get the id. So it should now work again. I've updated the marketplace jar.

[jlaur]

I've updated the cache to not reset the map with references and use it to to get the id. So it should now work again.

Confirmed, it works again now.

[jlaur]

@Hilbrand, I've been running this in production since January 5th and have so far discovered no issues. Only tested with access point though and so far only normal operation, i.e. stability and online channel working.

[jlaur]

Ah crap... I've recompiled against 3.2.0 and updated the jar as I'm on 3.2.0, but didn't checked all channels and developed on 3.3.0... 😭 Reinstalling from the marketplace should fix this.

I compiled it myself, so probably I made a similar mistake as I'm deploying it to a 3.2 system. For now I added .longValue() three places in UniFiClientThingHandler where DecimalType is instantiated with Integer, so now working correctly. I'll try with a 3.3 snapshot later without these modifications.

[jlaur]

@Hilbrand - signoff is missing for last commit, can you fix the commit message? How much more work is planned before going out of draft state? If aiming for 3.3, perhaps we should try to get it ready for one of the next milestones?

[Hilbrand]

At this moment I'm not planning additional features to this pr therefor I've removed the draft. So this pr can be reviewed for inclusion.

I've updated the description in the pr so it can be used as the message for the squashed merge of this pr (or I can squash this pr when the review is done).

I've included the new dutch translation. When this pr is merged and synchronized with crowdin I'll upload the dutch translation to crowdin to make sure it won't get lost when a new sync would be done.

[jlaur]

Thanks for all these improvements! The code looks really good, I have added only a few minor comments.

[jlaur]

@Hilbrand - gentle ping. :) Only a few minor comments from my side to consider.

[jlaur]

@Hilbrand - thanks, I've resolved the comments addressed by your last commit and left the rest open.

[jlaur]

Sorry, last round of proof-reading after last commit.

[jlaur]

Thanks a lot for these many improvements!