Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[voskstt] Initial contribution #12249

Merged
merged 9 commits into from
Feb 19, 2022
Merged

[voskstt] Initial contribution #12249

merged 9 commits into from
Feb 19, 2022

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Feb 8, 2022

Signed-off-by: Miguel Álvarez Díez miguelwork92@gmail.com

This STT service allows offline "Speech-to-Text" on openHAB.

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from a team as a code owner February 8, 2022 23:03
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD
Copy link
Member Author

GiviMAD commented Feb 13, 2022

@lolodomo I have added a new option to keep the language model loaded, I think is a nice one to have.
Sorry for the late changes, they are in a separate commit.

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD
Copy link
Member Author

GiviMAD commented Feb 13, 2022

I forgot to unload the model when the preload model config changes to false, fixed in the last commit, I'll make no other changes, sorry for the inconvenience.

@lolodomo
Copy link
Contributor

Please add the missing i18n properties.

Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD
Copy link
Member Author

GiviMAD commented Feb 18, 2022

Please add the missing i18n properties.

Done.
I think everything is in place unless the getSupportedLocales problem. Let me know if I've missed something else.

This was referenced Feb 18, 2022
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaikreuzer kaikreuzer added this to the 3.3 milestone Feb 19, 2022
@kaikreuzer kaikreuzer merged commit 9bb4346 into openhab:main Feb 19, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@jlaur jlaur changed the title [voskstt] initial contribution [voskstt] Initial contribution Apr 30, 2022
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD GiviMAD deleted the voskstt branch September 14, 2022 15:58
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants