Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hydrawise] Support unused zones #12275

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

digitaldan
Copy link
Contributor

Fixes #12209

Signed-off-by: Dan Cunningham dan@digitaldan.com

Fixes openhab#12209

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Feb 12, 2022
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

Thanks!

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit b7e064a into openhab:main Feb 13, 2022
@lolodomo lolodomo added this to the 3.3 milestone Feb 13, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
* [hydrawise] Support unused zones
Fixes openhab#12209

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
* [hydrawise] Support unused zones
Fixes openhab#12209

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [hydrawise] Support unused zones
Fixes openhab#12209

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [hydrawise] Support unused zones
Fixes openhab#12209

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [hydrawise] Support unused zones
Fixes openhab#12209

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hydrowise] Binding does not respect zone numbers, assigns in numerical order
2 participants