[livisismarthome] Initial contribution (successor of innogysmarthome with local API and some improvements) #12440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…innogysmarthome binding) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- The local API is now used, authorization, bridge initialization and discovery is already working - Potential NullPointerExceptions fixed Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Adding battery-low-Channel support for ISC2 - More optimizations and local API changes in the ReadMe Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- The key button counter channels are now updated correctly. The according trigger channels should now also work fine. - Bug fixes regarding button pressed event. The pressed event is now executed along with short and long press events, so if someone want to react on a button press (short or long), the PRESSED trigger event can get checked. And the pressed event isn't senseless executed on a binding restart anymore. - Error messages improved Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Deprecation-Notice Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- New deprecation warning integrated in the innogysmarthome binding Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Livisi renamed to LIVISI Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- SHC channels are now initialized correctly - New "status" channel for the SHC with the values ACTIVE, INITIALIZING and SHUTTINGDOWN Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code and documentation optimizations Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Fix for PT-PSS action Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Support for SHC classic - The websocket is hosted on another port. Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Update for Temperature-Channel-Definitions and Translations (de) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Update for Power-Channel-Definitions Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Further translations (de) for devices and channels Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Refactoring branch integrated (some tests added and a lot of code optimizations for example smaller methods, better method names, more simple flows without continue and return in void methods, improved NULL handling, etc.) - Code optimization (special handling for VariableActuator removed which seems to be not required anymore) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- The thing status is now set to offline when the device is not reachable (even on binding start up) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- The thing status is now set to online again when the device is reachable again Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Clearer description of the invert switch of the RollerShutter (ISR2) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Copyright notices corrected Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Imports optimized Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
wborn
added
the
new binding
wborn
changed the title
- Changed handling of pointTemperature (QuantityType instead of DecimalType) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code optimization (device status listeners are now registered with device id, so it isn't necessary anymore to call all listeners to find the right matching listener for the device event). Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code optimization (not working mDNS bridge discovery removed). Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Explicit idle timeout removed (seems not to be required anymore for the local API and may cause problems with SHC 1, there occur EOFExceptions) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code optimizations (Debug code removed which isn't required anymore) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Representation property introduced to auto-ignore textual defined things at discovery/scan Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
|
All review comments seem now be solved. And today I have also added the usage of the "representation property" (that was a wish of at least 1 user ;-)) and it was also already tested successfully. Can the pull-request get merged soon (for M7 or the final release of 3.3.0 which are very near)? Thank you and best regards :-) |
There is one remaining comment which was missed, I have now unresolved it:
Definitely, let's get the remaining comment resolved quickly and get this PR merged. Thanks for all your hard work on this! |
- Code review findings fixed (more detailed error message for SHC not reachable added). Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
The last comment is now solved, I updated the branch (via merging main again) and all checks are completed successfully. Can you now merge the pull-request? :-) Thank you and best regards |
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
jlaur
reviewed
Jun 14, 2022
.../src/main/java/org/openhab/binding/livisismarthome/internal/handler/LivisiDeviceHandler.java
Show resolved
Hide resolved
- Code review findings fixed ("/event/ControllerConnectivityChanged" doesn't change the bridge thing to offline anymore, because it isn't important for the local API anymore).
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code review findings fixed (point temperature commands with DecimalType instead of QuantityType can now also get handled). Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Tests added regarding handleCommand Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code optimization (constant for the "invert" channel parameter added) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
- Code optimization (log messages within tests avoided) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
|
And now PR-openHAB-Addons was broken and after updating with main also the build is broken. It has nothing to do with this pull-request, but will again require waiting time and more updates... I don't want to work anymore for this pull-request, please merge it soon! |
I have rescheduled CI build with Java 11. Build takes some time because it spans multiple bindings.
I understand. However, the fastest way to get a PR merged is to address comments as fast as possible to get it moving. Since this PR contains ~16k lines of code, it has also been time consuming for me as a reviewer, and my spare time is limited as well. Like you I'm also interested in seeing this finished and making it into the 3.3 release. From my perspective we are working together on ensuring the best outcome for this binding, not against each other. Your work is much appreciated! |
jlaur
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Thanks for your contribution! Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website. It would also be appreciated if you could create a PR for mentioning the needed migration from innogysmarthome in https://github.com/openhab/openhab-distro/blob/557b8205aa5ebe179d170e757740406ab90f0510/distributions/openhab/src/main/resources/bin/update.lst#L63-L76.
jlaur
changed the title
|
@jlaur : Thank you for your review and your time too! I think we have a great new binding now for all the OH 3.3 users ! |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…l API and some improvements) (openhab#12440) - Initial version added (copied and renamed from the innogysmarthome binding) - The local API is now used, authorization, bridge initialization and discovery is already working - Potential NullPointerExceptions fixed - Adding battery-low-Channel support for ISC2 - More optimizations and local API changes in the ReadMe - The key button counter channels are now updated correctly. The according trigger channels should now also work fine. - Bug fixes regarding button pressed event. The pressed event is now executed along with short and long press events, so if someone want to react on a button press (short or long), the PRESSED trigger event can get checked. And the pressed event isn't senseless executed on a binding restart anymore. - Error messages improved - Deprecation-Notice - New deprecation warning integrated in the innogysmarthome binding - Livisi renamed to LIVISI - SHC channels are now initialized correctly - New "status" channel for the SHC with the values ACTIVE, INITIALIZING and SHUTTINGDOWN - Code and documentation optimizations - Fix for PT-PSS action - Support for SHC classic - The websocket is hosted on another port. - Update for Temperature-Channel-Definitions and Translations (de) - Update for Power-Channel-Definitions - Further translations (de) for devices and channels - Refactoring branch integrated (some tests added and a lot of code optimizations for example smaller methods, better method names, more simple flows without continue and return in void methods, improved NULL handling, etc.) - Code optimization (special handling for VariableActuator removed which seems to be not required anymore) - The thing status is now set to offline when the device is not reachable (even on binding start up) - The thing status is now set to online again when the device is reachable again - Clearer description of the invert switch of the RollerShutter (ISR2) - Copyright notices corrected - Imports optimized - Changed handling of pointTemperature (QuantityType instead of DecimalType) - Code optimization (device status listeners are now registered with device id, so it isn't necessary anymore to call all listeners to find the right matching listener for the device event). - Code optimization (not working mDNS bridge discovery removed). - Explicit idle timeout removed (seems not to be required anymore for the local API and may cause problems with SHC 1, there occur EOFExceptions) - Code optimizations (Debug code removed which isn't required anymore) - Warn message added which is logged when the temperature to set is not between min and max temperature (this can happen when the user uses the REST-API instead of MainUI or probably also when set via a rule). - Code optimizations (stronger/consequent use of QuantityType instead of DecimalType) - Temperature values outside the possible range of 6 - 30 °C are now set to 6 / 30 °C. Therefore a temperature channel can get set to 0 °C for example by a rule and this is automatically changed to 6 °C (and causes a debug message). - Code optimizations - Bug fixes regarding UnitsOfMeasurements (Number:Power) - Tests repaired - The local API returns "[]" for empty objects which should only get used for arrays... This is now handled by the binding with replacing "[]" by "null". This error occurred with SHC 1, it isn't known if SHC 2 is also affected. - Number:Dimensionless (percent) introduced for humidity and luminance - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - The configVersion is now also available for SHC 1 bridges. - More changes to Descriptions, Translations, Icons, Channel-Order, Channel-Config - Trace logging of responses added to increase the traceability - The SHC channels should now also get filled for SHC classic - cpu, memory and disc channels are now defined as percentage (Number:Dimensionless) - Jetty-HttpClient replaced by simple UrlConnection, because Jetty-HttpClient has problems with high frequency execution of requests. There were EOFExceptions with SHC classic when 2 or more requests were executed within the same second... - Readme updated - Copyright notices corrected - Additions in ReadMe for RST2 / WRT - The bridge channels (cpu, memory, disc and operation state) are now updated every minute for SHC 1 / classic (because there are no such events for SHC 1 / classic) - Bug-fix for SHC 1 / classic: Device attributes are now updated correctly for SHC 1 / classic (there is another response structure, which caused that some attributes were not found / update). This should have affected battery low and reachable (thing status) information. - There are also raw events which report changes regarding the bridge channels (cpu, memory, disc and operation status). There are now processed. - Token request JSON changed to lower-case (to be compatible with the new SHC firmware update and this should enable to use the standard logics) - SHC 2 can now get authenticated with the OAuth 2.0 standard logics of OpenHAB (with x-www-form-urlencoded instead of json). The old special json logic is still there to support SHC 1 (but SHC 1 will also get updated soon). - SHC 1 supports now short and long button pressed events - Outdated custom login logics removed. SHC 2 and SHC 1 / classic supports now OAuth 2.0 login requests, therefore the default login logics of OpenHAB can now get used. - README updated for the required software version of SHC 1 / classic - Code review findings fixed - Code review findings fixed (Channel Ids renamed to lowerCamelCase) - Unused code removed - Code review findings fixed (Device status messages localized) - Code review findings fixed (label of BooleanStateActuator renamed) - Code review findings fixed (hard-coded units resolved) - Code review findings fixed (unit of measurements changed form Power to Energy when it is unit Wh instead of W) - Code review findings fixed (thing status BRIDGE_OFFLINE changed to COMMUNICATION_ERROR, because BRIDGE_OFFLINE is intended for sub/child devices, not for the bridge thing) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Compiler warnings fixed - Code review findings fixed - Code review findings fixed (channel ids renamed) - Code review findings fixed (tags for temperature and humidity added) - Code review findings fixed (properties renamed to lowerCamelCase like the default properties) - Code review findings fixed (non-null warnings fixed, performance increased by reducing requests) - Code review findings fixed (non-null warnings fixed) - Code review findings fixed (non-null warnings fixed in tests) - Copyright notices updated - Unnecessary log line removed - Code review findings fixed (non-null warnings fixed in tests) - Test fixed (WebSocketClient can't get mocked completely which caused an Exception) - Code review findings fixed (various code optimizations) - Code review findings fixed (channel-type-ids renamed to lowerCamelCase) - Code review findings fixed (translation simplified) - Code review findings fixed (temperature point handling converted in UoM) - Code review findings fixed (Exception handling improved) - Code review findings fixed (offline state precised when the bridge isn't found/configured) - Code review findings fixed (exception logs deactivated within tests to reduce to console output when running the tests) - Code review findings fixed (thing status is now checked instead of bridge status) - Code review findings fixed (DeviceStructureManager can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (LivisiClient can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (OAuthService can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (unnecessary type check removed) - Code review findings fixed (warning messages within tests reduced) - Code review findings fixed (more when the bridge connection state changes) - Code review findings fixed (reconnect job changed from scheduleAtFixedRate to scheduleWithFixedDelay - recommended by the SAT warnings). - Code review findings fixed (unused method removed). - Representation property introduced to auto-ignore textual defined things at discovery/scan - Code review findings fixed (more detailed error message for SHC not reachable added). - Fix ChannelTypeID in Readme.md sample - Code review findings fixed ("/event/ControllerConnectivityChanged" doesn't change the bridge thing to offline anymore, because it isn't important for the local API anymore). - Code review findings fixed (point temperature commands with DecimalType instead of QuantityType can now also get handled). - Tests added regarding handleCommand - Code optimization (constant for the "invert" channel parameter added) - Code optimization (log messages within tests avoided) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Co-authored-by: RalphSester <ralph.sester@sester-edv.de>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…l API and some improvements) (openhab#12440) - Initial version added (copied and renamed from the innogysmarthome binding) - The local API is now used, authorization, bridge initialization and discovery is already working - Potential NullPointerExceptions fixed - Adding battery-low-Channel support for ISC2 - More optimizations and local API changes in the ReadMe - The key button counter channels are now updated correctly. The according trigger channels should now also work fine. - Bug fixes regarding button pressed event. The pressed event is now executed along with short and long press events, so if someone want to react on a button press (short or long), the PRESSED trigger event can get checked. And the pressed event isn't senseless executed on a binding restart anymore. - Error messages improved - Deprecation-Notice - New deprecation warning integrated in the innogysmarthome binding - Livisi renamed to LIVISI - SHC channels are now initialized correctly - New "status" channel for the SHC with the values ACTIVE, INITIALIZING and SHUTTINGDOWN - Code and documentation optimizations - Fix for PT-PSS action - Support for SHC classic - The websocket is hosted on another port. - Update for Temperature-Channel-Definitions and Translations (de) - Update for Power-Channel-Definitions - Further translations (de) for devices and channels - Refactoring branch integrated (some tests added and a lot of code optimizations for example smaller methods, better method names, more simple flows without continue and return in void methods, improved NULL handling, etc.) - Code optimization (special handling for VariableActuator removed which seems to be not required anymore) - The thing status is now set to offline when the device is not reachable (even on binding start up) - The thing status is now set to online again when the device is reachable again - Clearer description of the invert switch of the RollerShutter (ISR2) - Copyright notices corrected - Imports optimized - Changed handling of pointTemperature (QuantityType instead of DecimalType) - Code optimization (device status listeners are now registered with device id, so it isn't necessary anymore to call all listeners to find the right matching listener for the device event). - Code optimization (not working mDNS bridge discovery removed). - Explicit idle timeout removed (seems not to be required anymore for the local API and may cause problems with SHC 1, there occur EOFExceptions) - Code optimizations (Debug code removed which isn't required anymore) - Warn message added which is logged when the temperature to set is not between min and max temperature (this can happen when the user uses the REST-API instead of MainUI or probably also when set via a rule). - Code optimizations (stronger/consequent use of QuantityType instead of DecimalType) - Temperature values outside the possible range of 6 - 30 °C are now set to 6 / 30 °C. Therefore a temperature channel can get set to 0 °C for example by a rule and this is automatically changed to 6 °C (and causes a debug message). - Code optimizations - Bug fixes regarding UnitsOfMeasurements (Number:Power) - Tests repaired - The local API returns "[]" for empty objects which should only get used for arrays... This is now handled by the binding with replacing "[]" by "null". This error occurred with SHC 1, it isn't known if SHC 2 is also affected. - Number:Dimensionless (percent) introduced for humidity and luminance - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - The configVersion is now also available for SHC 1 bridges. - More changes to Descriptions, Translations, Icons, Channel-Order, Channel-Config - Trace logging of responses added to increase the traceability - The SHC channels should now also get filled for SHC classic - cpu, memory and disc channels are now defined as percentage (Number:Dimensionless) - Jetty-HttpClient replaced by simple UrlConnection, because Jetty-HttpClient has problems with high frequency execution of requests. There were EOFExceptions with SHC classic when 2 or more requests were executed within the same second... - Readme updated - Copyright notices corrected - Additions in ReadMe for RST2 / WRT - The bridge channels (cpu, memory, disc and operation state) are now updated every minute for SHC 1 / classic (because there are no such events for SHC 1 / classic) - Bug-fix for SHC 1 / classic: Device attributes are now updated correctly for SHC 1 / classic (there is another response structure, which caused that some attributes were not found / update). This should have affected battery low and reachable (thing status) information. - There are also raw events which report changes regarding the bridge channels (cpu, memory, disc and operation status). There are now processed. - Token request JSON changed to lower-case (to be compatible with the new SHC firmware update and this should enable to use the standard logics) - SHC 2 can now get authenticated with the OAuth 2.0 standard logics of OpenHAB (with x-www-form-urlencoded instead of json). The old special json logic is still there to support SHC 1 (but SHC 1 will also get updated soon). - SHC 1 supports now short and long button pressed events - Outdated custom login logics removed. SHC 2 and SHC 1 / classic supports now OAuth 2.0 login requests, therefore the default login logics of OpenHAB can now get used. - README updated for the required software version of SHC 1 / classic - Code review findings fixed - Code review findings fixed (Channel Ids renamed to lowerCamelCase) - Unused code removed - Code review findings fixed (Device status messages localized) - Code review findings fixed (label of BooleanStateActuator renamed) - Code review findings fixed (hard-coded units resolved) - Code review findings fixed (unit of measurements changed form Power to Energy when it is unit Wh instead of W) - Code review findings fixed (thing status BRIDGE_OFFLINE changed to COMMUNICATION_ERROR, because BRIDGE_OFFLINE is intended for sub/child devices, not for the bridge thing) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Compiler warnings fixed - Code review findings fixed - Code review findings fixed (channel ids renamed) - Code review findings fixed (tags for temperature and humidity added) - Code review findings fixed (properties renamed to lowerCamelCase like the default properties) - Code review findings fixed (non-null warnings fixed, performance increased by reducing requests) - Code review findings fixed (non-null warnings fixed) - Code review findings fixed (non-null warnings fixed in tests) - Copyright notices updated - Unnecessary log line removed - Code review findings fixed (non-null warnings fixed in tests) - Test fixed (WebSocketClient can't get mocked completely which caused an Exception) - Code review findings fixed (various code optimizations) - Code review findings fixed (channel-type-ids renamed to lowerCamelCase) - Code review findings fixed (translation simplified) - Code review findings fixed (temperature point handling converted in UoM) - Code review findings fixed (Exception handling improved) - Code review findings fixed (offline state precised when the bridge isn't found/configured) - Code review findings fixed (exception logs deactivated within tests to reduce to console output when running the tests) - Code review findings fixed (thing status is now checked instead of bridge status) - Code review findings fixed (DeviceStructureManager can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (LivisiClient can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (OAuthService can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (unnecessary type check removed) - Code review findings fixed (warning messages within tests reduced) - Code review findings fixed (more when the bridge connection state changes) - Code review findings fixed (reconnect job changed from scheduleAtFixedRate to scheduleWithFixedDelay - recommended by the SAT warnings). - Code review findings fixed (unused method removed). - Representation property introduced to auto-ignore textual defined things at discovery/scan - Code review findings fixed (more detailed error message for SHC not reachable added). - Fix ChannelTypeID in Readme.md sample - Code review findings fixed ("/event/ControllerConnectivityChanged" doesn't change the bridge thing to offline anymore, because it isn't important for the local API anymore). - Code review findings fixed (point temperature commands with DecimalType instead of QuantityType can now also get handled). - Tests added regarding handleCommand - Code optimization (constant for the "invert" channel parameter added) - Code optimization (log messages within tests avoided) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Co-authored-by: RalphSester <ralph.sester@sester-edv.de>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…l API and some improvements) (openhab#12440) - Initial version added (copied and renamed from the innogysmarthome binding) - The local API is now used, authorization, bridge initialization and discovery is already working - Potential NullPointerExceptions fixed - Adding battery-low-Channel support for ISC2 - More optimizations and local API changes in the ReadMe - The key button counter channels are now updated correctly. The according trigger channels should now also work fine. - Bug fixes regarding button pressed event. The pressed event is now executed along with short and long press events, so if someone want to react on a button press (short or long), the PRESSED trigger event can get checked. And the pressed event isn't senseless executed on a binding restart anymore. - Error messages improved - Deprecation-Notice - New deprecation warning integrated in the innogysmarthome binding - Livisi renamed to LIVISI - SHC channels are now initialized correctly - New "status" channel for the SHC with the values ACTIVE, INITIALIZING and SHUTTINGDOWN - Code and documentation optimizations - Fix for PT-PSS action - Support for SHC classic - The websocket is hosted on another port. - Update for Temperature-Channel-Definitions and Translations (de) - Update for Power-Channel-Definitions - Further translations (de) for devices and channels - Refactoring branch integrated (some tests added and a lot of code optimizations for example smaller methods, better method names, more simple flows without continue and return in void methods, improved NULL handling, etc.) - Code optimization (special handling for VariableActuator removed which seems to be not required anymore) - The thing status is now set to offline when the device is not reachable (even on binding start up) - The thing status is now set to online again when the device is reachable again - Clearer description of the invert switch of the RollerShutter (ISR2) - Copyright notices corrected - Imports optimized - Changed handling of pointTemperature (QuantityType instead of DecimalType) - Code optimization (device status listeners are now registered with device id, so it isn't necessary anymore to call all listeners to find the right matching listener for the device event). - Code optimization (not working mDNS bridge discovery removed). - Explicit idle timeout removed (seems not to be required anymore for the local API and may cause problems with SHC 1, there occur EOFExceptions) - Code optimizations (Debug code removed which isn't required anymore) - Warn message added which is logged when the temperature to set is not between min and max temperature (this can happen when the user uses the REST-API instead of MainUI or probably also when set via a rule). - Code optimizations (stronger/consequent use of QuantityType instead of DecimalType) - Temperature values outside the possible range of 6 - 30 °C are now set to 6 / 30 °C. Therefore a temperature channel can get set to 0 °C for example by a rule and this is automatically changed to 6 °C (and causes a debug message). - Code optimizations - Bug fixes regarding UnitsOfMeasurements (Number:Power) - Tests repaired - The local API returns "[]" for empty objects which should only get used for arrays... This is now handled by the binding with replacing "[]" by "null". This error occurred with SHC 1, it isn't known if SHC 2 is also affected. - Number:Dimensionless (percent) introduced for humidity and luminance - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - The configVersion is now also available for SHC 1 bridges. - More changes to Descriptions, Translations, Icons, Channel-Order, Channel-Config - Trace logging of responses added to increase the traceability - The SHC channels should now also get filled for SHC classic - cpu, memory and disc channels are now defined as percentage (Number:Dimensionless) - Jetty-HttpClient replaced by simple UrlConnection, because Jetty-HttpClient has problems with high frequency execution of requests. There were EOFExceptions with SHC classic when 2 or more requests were executed within the same second... - Readme updated - Copyright notices corrected - Additions in ReadMe for RST2 / WRT - The bridge channels (cpu, memory, disc and operation state) are now updated every minute for SHC 1 / classic (because there are no such events for SHC 1 / classic) - Bug-fix for SHC 1 / classic: Device attributes are now updated correctly for SHC 1 / classic (there is another response structure, which caused that some attributes were not found / update). This should have affected battery low and reachable (thing status) information. - There are also raw events which report changes regarding the bridge channels (cpu, memory, disc and operation status). There are now processed. - Token request JSON changed to lower-case (to be compatible with the new SHC firmware update and this should enable to use the standard logics) - SHC 2 can now get authenticated with the OAuth 2.0 standard logics of OpenHAB (with x-www-form-urlencoded instead of json). The old special json logic is still there to support SHC 1 (but SHC 1 will also get updated soon). - SHC 1 supports now short and long button pressed events - Outdated custom login logics removed. SHC 2 and SHC 1 / classic supports now OAuth 2.0 login requests, therefore the default login logics of OpenHAB can now get used. - README updated for the required software version of SHC 1 / classic - Code review findings fixed - Code review findings fixed (Channel Ids renamed to lowerCamelCase) - Unused code removed - Code review findings fixed (Device status messages localized) - Code review findings fixed (label of BooleanStateActuator renamed) - Code review findings fixed (hard-coded units resolved) - Code review findings fixed (unit of measurements changed form Power to Energy when it is unit Wh instead of W) - Code review findings fixed (thing status BRIDGE_OFFLINE changed to COMMUNICATION_ERROR, because BRIDGE_OFFLINE is intended for sub/child devices, not for the bridge thing) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Compiler warnings fixed - Code review findings fixed - Code review findings fixed (channel ids renamed) - Code review findings fixed (tags for temperature and humidity added) - Code review findings fixed (properties renamed to lowerCamelCase like the default properties) - Code review findings fixed (non-null warnings fixed, performance increased by reducing requests) - Code review findings fixed (non-null warnings fixed) - Code review findings fixed (non-null warnings fixed in tests) - Copyright notices updated - Unnecessary log line removed - Code review findings fixed (non-null warnings fixed in tests) - Test fixed (WebSocketClient can't get mocked completely which caused an Exception) - Code review findings fixed (various code optimizations) - Code review findings fixed (channel-type-ids renamed to lowerCamelCase) - Code review findings fixed (translation simplified) - Code review findings fixed (temperature point handling converted in UoM) - Code review findings fixed (Exception handling improved) - Code review findings fixed (offline state precised when the bridge isn't found/configured) - Code review findings fixed (exception logs deactivated within tests to reduce to console output when running the tests) - Code review findings fixed (thing status is now checked instead of bridge status) - Code review findings fixed (DeviceStructureManager can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (LivisiClient can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (OAuthService can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (unnecessary type check removed) - Code review findings fixed (warning messages within tests reduced) - Code review findings fixed (more when the bridge connection state changes) - Code review findings fixed (reconnect job changed from scheduleAtFixedRate to scheduleWithFixedDelay - recommended by the SAT warnings). - Code review findings fixed (unused method removed). - Representation property introduced to auto-ignore textual defined things at discovery/scan - Code review findings fixed (more detailed error message for SHC not reachable added). - Fix ChannelTypeID in Readme.md sample - Code review findings fixed ("/event/ControllerConnectivityChanged" doesn't change the bridge thing to offline anymore, because it isn't important for the local API anymore). - Code review findings fixed (point temperature commands with DecimalType instead of QuantityType can now also get handled). - Tests added regarding handleCommand - Code optimization (constant for the "invert" channel parameter added) - Code optimization (log messages within tests avoided) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Co-authored-by: RalphSester <ralph.sester@sester-edv.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…l API and some improvements) (openhab#12440) - Initial version added (copied and renamed from the innogysmarthome binding) - The local API is now used, authorization, bridge initialization and discovery is already working - Potential NullPointerExceptions fixed - Adding battery-low-Channel support for ISC2 - More optimizations and local API changes in the ReadMe - The key button counter channels are now updated correctly. The according trigger channels should now also work fine. - Bug fixes regarding button pressed event. The pressed event is now executed along with short and long press events, so if someone want to react on a button press (short or long), the PRESSED trigger event can get checked. And the pressed event isn't senseless executed on a binding restart anymore. - Error messages improved - Deprecation-Notice - New deprecation warning integrated in the innogysmarthome binding - Livisi renamed to LIVISI - SHC channels are now initialized correctly - New "status" channel for the SHC with the values ACTIVE, INITIALIZING and SHUTTINGDOWN - Code and documentation optimizations - Fix for PT-PSS action - Support for SHC classic - The websocket is hosted on another port. - Update for Temperature-Channel-Definitions and Translations (de) - Update for Power-Channel-Definitions - Further translations (de) for devices and channels - Refactoring branch integrated (some tests added and a lot of code optimizations for example smaller methods, better method names, more simple flows without continue and return in void methods, improved NULL handling, etc.) - Code optimization (special handling for VariableActuator removed which seems to be not required anymore) - The thing status is now set to offline when the device is not reachable (even on binding start up) - The thing status is now set to online again when the device is reachable again - Clearer description of the invert switch of the RollerShutter (ISR2) - Copyright notices corrected - Imports optimized - Changed handling of pointTemperature (QuantityType instead of DecimalType) - Code optimization (device status listeners are now registered with device id, so it isn't necessary anymore to call all listeners to find the right matching listener for the device event). - Code optimization (not working mDNS bridge discovery removed). - Explicit idle timeout removed (seems not to be required anymore for the local API and may cause problems with SHC 1, there occur EOFExceptions) - Code optimizations (Debug code removed which isn't required anymore) - Warn message added which is logged when the temperature to set is not between min and max temperature (this can happen when the user uses the REST-API instead of MainUI or probably also when set via a rule). - Code optimizations (stronger/consequent use of QuantityType instead of DecimalType) - Temperature values outside the possible range of 6 - 30 °C are now set to 6 / 30 °C. Therefore a temperature channel can get set to 0 °C for example by a rule and this is automatically changed to 6 °C (and causes a debug message). - Code optimizations - Bug fixes regarding UnitsOfMeasurements (Number:Power) - Tests repaired - The local API returns "[]" for empty objects which should only get used for arrays... This is now handled by the binding with replacing "[]" by "null". This error occurred with SHC 1, it isn't known if SHC 2 is also affected. - Number:Dimensionless (percent) introduced for humidity and luminance - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - The configVersion is now also available for SHC 1 bridges. - More changes to Descriptions, Translations, Icons, Channel-Order, Channel-Config - Trace logging of responses added to increase the traceability - The SHC channels should now also get filled for SHC classic - cpu, memory and disc channels are now defined as percentage (Number:Dimensionless) - Jetty-HttpClient replaced by simple UrlConnection, because Jetty-HttpClient has problems with high frequency execution of requests. There were EOFExceptions with SHC classic when 2 or more requests were executed within the same second... - Readme updated - Copyright notices corrected - Additions in ReadMe for RST2 / WRT - The bridge channels (cpu, memory, disc and operation state) are now updated every minute for SHC 1 / classic (because there are no such events for SHC 1 / classic) - Bug-fix for SHC 1 / classic: Device attributes are now updated correctly for SHC 1 / classic (there is another response structure, which caused that some attributes were not found / update). This should have affected battery low and reachable (thing status) information. - There are also raw events which report changes regarding the bridge channels (cpu, memory, disc and operation status). There are now processed. - Token request JSON changed to lower-case (to be compatible with the new SHC firmware update and this should enable to use the standard logics) - SHC 2 can now get authenticated with the OAuth 2.0 standard logics of OpenHAB (with x-www-form-urlencoded instead of json). The old special json logic is still there to support SHC 1 (but SHC 1 will also get updated soon). - SHC 1 supports now short and long button pressed events - Outdated custom login logics removed. SHC 2 and SHC 1 / classic supports now OAuth 2.0 login requests, therefore the default login logics of OpenHAB can now get used. - README updated for the required software version of SHC 1 / classic - Code review findings fixed - Code review findings fixed (Channel Ids renamed to lowerCamelCase) - Unused code removed - Code review findings fixed (Device status messages localized) - Code review findings fixed (label of BooleanStateActuator renamed) - Code review findings fixed (hard-coded units resolved) - Code review findings fixed (unit of measurements changed form Power to Energy when it is unit Wh instead of W) - Code review findings fixed (thing status BRIDGE_OFFLINE changed to COMMUNICATION_ERROR, because BRIDGE_OFFLINE is intended for sub/child devices, not for the bridge thing) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Compiler warnings fixed - Code review findings fixed - Code review findings fixed (channel ids renamed) - Code review findings fixed (tags for temperature and humidity added) - Code review findings fixed (properties renamed to lowerCamelCase like the default properties) - Code review findings fixed (non-null warnings fixed, performance increased by reducing requests) - Code review findings fixed (non-null warnings fixed) - Code review findings fixed (non-null warnings fixed in tests) - Copyright notices updated - Unnecessary log line removed - Code review findings fixed (non-null warnings fixed in tests) - Test fixed (WebSocketClient can't get mocked completely which caused an Exception) - Code review findings fixed (various code optimizations) - Code review findings fixed (channel-type-ids renamed to lowerCamelCase) - Code review findings fixed (translation simplified) - Code review findings fixed (temperature point handling converted in UoM) - Code review findings fixed (Exception handling improved) - Code review findings fixed (offline state precised when the bridge isn't found/configured) - Code review findings fixed (exception logs deactivated within tests to reduce to console output when running the tests) - Code review findings fixed (thing status is now checked instead of bridge status) - Code review findings fixed (DeviceStructureManager can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (LivisiClient can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (OAuthService can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (unnecessary type check removed) - Code review findings fixed (warning messages within tests reduced) - Code review findings fixed (more when the bridge connection state changes) - Code review findings fixed (reconnect job changed from scheduleAtFixedRate to scheduleWithFixedDelay - recommended by the SAT warnings). - Code review findings fixed (unused method removed). - Representation property introduced to auto-ignore textual defined things at discovery/scan - Code review findings fixed (more detailed error message for SHC not reachable added). - Fix ChannelTypeID in Readme.md sample - Code review findings fixed ("/event/ControllerConnectivityChanged" doesn't change the bridge thing to offline anymore, because it isn't important for the local API anymore). - Code review findings fixed (point temperature commands with DecimalType instead of QuantityType can now also get handled). - Tests added regarding handleCommand - Code optimization (constant for the "invert" channel parameter added) - Code optimization (log messages within tests avoided) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Co-authored-by: RalphSester <ralph.sester@sester-edv.de>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…l API and some improvements) (openhab#12440) - Initial version added (copied and renamed from the innogysmarthome binding) - The local API is now used, authorization, bridge initialization and discovery is already working - Potential NullPointerExceptions fixed - Adding battery-low-Channel support for ISC2 - More optimizations and local API changes in the ReadMe - The key button counter channels are now updated correctly. The according trigger channels should now also work fine. - Bug fixes regarding button pressed event. The pressed event is now executed along with short and long press events, so if someone want to react on a button press (short or long), the PRESSED trigger event can get checked. And the pressed event isn't senseless executed on a binding restart anymore. - Error messages improved - Deprecation-Notice - New deprecation warning integrated in the innogysmarthome binding - Livisi renamed to LIVISI - SHC channels are now initialized correctly - New "status" channel for the SHC with the values ACTIVE, INITIALIZING and SHUTTINGDOWN - Code and documentation optimizations - Fix for PT-PSS action - Support for SHC classic - The websocket is hosted on another port. - Update for Temperature-Channel-Definitions and Translations (de) - Update for Power-Channel-Definitions - Further translations (de) for devices and channels - Refactoring branch integrated (some tests added and a lot of code optimizations for example smaller methods, better method names, more simple flows without continue and return in void methods, improved NULL handling, etc.) - Code optimization (special handling for VariableActuator removed which seems to be not required anymore) - The thing status is now set to offline when the device is not reachable (even on binding start up) - The thing status is now set to online again when the device is reachable again - Clearer description of the invert switch of the RollerShutter (ISR2) - Copyright notices corrected - Imports optimized - Changed handling of pointTemperature (QuantityType instead of DecimalType) - Code optimization (device status listeners are now registered with device id, so it isn't necessary anymore to call all listeners to find the right matching listener for the device event). - Code optimization (not working mDNS bridge discovery removed). - Explicit idle timeout removed (seems not to be required anymore for the local API and may cause problems with SHC 1, there occur EOFExceptions) - Code optimizations (Debug code removed which isn't required anymore) - Warn message added which is logged when the temperature to set is not between min and max temperature (this can happen when the user uses the REST-API instead of MainUI or probably also when set via a rule). - Code optimizations (stronger/consequent use of QuantityType instead of DecimalType) - Temperature values outside the possible range of 6 - 30 °C are now set to 6 / 30 °C. Therefore a temperature channel can get set to 0 °C for example by a rule and this is automatically changed to 6 °C (and causes a debug message). - Code optimizations - Bug fixes regarding UnitsOfMeasurements (Number:Power) - Tests repaired - The local API returns "[]" for empty objects which should only get used for arrays... This is now handled by the binding with replacing "[]" by "null". This error occurred with SHC 1, it isn't known if SHC 2 is also affected. - Number:Dimensionless (percent) introduced for humidity and luminance - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - Button events are now supported for SHC 1 (Classic), but without information about short or long press (isn't available for this SHC model). - The configVersion is now also available for SHC 1 bridges. - More changes to Descriptions, Translations, Icons, Channel-Order, Channel-Config - Trace logging of responses added to increase the traceability - The SHC channels should now also get filled for SHC classic - cpu, memory and disc channels are now defined as percentage (Number:Dimensionless) - Jetty-HttpClient replaced by simple UrlConnection, because Jetty-HttpClient has problems with high frequency execution of requests. There were EOFExceptions with SHC classic when 2 or more requests were executed within the same second... - Readme updated - Copyright notices corrected - Additions in ReadMe for RST2 / WRT - The bridge channels (cpu, memory, disc and operation state) are now updated every minute for SHC 1 / classic (because there are no such events for SHC 1 / classic) - Bug-fix for SHC 1 / classic: Device attributes are now updated correctly for SHC 1 / classic (there is another response structure, which caused that some attributes were not found / update). This should have affected battery low and reachable (thing status) information. - There are also raw events which report changes regarding the bridge channels (cpu, memory, disc and operation status). There are now processed. - Token request JSON changed to lower-case (to be compatible with the new SHC firmware update and this should enable to use the standard logics) - SHC 2 can now get authenticated with the OAuth 2.0 standard logics of OpenHAB (with x-www-form-urlencoded instead of json). The old special json logic is still there to support SHC 1 (but SHC 1 will also get updated soon). - SHC 1 supports now short and long button pressed events - Outdated custom login logics removed. SHC 2 and SHC 1 / classic supports now OAuth 2.0 login requests, therefore the default login logics of OpenHAB can now get used. - README updated for the required software version of SHC 1 / classic - Code review findings fixed - Code review findings fixed (Channel Ids renamed to lowerCamelCase) - Unused code removed - Code review findings fixed (Device status messages localized) - Code review findings fixed (label of BooleanStateActuator renamed) - Code review findings fixed (hard-coded units resolved) - Code review findings fixed (unit of measurements changed form Power to Energy when it is unit Wh instead of W) - Code review findings fixed (thing status BRIDGE_OFFLINE changed to COMMUNICATION_ERROR, because BRIDGE_OFFLINE is intended for sub/child devices, not for the bridge thing) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Code review findings fixed ("initialize" is now returned faster and all requests are executed asynchronously) - Compiler warnings fixed - Code review findings fixed - Code review findings fixed (channel ids renamed) - Code review findings fixed (tags for temperature and humidity added) - Code review findings fixed (properties renamed to lowerCamelCase like the default properties) - Code review findings fixed (non-null warnings fixed, performance increased by reducing requests) - Code review findings fixed (non-null warnings fixed) - Code review findings fixed (non-null warnings fixed in tests) - Copyright notices updated - Unnecessary log line removed - Code review findings fixed (non-null warnings fixed in tests) - Test fixed (WebSocketClient can't get mocked completely which caused an Exception) - Code review findings fixed (various code optimizations) - Code review findings fixed (channel-type-ids renamed to lowerCamelCase) - Code review findings fixed (translation simplified) - Code review findings fixed (temperature point handling converted in UoM) - Code review findings fixed (Exception handling improved) - Code review findings fixed (offline state precised when the bridge isn't found/configured) - Code review findings fixed (exception logs deactivated within tests to reduce to console output when running the tests) - Code review findings fixed (thing status is now checked instead of bridge status) - Code review findings fixed (DeviceStructureManager can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (LivisiClient can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (OAuthService can now be marked as NonNull because it is initialized within the initialize method) - Code review findings fixed (unnecessary type check removed) - Code review findings fixed (warning messages within tests reduced) - Code review findings fixed (more when the bridge connection state changes) - Code review findings fixed (reconnect job changed from scheduleAtFixedRate to scheduleWithFixedDelay - recommended by the SAT warnings). - Code review findings fixed (unused method removed). - Representation property introduced to auto-ignore textual defined things at discovery/scan - Code review findings fixed (more detailed error message for SHC not reachable added). - Fix ChannelTypeID in Readme.md sample - Code review findings fixed ("/event/ControllerConnectivityChanged" doesn't change the bridge thing to offline anymore, because it isn't important for the local API anymore). - Code review findings fixed (point temperature commands with DecimalType instead of QuantityType can now also get handled). - Tests added regarding handleCommand - Code optimization (constant for the "invert" channel parameter added) - Code optimization (log messages within tests avoided) Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Co-authored-by: RalphSester <ralph.sester@sester-edv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request solves issue #10440.
Innogy SmartHome was renamed to LIVISI SmartHome. This pull-request introduces a "new" binding correctly named livisismarthome which was created by a copy of innogysmarthome. The old innogysmarthome binding gets deprecation notices with this pull-request too. This has the advantage that it doesn't break the innogysmarthome binding configurations with the next release of OpenHAB, so the users have more time to switch to the new binding and the new binding uses only the new local API which doesn't require an internet connection in comparision to the innogysmarthome binding which still uses the cloud API.
Our wish is to get the new livisismarthome binding in with OpenHAB 3.3 (summer 2022) and to remove the innogysmarthome binding with the winter 2022 release of OpenHAB.
This logo can get used for the documentation on openhab.org/addons (I don't know where to add it): https://community.livisi.de/media/188/
But there is more. Here is the complete changelog: