Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mercedesme] Initial contribution #13044

Merged
merged 58 commits into from
Aug 23, 2022
Merged

[mercedesme] Initial contribution #13044

merged 58 commits into from
Aug 23, 2022

Conversation

weymann
Copy link
Contributor

@weymann weymann commented Jun 30, 2022

Mercedes Me binding to access Mercedes vehicles in openHAB.

Based on the Mercedes Benz integration which is discussed in the Community.

Community test & discussion is available for this particular binding

@weymann weymann requested a review from a team as a code owner June 30, 2022 20:34
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mercedes-me-binding/136852/23

@weymann
initial commit
0faf8b7 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
mb callback function
b3e1d2b 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
rework auth
679dd94 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add callback server
89765bd 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
bridge thing separation
4a76022 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
first working authorization
83229ef 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
channel implementation
e5494d6 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
store auth data in items
e605006 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
use StorageService to store token
79ebb8a 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
first readme.md
ef12817 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add radius channels
b61f84a 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add image support
374bcdc 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
created seperate image cache
4570ff4 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
bugfixes for authorization
9d2cea6 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
bugfixes for authorization
012d992 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
bugfixes for multi account usage
bc804d9 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
update readme
4467f60 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add StateOptionProvider
b44088f 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add jpeg image support
dbbe2f7 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
full example added
0a129c3 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add last-update channel for each group
fe04dd1 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
bugfixes from community tests
951f4cb 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
correct VehcileHandler status updates
7051fd9 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
enhance debug information for API calls
8768dd2 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
adjust loglevels
fe8a6b4 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
breaking change: token stored with key clientId
3c1f5de 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add translation
b9eb76b 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
add migration function to restore token from old keys
36f15c3 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
fix review comments
3d0e1dc 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
rework token and status handling
27b9ae0 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann weymann requested a review from jlaur August 16, 2022 20:48
@weymann
adapt link to binding URL after release
26b063e 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
take full control of listener update
324e3fe 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
jlaur
jlaur requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now had a look at the most recent changes, and it looks really good. I have added a few new comments, and I think we are quite close now. Some error handling could still be improved by throwing and catching exceptions instead of comparing strings through multiple layers, but I won't insist on this. One of my comments is an example of this, but additional examples can be found by tracking usages of Constants.NOT_SET and Constants.EMPTY.

.../org.openhab.binding.mercedesme/src/test/java/org/openhab/binding/mercedesme/FileReader.java Outdated Show resolved Hide resolved
.../org.openhab.binding.mercedesme/src/test/java/org/openhab/binding/mercedesme/FileReader.java Outdated Show resolved Hide resolved
...b.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java Outdated Show resolved Hide resolved
...b.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java Outdated Show resolved Hide resolved
...b.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/server/Utils.java Outdated Show resolved Hide resolved
...mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/handler/VehicleHandler.java Outdated Show resolved Hide resolved
...nhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/Constants.java Show resolved Hide resolved
...nhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/Constants.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mercedesme/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mercedesme/README.md Show resolved Hide resolved
@jlaur
Copy link
Contributor

jlaur commented Aug 17, 2022

I have some repository concerns seeing megabytes of images, but will need help from @openhab/add-ons-maintainers and/or @openhab/documentation-maintainers regarding guidelines/recommended practices here.

Ping @openhab/add-ons-maintainers - still >1 MB of images, do we have any policies on this? If all bindings did this, it would be 1/2 GB of data in the repository + additional changes over time when updating images.

@weymann - while waiting for some opinions and/or guidelines, consider if you can reduce number and/or size of pictures further. Some might be replaceable by textual descriptions?

@weymann
remove permament token response logging
8d3ae05 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
fix json version
c7e734c 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
Copy link
Contributor Author

weymann commented Aug 22, 2022

@weymann - while waiting for some opinions and/or guidelines, consider if you can reduce number and/or size of pictures further. Some might be replaceable by textual descriptions?

Compressed pictures to ~400 KB.
I want to keep them to guide the users through the very strict first setup described in readme

@weymann
review corrections
b296695 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann
fix review comments part 3
9338fd2 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann weymann requested review from Hilbrand and jlaur August 23, 2022 19:49
jlaur
jlaur approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@jlaur jlaur merged commit 704000e into openhab:main Aug 23, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 23, 2022
@jlaur
Copy link
Contributor

jlaur commented Aug 28, 2022

@weymann - in case you missed it, if you create a PR towards openhab/openhab-docs like described in https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website, the logo will be displayed with your binding in the list of bindings and on the documentation page - see for example: https://next.openhab.org/addons/

@jlaur jlaur mentioned this pull request Aug 30, 2022
Merged
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@weymann @leifbladt
[mercedesme] Initial contribution (openhab#13044)
6b978fb 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@weymann @andan67
[mercedesme] Initial contribution (openhab#13044)
abfa3a7 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@weymann @andrasU
[mercedesme] Initial contribution (openhab#13044)
6ec8f95 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022
@weymann @MarcelGoerentz-eaton
[mercedesme] Initial contribution (openhab#13044)
e2b2455 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@weymann @psmedley
[mercedesme] Initial contribution (openhab#13044)
f7cf8f6 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@weymann @nemerdaud
[mercedesme] Initial contribution (openhab#13044)
5e4b800 
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@maniac103 maniac103 mentioned this pull request Mar 8, 2023
Merged
@weymann weymann deleted the mercedes-me branch June 11, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@andrewfg andrewfg Awaiting requested review from andrewfg

@Hilbrand Hilbrand Awaiting requested review from Hilbrand

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@weymann @openhab-bot @andrewfg @jlaur @Hilbrand