-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[goecharger] fix issue with category #12682
Conversation
removed category temperature from thing-types.xml remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
I don't understand how having a category could be a problem. It even seems correct to consider this category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please see my comment with what I believe is the root cause.
@@ -205,14 +205,12 @@ | |||
<label>Temperature type 2 port</label> | |||
<description>Temperature of the Go-eCharger on the type 2 port</description> | |||
<state pattern="%d %unit%" readOnly="true"/> | |||
<category>Temperature</category> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be necessary to remove. XSD definition:
<xs:complexType name="channelType">
<xs:sequence>
<xs:element name="item-type" type="xs:string" minOccurs="0"/>
<xs:element name="kind" type="xs:string" minOccurs="0"/>
<xs:element name="label" type="xs:string"/>
<xs:element name="description" type="xs:string" minOccurs="0"/>
<xs:element name="category" type="xs:string" minOccurs="0"/>
<xs:element name="tags" type="thing-description:tags" minOccurs="0"/>
<xs:element name="state" type="thing-description:state"/>
<xs:element name="command" type="thing-description:command"/>
<xs:element name="event" type="thing-description:event" minOccurs="0"/>
<xs:element name="autoUpdatePolicy" type="thing-description:auto-update-policy" minOccurs="0"/>
<xs:choice minOccurs="0">
<xs:element name="config-description" type="config-description:configDescription"/>
<xs:element name="config-description-ref" type="config-description:configDescriptionRef"/>
</xs:choice>
</xs:sequence>
<xs:attribute name="id" type="config-description:idRestrictionPattern" use="required"/>
<xs:attribute name="advanced" type="xs:boolean" default="false" use="optional"/>
<xs:attribute name="system" type="xs:boolean" default="false" use="optional"/>
</xs:complexType>
Can you please try to swap the lines with state
and category
, so they are in the correct order?
@ranzen84 - can you add "Fixes #xxxxx" to pull request description, so the issue will be automatically linked and closed when PR is merged? |
Generally, the tag "category" Is before the tag "state". I am not sure if this is important. |
@jlaur was faster than me. |
Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* [goecharger] category before state remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
* [goecharger] category before state remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [goecharger] category before state remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
category before state in thing-types.xml (Fixes #12661)
remove warning within readme.md
Signed-off-by: Reinhard Plaim reinhardplaim@gmail.com