[goecharger] fix issue with category #12682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed category temperature from thing-types.xml remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
|
I don't understand how having a category could be a problem. It even seems correct to consider this category. |
jlaur
requested changes
May 4, 2022
| @@ -205,14 +205,12 @@ | |||
| <label>Temperature type 2 port</label> | |||
| <description>Temperature of the Go-eCharger on the type 2 port</description> | |||
| <state pattern="%d %unit%" readOnly="true"/> | |||
| <category>Temperature</category> | |||
There was a problem hiding this comment.
This should not be necessary to remove. XSD definition:
<xs:complexType name="channelType">
<xs:sequence>
<xs:element name="item-type" type="xs:string" minOccurs="0"/>
<xs:element name="kind" type="xs:string" minOccurs="0"/>
<xs:element name="label" type="xs:string"/>
<xs:element name="description" type="xs:string" minOccurs="0"/>
<xs:element name="category" type="xs:string" minOccurs="0"/>
<xs:element name="tags" type="thing-description:tags" minOccurs="0"/>
<xs:element name="state" type="thing-description:state"/>
<xs:element name="command" type="thing-description:command"/>
<xs:element name="event" type="thing-description:event" minOccurs="0"/>
<xs:element name="autoUpdatePolicy" type="thing-description:auto-update-policy" minOccurs="0"/>
<xs:choice minOccurs="0">
<xs:element name="config-description" type="config-description:configDescription"/>
<xs:element name="config-description-ref" type="config-description:configDescriptionRef"/>
</xs:choice>
</xs:sequence>
<xs:attribute name="id" type="config-description:idRestrictionPattern" use="required"/>
<xs:attribute name="advanced" type="xs:boolean" default="false" use="optional"/>
<xs:attribute name="system" type="xs:boolean" default="false" use="optional"/>
</xs:complexType>
Can you please try to swap the lines with state and category, so they are in the correct order?
|
@ranzen84 - can you add "Fixes #xxxxx" to pull request description, so the issue will be automatically linked and closed when PR is merged? |
|
Generally, the tag "category" Is before the tag "state". I am not sure if this is important. |
|
@jlaur was faster than me. |
Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [goecharger] category before state remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [goecharger] category before state remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [goecharger] category before state remove warning within readme.md Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
category before state in thing-types.xml (Fixes #12661)
remove warning within readme.md
Signed-off-by: Reinhard Plaim reinhardplaim@gmail.com