-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deutschebahn] DB API Marketplace adjustments #12786
[deutschebahn] DB API Marketplace adjustments #12786
Conversation
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
98b5ff3
to
e0db487
Compare
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/binding-for-deutschebahn-timetable/127534/14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Only a minor request to remove the German translation update to avoid Crowdin conflicts.
...s/org.openhab.binding.deutschebahn/src/main/resources/OH-INF/i18n/deutschebahn_de.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the adjustments!
* Changes API URL and authentication Headers for DB API Marketplace. * Fixed some typos and code style findings. Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
* Changes API URL and authentication Headers for DB API Marketplace. * Fixed some typos and code style findings. Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
* Changes API URL and authentication Headers for DB API Marketplace. * Fixed some typos and code style findings. Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* Changes API URL and authentication Headers for DB API Marketplace. * Fixed some typos and code style findings. Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
The URL and the authentication Headers have changed, due the DB will move the timetables api from the Open-Data-Portal to the DB API Marketplace middle this year.
Closes #12785