Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deutschebahn] DB API Marketplace adjustments #12786

Merged
merged 3 commits into from
May 26, 2022

Conversation

soenkekueper
Copy link
Contributor

The URL and the authentication Headers have changed, due the DB will move the timetables api from the Open-Data-Portal to the DB API Marketplace middle this year.

Closes #12785

@soenkekueper soenkekueper added the enhancement An enhancement or new feature for an existing add-on label May 22, 2022
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
@soenkekueper soenkekueper force-pushed the 12785_DB-API-Markeplace-Changes branch from 98b5ff3 to e0db487 Compare May 22, 2022 11:29
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/binding-for-deutschebahn-timetable/127534/14

@jlaur jlaur changed the title [deutschebahn] DB API Markeplace adjustments [deutschebahn] DB API Marketplace adjustments May 22, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Only a minor request to remove the German translation update to avoid Crowdin conflicts.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the adjustments!

@jlaur jlaur merged commit 7600190 into openhab:main May 26, 2022
@jlaur jlaur added this to the 3.3 milestone May 26, 2022
@soenkekueper soenkekueper deleted the 12785_DB-API-Markeplace-Changes branch May 26, 2022 16:19
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* Changes API URL and authentication Headers for DB API Marketplace.
* Fixed some typos and code style findings.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Changes API URL and authentication Headers for DB API Marketplace.
* Fixed some typos and code style findings.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Changes API URL and authentication Headers for DB API Marketplace.
* Fixed some typos and code style findings.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* Changes API URL and authentication Headers for DB API Marketplace.
* Fixed some typos and code style findings.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deutschebahn] Update to DB API Marketplace
3 participants