[hdpowerview] Change method names to match documentation #12796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* [hdpowerview] refactor method names Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [hdpowerview] refactor method names Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [hdpowerview] refactor method names Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [hdpowerview] refactor method names Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this post @jlaur pointed out a naming inconsistency concerning the two types of secondary shade -- namely regular secondary shades vs. Duolite blackout secondary shades.
In this PR the method names have been refactored so that methods and fields for both types of secondary shades include the word 'secondary' in them. No functionality has been changed; this is only done to improve clarity of the code.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch