-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any Version Update ? #1
Comments
Hi @kingy444, thanks for reaching out. I have at least one update not incorporated into the document yet: openhab/openhab-addons#12761. I would need to recheck if I missed others. I'm aware that the distribution format is not PR friendly, so I'm only using this repository as a distribution channel. If you send me your updates in some kind of "instruction format", I'll be happy to add them. For example: "Page 27, ShadeType: Add ShadeType 38 with description "Silhouette Duolite" and ShadeCapabilities 9" It might be a good idea to extract these tables from the document into some md file or the like as "source format", although the PDF also has the advantage that everything is self-contained. I'll think about it, maybe it would make sense to do both, i.e. open up for PR's maintaining the tables, and then recompile the PDF from time to time. |
@kingy444 - btw, you might also be interested in openhab/openhab-addons#12678. |
@kingy444 - "Title on Closed" for capabilities 1 was already fixed by openhab/openhab-addons#12237. I'm updating the table/documentation now according to our last few pull requests. |
@kingy444 - document is now updated according to latest code changes in openHAB. Blackout shade support is still missing though. |
BlackoutShade is special - i misspoke above - it is not secondary shade reversed it only has one motor - but it accepts poskind2 and the values of position2 need to be inverted as i understand (0 is open and 65k is closed) |
@jlaur / @kingy444 just to confirm that I think the OH code base reflects the current latest state of knowledge, and @jlaur 's document should indeed be updated to reflect that. But
Indeed. It has one motor but supports both a primary and secondary rail position; the motor basically unwinds the first rail cables to lower the rail until it reaches its end stop, and then it continues to unwind the cables for the second rail. For this reason these have special interlocking logic in the code to allow for the physical limitations in the possible positions of the primary and secondary rails. |
To be more specific;
So in @jlaur 's document the table for Capabilities 8 and 9 should have a "yes" in both the primary and the secondary rail columns. Note: Capabilities 9 shades also have a separate additional tilt anywhere motor, so they provide a position2/posKind2 JSON element as well. |
^
|
@andrewfg - you have added "yes" to Secondary Rail for capabilities 8 and 9, but in the openHAB code this is not the case:
Should this be fixed in the code? |
No. It works fine as it is. The only issue is one of nomenclature: these shades DO have both a primary and a secondary rail, but the rails are both driven tightly interlocked by one motor. So strictly they have a secondary rail but not an INDEPENDENT secondary rail. |
^ |
@andrewfg - at least some direct mapping between table and code would be preferable. So what does "Secondary Rail" mean in the table vs. what does this mean in the openHAB code when defining capabilities:
If "withBlackoutShade" would be added to the table, should 8 and 9 still be marked with "Secondary Rail"? |
^ .. so yes, probably an extra column in the table would be the correct approach. |
@jlaur I was thinking about this further overnight... There are two known types of shade that have two rails: a) top down bottom up, and b) Duolite blackout shades. In neither case are the primary and secondary fully independent. In both cases they are supported as a secondary roller shutter in the UI. But in each case they are differently interlocked. And in each case they are differently encoded in the JSON. Top Down Bottom Up
Duolite Blackout
Now, the actual code of the binding does de-facto exactly as described above. So for me the only questions are..
|
@andrewfg I had the inverse in my head - the rear shade couldn’t move until the front was open but from the quoted I read that now that the rear shade needs to be treated as the priority (not sure you saw my post on other thread about using 1 slider) but would this equate to Do I have that right now ? |
@andrewfg - sorry for getting back late. I have not been able to fully catch up and read/understand all what has been posted here and in sander76/aio-powerview-api#16. Maybe I need a simplified version. :-) We have some concrete shade types involved, having some additional complexity:
I have seen front panel and back panel mentioned. Not sure exactly what it refers to, just mentioning as part of finding best terminology. Then we have the current table mentioning primary rail and secondary rail. So far I have understood rail as connected to a motor. And last blackout shade has been mentioned. Is that the same as back panel? Also, we might distinguish between physical attributes like number of motors and logical attributes like whether a back/secondary panel or rail (?) exists, whether it is controlled by motor (or rail?) 1 or 2. The shade type description can contain product names, but probably the attributes should not. So I would refrain from using "Duolite" when describing shade attributes/capabilities. To simplify the table:
|
@jlaur some pictures.. |
Ok. The I would suggest to call it 'secondaryOverlapped' (see below..)
Either way is fine for me.
|
Here is the file with my images.. |
New document uploaded with capabilities table updated. @kingy444 - if you still have something to add, feel free to post comments here. I'll close the issue though as specific table change requests should have been done now. |
Little pedantic but im trying to code HA inline with the naming here so OH and HA is similar. This is both the capability info and classes. Every other class we describe them as 'Bottom up', 'Top Down', 'Tilt Only 180' etc - basically their functionality Could i suggest we change them to 'Dual Shade Interlocked' and 'Dual Shade Interlocked Tilt 90' ? Also we have listed as tiltanywhere - I am still working with someone with type 38 (type 9) but their description would indicate they arent tiltAnywhere or tiltOnClosed |
I would suggest Dual Shade Overlapped .. (but otherwise agreed) |
Guess I’ll explain my thinking and see how you feel then my thinking was more around how they function here and not how they look the movement is interlocked in that they cannot move independently and require the other to be in a predetermined position before moving and I guess this goes back to the table too - perhaps overlapped isn’t the right word their either I see Overlapped as more of a description of how they look than the way they function ie we refer to Silhoutte as ‘Bottom up tilt 90’ not ‘sheer blind with vanes’ |
Interlocked is not the correct word. TDBU shades are also interlocked. But their rails are in the same plane (not overlapped) so their interlocking is different than for overlapped shades. |
PS tilt on closed shades are also interlocked.. |
This led me to look into some definitions - looks like interlocked is related to overlapping as well With your comments re other shades having interlocking relationship what about dropping the second word all together Dual Shade side note: looks like the guy flicked you the details for the palm beach shutters on HA forum - could you PM them to me too. Annoyingly hasn’t sent them on yet - not sure why he didn’t just post on the forum |
I'm on the road today and tomorrow, but will forward the pms when I am back. There is a lot of stuff so I need to sort it out first. |
No worries - im happy for it in raw format and i can try and digest if that makes it easier. |
Great work to date - will be very helpful for HomeAssistant integration and was pointed this way by the OpenHAB dev.
Just wanted to touch base as i am updating our internal databases if you had any new updates (we do)
Would be happy to share here but pdf is not really the format for us to be able to raise pull requests to you
The text was updated successfully, but these errors were encountered: