Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Prepare for CrowdIn translations, bug fixes #12822

Merged
merged 2 commits into from
May 28, 2022
Merged

[shelly] Prepare for CrowdIn translations, bug fixes #12822

merged 2 commits into from
May 28, 2022

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 added the enhancement An enhancement or new feature for an existing add-on label May 26, 2022
@markus7017 markus7017 self-assigned this May 26, 2022
@markus7017 markus7017 requested a review from fwolter May 26, 2022 20:48
@lolodomo
Copy link
Contributor

lolodomo commented May 27, 2022 •
edited
Loading

Please create separate PRs for issues and preparation for Crowdin translations.

Edit: this would have been better but as I reviewed the full PR, you can keep as it is.

lolodomo
lolodomo requested changes May 27, 2022
View reviewed changes
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/config/config.xml Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/thing/device.xml Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/thing/relay.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/thing/relay.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/thing/relay.xml Outdated Show resolved Hide resolved
@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on and removed enhancement An enhancement or new feature for an existing add-on labels May 27, 2022
@markus7017
Copy link
Contributor Author

A quick merge would help to speed up 😜 the CrowdIn translation bringing back German and maybe an additional language if the community is supporting.

How to remove the current German translation from CrowdIn? Several labels have changed so it's better to redo the translation.

@lolodomo
Copy link
Contributor

A quick merge would help to speed up ...

I will merge as soon as you correct the bugs I identified during the review.
So it can be fast if you are fast :)

@lolodomo
Copy link
Contributor

lolodomo commented May 27, 2022 •
edited
Loading

How to remove the current German translation from CrowdIn? Several labels have changed so it's better to redo the translation.

Good question. There is certainly something to do in Crowdin.
Once this PR will be merged, someone could invalidate all remaining German translations.
But a lot will disappear automatically just by merging this PR (as many entries were removed).

@markus7017
Copy link
Contributor Author

Changes are applied - good catches! Thank you

Once this PR will be merged, someone could invalidate all remaining German translations.

Who is "someone"? :-) Let's check after the merge

@markus7017
Prepare for CrowdIn translations, includes translation of binding
610f947 
settings; fix openhab#12815 endless initialization; fix openhab#12535 invalid log
messages

Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
review changes applied
4a6108a 
Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
@lolodomo
Copy link
Contributor

lolodomo commented May 28, 2022 •
edited
Loading

Who is "someone"? :-) Let's check after the merge

Me for example ;) I am now unvalidating all entries.

lolodomo
lolodomo approved these changes May 28, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 5291d7d into openhab:main May 28, 2022
@lolodomo lolodomo added this to the 3.3 milestone May 28, 2022
@lolodomo
Copy link
Contributor

lolodomo commented May 28, 2022 •
edited
Loading

@markus7017 : this is ready in Crowdin. 16 pages before, 10 pages now, so you made a big reduction, good. There is less than one page with entries without German translations, all others are present (already translated) but to be validated. If you want to propose another translation, you can.

@markus7017 markus7017 deleted the shelly_crowdin branch May 28, 2022 09:56
@markus7017
Copy link
Contributor Author

@lolodomo Translation on CrowdIn is completed. Is there a way to export the shelly_de.properties to do a final check?

@lolodomo
Copy link
Contributor

@lolodomo Translation on CrowdIn is completed. Is there a way to export the shelly_de.properties to do a final check?

First, someone speaking German has to validate all the translations in Crowdin.
Then a PR will be automatically created in Github with the new content of the file shelly_de.properties and you will be able to comment if you find something strange.

@markus7017
Copy link
Contributor Author

markus7017 commented May 28, 2022 •
edited
Loading

@lolodomo Translation on CrowdIn is completed. Is there a way to export the shelly_de.properties to do a final check?

First, someone speaking German has to validate all the translations in Crowdin. Then a PR will be automatically created in Github with the new content of the file shelly_de.properties and you will be able to comment if you find something strange.

How to trigger that person? I'm German myself

Statistic shows 100% translated, 0% approved
You could download the de properties under the ... button

@lolodomo
Copy link
Contributor

lolodomo commented May 28, 2022 •
edited
Loading

0% approved because you requested yesterday to un-approve all of them ... which I did this morning.
The Crowdin manager for German translations is certainly @cweitkamp . He has to validate all your proposed translations.

@markus7017
Copy link
Contributor Author

@cweitkamp I verified the generated shelly_de.properties, which looks good.
In addition I added German translations for all missing io., persistence., voice.* and transform.* bundles
Have fun :-)

@cweitkamp
Copy link
Contributor

👍

Great. Thank you very much.

@markus7017
Copy link
Contributor Author

👍

Great. Thank you very much.

Let me know if there are more. It takes some time, but no sooo hard

I notice that the merge brought in DE translations like

channel-group-type.shelly.meter1.label = Stromzähler 1
channel-group-type.shelly.meter2.label = Stromzähler 2
channel-group-type.shelly.meter3.label = Stromzähler 3
channel-group-type.shelly.meter4.label = Stromzähler 4

Doesn't Crowdin uses UTF-8?

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@markus7017 @leifbladt
[shelly] Prepare for CrowdIn translations, bug fixes (openhab#12822)
f59d529 
* Prepare for CrowdIn translations, includes translation of binding
settings; fix openhab#12815 endless initialization; fix openhab#12535 invalid log
messages

Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@markus7017 @andan67
[shelly] Prepare for CrowdIn translations, bug fixes (openhab#12822)
cbdf38c 
* Prepare for CrowdIn translations, includes translation of binding
settings; fix openhab#12815 endless initialization; fix openhab#12535 invalid log
messages

Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@markus7017 @andrasU
[shelly] Prepare for CrowdIn translations, bug fixes (openhab#12822)
d167929 
* Prepare for CrowdIn translations, includes translation of binding
settings; fix openhab#12815 endless initialization; fix openhab#12535 invalid log
messages

Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@markus7017 @psmedley
[shelly] Prepare for CrowdIn translations, bug fixes (openhab#12822)
71f9d92 
* Prepare for CrowdIn translations, includes translation of binding
settings; fix openhab#12815 endless initialization; fix openhab#12535 invalid log
messages

Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@fwolter fwolter Awaiting requested review from fwolter

Assignees

@markus7017 markus7017

Labels
bug An unexpected problem or unintended behavior of an add-on translation
Projects
None yet
Milestone
3.3
3 participants
@markus7017 @lolodomo @cweitkamp