Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fronius] Add additional Inverter DC channels #12867

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jun 3, 2022

Resolve #12856

Add the following new channels for Fronius Gen24 inverters:

  • inverterdatachannelidc2
  • inverterdatachannelidc3
  • inverterdatachanneludc2
  • inverterdatachanneludc3

Add calculated DC power channels:

  • inverterdatachannelpdc
  • inverterdatachannelpdc2
  • inverterdatachannelpdc3

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some early feedback for your draft.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jun 3, 2022
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng marked this pull request as ready for review June 5, 2022 22:51
@jimtng jimtng requested a review from trokohl as a code owner June 5, 2022 22:51
@jimtng jimtng requested a review from jlaur June 5, 2022 22:52
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jlaur jlaur merged commit 25d9315 into openhab:main Jun 7, 2022
@jlaur jlaur added this to the 3.3 milestone Jun 7, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fronius-symo-inverter-input-for-second-dc-channel-not-working/137147/1

@jimtng jimtng deleted the fronius-inputs branch July 11, 2022 13:06
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* [fronius] Add additional Inverter DC channels
* [fronius] Update channel description and translations
* [fronius] Add calculated DC Power channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [fronius] Add additional Inverter DC channels
* [fronius] Update channel description and translations
* [fronius] Add calculated DC Power channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [fronius] Add additional Inverter DC channels
* [fronius] Update channel description and translations
* [fronius] Add calculated DC Power channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [fronius] Add additional Inverter DC channels
* [fronius] Update channel description and translations
* [fronius] Add calculated DC Power channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [fronius] Add additional Inverter DC channels
* [fronius] Update channel description and translations
* [fronius] Add calculated DC Power channels

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fronius] Add channels for secondary and tertiary DC input
3 participants