-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fronius] Add additional Inverter DC channels #12867
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some early feedback for your draft.
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
* [fronius] Add additional Inverter DC channels * [fronius] Update channel description and translations * [fronius] Add calculated DC Power channels Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
* [fronius] Add additional Inverter DC channels * [fronius] Update channel description and translations * [fronius] Add calculated DC Power channels Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
* [fronius] Add additional Inverter DC channels * [fronius] Update channel description and translations * [fronius] Add calculated DC Power channels Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [fronius] Add additional Inverter DC channels * [fronius] Update channel description and translations * [fronius] Add calculated DC Power channels Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
* [fronius] Add additional Inverter DC channels * [fronius] Update channel description and translations * [fronius] Add calculated DC Power channels Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Resolve #12856
Add the following new channels for Fronius Gen24 inverters:
Add calculated DC power channels: