-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netatmo] Correct Discovery service #12869
Conversation
Signed-off-by: clinique <gael@lhopital.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I propose @jlaur or me to test that before merging. |
I didn't previously focus on testing discovery, but I remember you did some testing with findings and are more into the problem, so please go ahead without me. :-) |
I have my account bridge setup in a configuration file. For the home, the camera and the persons, it looks good, I can approve them, the hierarchy is good and they went ONLINE. Nothing is duplicated in the inbox. If it works for security stuff, it should work too for the weather station. |
This is certainly the discovery through the homesdata that creates these duplicated things. Wasn't your code trying to filter them ? |
...mo/src/main/java/org/openhab/binding/netatmo/internal/discovery/NetatmoDiscoveryService.java
Show resolved
Hide resolved
Signed-off-by: clinique <gael@lhopital.org>
I will test again with the last version of the code but I believe it will work ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me and change was tested with success.
Thank you.
* Correct Discovery service * Enhancing weather station module handling Signed-off-by: clinique <gael@lhopital.org>
* Correct Discovery service * Enhancing weather station module handling Signed-off-by: clinique <gael@lhopital.org>
* Correct Discovery service * Enhancing weather station module handling Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* Correct Discovery service * Enhancing weather station module handling Signed-off-by: clinique <gael@lhopital.org>
* Correct Discovery service * Enhancing weather station module handling Signed-off-by: clinique <gael@lhopital.org>
While previous behavior seemed to work, it made the weather station child of a home, being inconsistant with ModuleType description and expected API calls (e.g. calls to measurement channels were broken).
On netatmo side, this dependency exists but is partially reflected in API calls structure, most of them still being based on initial organization (before the introduction of homes for energy and security purpose).
Signed-off-by: clinique gael@lhopital.org