Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulseaudio] Fix source format options #12913

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Jun 9, 2022

Signed-off-by: Miguel Álvarez miguelwork92@gmail.com

I made some mistakes when implementing the AudioSource describing the supported formats, I just realize it while testing a new keyword spotter with different bit depths and endianness.
This pr fixes it.
Reference here: https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/SupportedAudioFormats/

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from peuter as a code owner June 9, 2022 22:30
@GiviMAD GiviMAD requested a review from lolodomo June 9, 2022 22:30
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jun 10, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 798d59b into openhab:main Jun 10, 2022
@jlaur jlaur added this to the 3.3 milestone Jun 10, 2022
@lolodomo
Copy link
Contributor

As options labels were updated the i18n tool has to be re-run to update the default translations.

@jlaur
Copy link
Contributor

jlaur commented Jun 10, 2022

As options labels were updated the i18n tool has to be re-run to update the default translations.

Sorry, too early for me, somehow missed that second file. @GiviMAD - can you create another PR with that?

@GiviMAD
Copy link
Member Author

GiviMAD commented Jun 10, 2022

Thanks @lolodomo, I totally forgot about it.
@jlaur, yes I'll do it.

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants