[gardena] Eliminate frequent web service re-starting #13238
Conversation
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
|
@gerrieg is this PR related to this post on the forum? https://community.openhab.org/t/gardena-error-429-limit-exceeded/137419/62?u=andrewfg |
|
yes exactly, this pull request should fix that |
...inding.gardena/src/main/java/org/openhab/binding/gardena/internal/GardenaSmartWebSocket.java
Outdated
Show resolved
Hide resolved
...inding.gardena/src/main/java/org/openhab/binding/gardena/internal/GardenaSmartWebSocket.java
Show resolved
Hide resolved
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
|
I am ok to merge the PR as it is, except if someone still thinks |
No problem with that. But the task method should be synchronized.. |
|
@gerrieg, @andrewfg - can you of you change the PR title so it reflects the change from user-perspective? The title will be part of the release notes, and I don't think users will understand what connection tracker is. Alternatively remove the bug label if this fix is something additional for another PR already merged into 3.4, thus already covered in release notes? |
andrewfg
changed the title
* Removed provider header, no longer necessary * Fixed connection tracker not starting after some websocket restarts Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
* Removed provider header, no longer necessary * Fixed connection tracker not starting after some websocket restarts Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
* Removed provider header, no longer necessary * Fixed connection tracker not starting after some websocket restarts Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* Removed provider header, no longer necessary * Fixed connection tracker not starting after some websocket restarts Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
* Removed provider header, no longer necessary * Fixed connection tracker not starting after some websocket restarts Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
The connection tracker does not start after some websocket connections are disconnected. Therefore, every 2 minutes some API requests are sent to Gardena. This can lead to the message 429 limit exceeded after a few days/weeks.