Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt] Add missing broker connection configuration parameters #13303

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

wborn
Copy link
Member

@wborn wborn commented Aug 21, 2022

Allows to configure the following broker connection configuration parameters:

  • Protocol: TCP (default), WEBSOCKETS
  • MQTT Version: V3 (default), V5
  • Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Depends on openhab/openhab-core#3068

@wborn wborn added the enhancement An enhancement or new feature for an existing add-on label Aug 21, 2022
@wborn wborn added the awaiting other PR Depends on another PR label Aug 21, 2022
Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team August 21, 2022 18:37
@wborn wborn removed the awaiting other PR Depends on another PR label Aug 26, 2022
@wborn wborn requested review from a team and removed request for a team August 26, 2022 06:39
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jlaur jlaur merged commit cfa20db into openhab:main Aug 26, 2022
@wborn wborn deleted the mqtt-config branch August 26, 2022 06:53
@jlaur jlaur added this to the 3.4 milestone Aug 26, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
…b#13303)

Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…b#13303)

Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…b#13303)

Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022
…b#13303)

Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…b#13303)

Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…b#13303)

Allows to configure the following broker connection configuration parameters:

* Protocol: TCP (default), WEBSOCKETS
* MQTT Version: V3 (default), V5
* Hostname Validation: true (default), false

The defaults are chosen to remain backwards compatible.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants