[hdpowerview] Correct shade capabilities information #13330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
|
@jlaur I am putting this PR on GitHub, but have marked it as a draft, pending any further learnings concerning the Gen 3 hub API. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
reviewed
Aug 28, 2022
...c/main/java/org/openhab/binding/hdpowerview/internal/database/ShadeCapabilitiesDatabase.java
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* [hdpowerview] corrections to capabilities database Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [hdpowerview] corrections to capabilities database Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [hdpowerview] corrections to capabilities database Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
* [hdpowerview] corrections to capabilities database Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [hdpowerview] corrections to capabilities database Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [hdpowerview] corrections to capabilities database Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Resolves #13320
Hunter Douglas has introduced its Generation 3 hubs. And the documentation for Gen 3 includes information (among many other things) about the Shade Capabilities. See screenshot below. Until now the OH binding uses an unofficial Capabilities database that has been based on detective work and trial and error. The Gen 3 official information confirms that 8 out of the 10 Capabilities in OH are indeed correct, but it also indicates that two of the existing Capabilities are reversed, and that one additional Capabilities entry is missing.
Solution
This PR swaps Capabilities 3 and 4 to match the Gen 3 official information. And it adds the so far missing Capabilities 10 the binding.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch