[Konnected] Using default onvalue if configured is null #13354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
reviewed
Sep 4, 2022
...konnected/src/main/java/org/openhab/binding/konnected/internal/handler/KonnectedHandler.java
Outdated
Show resolved
Hide resolved
haavar
force-pushed
the
null_onvalue
branch
2 times, most recently
from
96956ba
to
f252a86
Compare
jlaur
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Thanks! I have added a few comments. Also checked openhab/openhab-distro#1412, and it seems like existing compatibility note also covers these breaking changes.
bundles/org.openhab.binding.konnected/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.konnected/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
...inding.konnected/src/main/java/org/openhab/binding/konnected/internal/ZoneConfiguration.java
Show resolved
Hide resolved
...inding.konnected/src/main/java/org/openhab/binding/konnected/internal/ZoneConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Haavar Valeur <haavar@haavar.com>
…r names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
…F/thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Haavar Valeur <haavar@haavar.com>
…F/thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Haavar Valeur <haavar@haavar.com>
Signed-off-by: Haavar Valeur <haavar@haavar.com>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* Using default onvalue if configured is null * Using DTO for channel configuration. Changing channel config parameter names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Using default onvalue if configured is null * Using DTO for channel configuration. Changing channel config parameter names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Using default onvalue if configured is null * Using DTO for channel configuration. Changing channel config parameter names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
* Using default onvalue if configured is null * Using DTO for channel configuration. Changing channel config parameter names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Using default onvalue if configured is null * Using DTO for channel configuration. Changing channel config parameter names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Using default onvalue if configured is null * Using DTO for channel configuration. Changing channel config parameter names to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing I found that sometimes configuration for onvalue can be null.
Maybe it's a bad assumption, but I assumed that the configuration would be populated with the default value set in thing-types.xml. That does not seem to be the case, and the application need to fall back to the default value.