Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tapocontrol] Fix configuration error #13677

Merged
merged 1 commit into from
Nov 14, 2022
Merged

[tapocontrol] Fix configuration error #13677

merged 1 commit into from
Nov 14, 2022

Conversation

wildcs
Copy link
Contributor

@wildcs wildcs commented Nov 7, 2022 •
edited
Loading

  • fixed configuration error
  • improved response logging and error handling

This PR fixes error reading configuration with integer values.
Configuration handling revised
Also tracing of sent and received http request was enhanced, because some unkown communication errors will occur sometimes.

It has been discussed at https://community.openhab.org/t/tapocontrol-control-tapo-smart-wifi-devices-with-openhab/118389/216.

A compiled jar is available at https://github.com/wildcs/oh3_compiled-addons/tree/tapocontrol

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tapocontrol-control-tapo-smart-wifi-devices-with-openhab/118389/218

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Nov 8, 2022
@jlaur jlaur changed the title [tapocontrol] Fixed configuration error [tapocontrol] Fix configuration error Nov 9, 2022
@wildcs wildcs requested a review from lolodomo November 9, 2022 20:44
lolodomo
lolodomo requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally to my following comments, I am not sure why you are removing unit tests ?

...control/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoBridgeHandler.java Outdated Show resolved Hide resolved
...control/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoBridgeHandler.java Outdated Show resolved Hide resolved
...c/main/java/org/openhab/binding/tapocontrol/internal/structures/TapoBridgeConfiguration.java Outdated Show resolved Hide resolved
...control/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoBridgeHandler.java Outdated Show resolved Hide resolved
...control/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoBridgeHandler.java Outdated Show resolved Hide resolved
...ng.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoDevice.java Outdated Show resolved Hide resolved
...ng.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoDevice.java Outdated Show resolved Hide resolved
@wildcs wildcs requested a review from lolodomo November 12, 2022 18:27
lolodomo
lolodomo requested changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for a last round.

PS: I will not investigate too much in your test units but I have a strange feeling that your new discovery class for tests is the same as the real class.

...c/test/java/org/openhab/binding/tapocontrol/internal/structures/TapoBridgeConfiguration.java Show resolved Hide resolved
bundles/org.openhab.binding.tapocontrol/src/test/TapoDiscoveryService.java Outdated Show resolved Hide resolved
@wildcs wildcs requested a review from lolodomo November 13, 2022 17:53
@wildcs
[tapocontrol] fixed configuration error
03ab7b3 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
lolodomo
lolodomo approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 40723a8 into openhab:main Nov 14, 2022
@lolodomo lolodomo added this to the 3.4 milestone Nov 14, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 22, 2022
@wildcs @andrasU
[tapocontrol] fixed configuration error (openhab#13677)
8db1832 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
@wildcs @andrasU
[tapocontrol] fixed configuration error (openhab#13677)
4c42f2b 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@wildcs @borazslo
[tapocontrol] fixed configuration error (openhab#13677)
5f87aaa 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@wildcs @psmedley
[tapocontrol] fixed configuration error (openhab#13677)
00d0c6b 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@wildcs @nemerdaud
[tapocontrol] fixed configuration error (openhab#13677)
2ddb43e 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
@wildcs @andrasU
[tapocontrol] fixed configuration error (openhab#13677)
a47b170 
* improved response logging and error handling

Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@wildcs @openhab-bot @lolodomo @jlaur