[mqtt.homeassistant] Implement JSON schema lights #13808

ccutrer · 2022-11-29T16:05:17Z

No description provided.

antroids

Thanks for continuing to work on this addon!

...src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/JSONSchemaLight.java

ccutrer · 2022-12-21T20:43:28Z

Thanks for the comments. Sorry it has taken me so long to get back to them; I've been focusing on other addons and core for the 3.4.0 release, considering this PR a lower priority. I hope to address them in the next week or two.

ccutrer · 2023-01-29T16:27:39Z

Force push is just a rebase that resolves a trivial merge conflict (another PR also added a method a (different) new method to the bottom of AbstractComponent). I'll add additional commits addressing the comments soon. I totally forgot this PR was still hanging out.

Signed-off-by: Cody Cutrer <cody@cutrer.us>

ccutrer · 2023-01-29T17:01:48Z

@antroids : all comments addressed

Signed-off-by: Cody Cutrer <cody@cutrer.us>

… bare Signed-off-by: Cody Cutrer <cody@cutrer.us>

antroids

LGTM
Thank you!

Signed-off-by: Cody Cutrer <cody@cutrer.us>

openhab-bot · 2023-02-25T11:22:16Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/how-to-debug-a-homeassistant-channel-discovery-failure/144755/1

lolodomo

LGTM, thank you

jlaur · 2023-03-27T06:32:41Z

@ccutrer - I think this PR may have introduced some test failures, can you check? See for example https://ci.openhab.org/job/PR-openHAB-Addons/14886/

[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests
[ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.11 s <<< FAILURE! - in org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests
[ERROR] org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests.testRgb  Time elapsed: 0.025 s  <<< ERROR!
java.lang.ClassCastException: class org.openhab.core.library.types.StringType cannot be cast to class org.openhab.core.library.types.OnOffType (org.openhab.core.library.types.StringType and org.openhab.core.library.types.OnOffType are in unnamed module of loader 'app')
	at org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLight.updateChannelState(JSONSchemaLight.java:186)
	at org.openhab.binding.mqtt.generic.ChannelState.processMessage(ChannelState.java:223)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.lambda$1(AbstractComponentTests.java:249)
	at java.base/java.util.concurrent.ConcurrentHashMap$KeySetView.forEach(ConcurrentHashMap.java:4706)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.publishMessage(AbstractComponentTests.java:249)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.publishMessage(AbstractComponentTests.java:235)
	at org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests.testRgb(JSONSchemaLightTests.java:74)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:217)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:213)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:138)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:55)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:223)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:175)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:139)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)

[ERROR] org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests.testOnOffOnly  Time elapsed: 0.042 s  <<< ERROR!
java.lang.ClassCastException: class org.openhab.core.library.types.StringType cannot be cast to class org.openhab.core.library.types.OnOffType (org.openhab.core.library.types.StringType and org.openhab.core.library.types.OnOffType are in unnamed module of loader 'app')
	at org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLight.updateChannelState(JSONSchemaLight.java:186)
	at org.openhab.binding.mqtt.generic.ChannelState.processMessage(ChannelState.java:223)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.lambda$1(AbstractComponentTests.java:249)
	at java.base/java.util.concurrent.ConcurrentHashMap$KeySetView.forEach(ConcurrentHashMap.java:4706)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.publishMessage(AbstractComponentTests.java:249)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.publishMessage(AbstractComponentTests.java:235)
	at org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests.testOnOffOnly(JSONSchemaLightTests.java:142)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:217)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:213)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:138)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:55)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:223)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:175)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:139)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)

[ERROR] org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests.testBrightnessAndOnOff  Time elapsed: 0.02 s  <<< ERROR!
java.lang.ClassCastException: class org.openhab.core.library.types.StringType cannot be cast to class org.openhab.core.library.types.OnOffType (org.openhab.core.library.types.StringType and org.openhab.core.library.types.OnOffType are in unnamed module of loader 'app')
	at org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLight.updateChannelState(JSONSchemaLight.java:186)
	at org.openhab.binding.mqtt.generic.ChannelState.processMessage(ChannelState.java:223)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.lambda$1(AbstractComponentTests.java:249)
	at java.base/java.util.concurrent.ConcurrentHashMap$KeySetView.forEach(ConcurrentHashMap.java:4706)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.publishMessage(AbstractComponentTests.java:249)
	at org.openhab.binding.mqtt.homeassistant.internal.component.AbstractComponentTests.publishMessage(AbstractComponentTests.java:235)
	at org.openhab.binding.mqtt.homeassistant.internal.component.JSONSchemaLightTests.testBrightnessAndOnOff(JSONSchemaLightTests.java:114)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
	at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:217)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:213)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:138)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:55)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:223)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:175)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:139)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)

[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.CameraTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 s - in org.openhab.binding.mqtt.homeassistant.internal.component.CameraTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.AlarmControlPanelTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 s - in org.openhab.binding.mqtt.homeassistant.internal.component.AlarmControlPanelTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.HAConfigurationTests
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.051 s - in org.openhab.binding.mqtt.homeassistant.internal.component.HAConfigurationTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.BinarySensorTests
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.06 s - in org.openhab.binding.mqtt.homeassistant.internal.component.BinarySensorTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.LockTests
[main] WARN  o.o.b.m.h.i.DiscoverComponents - HomeAssistant discover error: invalid configuration of thing 0x0000000000000000_lock_zigbee2mqtt component lock: Component:Lock does not support forced optimistic mode
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 s - in org.openhab.binding.mqtt.homeassistant.internal.component.LockTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.ClimateTests
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.256 s - in org.openhab.binding.mqtt.homeassistant.internal.component.ClimateTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.CoverTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 s - in org.openhab.binding.mqtt.homeassistant.internal.component.CoverTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.FanTests
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 s - in org.openhab.binding.mqtt.homeassistant.internal.component.FanTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.component.SelectTests
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.048 s - in org.openhab.binding.mqtt.homeassistant.internal.component.SelectTests
[INFO] Running org.openhab.binding.mqtt.homeassistant.internal.handler.HomeAssistantThingHandlerTests
[main] WARN  o.o.b.m.h.i.DiscoverComponents - Configuration of HomeAssistant thing id_zigbee2mqtt is empty
[main] WARN  o.o.b.m.h.i.DiscoverComponents - HomeAssistant discover error: invalid configuration of thing id_zigbee2mqtt component sensor: Cannot parse channel configuration JSON
[main] WARN  o.o.b.m.h.i.DiscoverComponents - HomeAssistant discover error: thing id_zigbee2mqtt component type is unsupported: unsupportedType
[INFO] No Errors
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.334 s - in org.openhab.binding.mqtt.homeassistant.internal.handler.HomeAssistantThingHandlerTests
[INFO] 
[INFO] --- sat-plugin:0.13.0:checkstyle (sat-all) @ org.openhab.binding.nest.tests ---
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   JSONSchemaLightTests.testBrightnessAndOnOff:114->AbstractComponentTests.publishMessage:235->AbstractComponentTests.publishMessage:249->AbstractComponentTests.lambda$1:249 » ClassCast class org.openhab.core.library.types.StringType cannot be cast to class org.openhab.core.library.types.OnOffType (org.openhab.core.library.types.StringType and org.openhab.core.library.types.OnOffType are in unnamed module of loader 'app')
[ERROR]   JSONSchemaLightTests.testOnOffOnly:142->AbstractComponentTests.publishMessage:235->AbstractComponentTests.publishMessage:249->AbstractComponentTests.lambda$1:249 » ClassCast class org.openhab.core.library.types.StringType cannot be cast to class org.openhab.core.library.types.OnOffType (org.openhab.core.library.types.StringType and org.openhab.core.library.types.OnOffType are in unnamed module of loader 'app')
[ERROR]   JSONSchemaLightTests.testRgb:74->AbstractComponentTests.publishMessage:235->AbstractComponentTests.publishMessage:249->AbstractComponentTests.lambda$1:249 » ClassCast class org.openhab.core.library.types.StringType cannot be cast to class org.openhab.core.library.types.OnOffType (org.openhab.core.library.types.StringType and org.openhab.core.library.types.OnOffType are in unnamed module of loader 'app')
[INFO] 
[ERROR] Tests run: 50, Failures: 0, Errors: 3, Skipped: 0
[INFO] 
[ERROR]

ccutrer · 2023-03-27T12:19:30Z

Yup. I'll try to take a look later today.

jlaur · 2023-03-28T15:40:57Z

@ccutrer - I have created #14716 as a temporary "fix" as the build is broken.

ccutrer · 2023-03-28T15:55:49Z

Okay. I have time to look this morning. The problem is this PR and #12238 weren't tested together, and the latter changed some assumptions this one depended on. I'm fixing now.

* [mqtt.homeassistant] implement JSON schema lights * [mqtt.homeassistant] use enum for current state of color mode * [mqtt.homeassistant] use implicit lambdas * [mqtt.homeassistant] remove string constants in favor of an enum * [mqtt.homeassistant] allow sending ON and brightness commands through bare * [mqtt.homeassistant] turn down debug logging --------- Signed-off-by: Cody Cutrer <cody@cutrer.us>

ccutrer requested review from davidgraeff and antroids as code owners November 29, 2022 16:05

ccutrer force-pushed the mqtt-hass-json-schema-lights branch from da9e023 to 6b96213 Compare November 29, 2022 16:06

jlaur added the enhancement An enhancement or new feature for an existing add-on label Dec 1, 2022

antroids requested changes Dec 3, 2022

View reviewed changes

ccutrer force-pushed the mqtt-hass-json-schema-lights branch from 6b96213 to 8c1d4d1 Compare January 29, 2023 16:26

[mqtt.homeassistant] implement JSON schema lights

147b7e9

Signed-off-by: Cody Cutrer <cody@cutrer.us>

ccutrer force-pushed the mqtt-hass-json-schema-lights branch from 8c1d4d1 to 147b7e9 Compare January 29, 2023 16:29

[mqtt.homeassistant] address review comments

4ab504c

Signed-off-by: Cody Cutrer <cody@cutrer.us>

ccutrer added 5 commits January 29, 2023 10:19

[mqtt.homeassistant] address SAT issues

4935dac

Signed-off-by: Cody Cutrer <cody@cutrer.us>

[mqtt.homeassistant] use enum for current state of color mode

93fe1c3

Signed-off-by: Cody Cutrer <cody@cutrer.us>

[mqtt.homeassistant] use implicit lambdas

f844f6c

Signed-off-by: Cody Cutrer <cody@cutrer.us>

[mqtt.homeassistant] remove string constants in favor of an enum

48f4f2d

Signed-off-by: Cody Cutrer <cody@cutrer.us>

[mqtt.homeassistant] allow sending ON and brightness commands through…

0a81a41

… bare Signed-off-by: Cody Cutrer <cody@cutrer.us>

antroids approved these changes Jan 30, 2023

View reviewed changes

[mqtt.homeassistant] turn down debug logging

bc1a5c1

Signed-off-by: Cody Cutrer <cody@cutrer.us>

wborn changed the title ~~[mqtt.homeassistant] implement JSON schema lights~~ [mqtt.homeassistant] Implement JSON schema lights Mar 17, 2023

lolodomo approved these changes Mar 26, 2023

View reviewed changes

lolodomo merged commit f98f820 into openhab:main Mar 26, 2023

lolodomo added this to the 4.0 milestone Mar 26, 2023

jlaur mentioned this pull request Mar 27, 2023

[mqtt] Support Ruuvitags via Ruuvi Gateway #13315

Merged

8 tasks

jlaur mentioned this pull request Mar 28, 2023

[mqtt.homeassistant] Disable tests to fix build #14716

Closed

ccutrer deleted the mqtt-hass-json-schema-lights branch March 28, 2023 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mqtt.homeassistant] Implement JSON schema lights #13808

[mqtt.homeassistant] Implement JSON schema lights #13808

ccutrer commented Nov 29, 2022

antroids left a comment

ccutrer commented Dec 21, 2022

ccutrer commented Jan 29, 2023

ccutrer commented Jan 29, 2023

antroids left a comment

openhab-bot commented Feb 25, 2023

lolodomo left a comment

jlaur commented Mar 27, 2023

ccutrer commented Mar 27, 2023

jlaur commented Mar 28, 2023

ccutrer commented Mar 28, 2023

[mqtt.homeassistant] Implement JSON schema lights #13808

[mqtt.homeassistant] Implement JSON schema lights #13808

Conversation

ccutrer commented Nov 29, 2022

antroids left a comment

Choose a reason for hiding this comment

ccutrer commented Dec 21, 2022

ccutrer commented Jan 29, 2023

ccutrer commented Jan 29, 2023

antroids left a comment

Choose a reason for hiding this comment

openhab-bot commented Feb 25, 2023

lolodomo left a comment

Choose a reason for hiding this comment

jlaur commented Mar 27, 2023

ccutrer commented Mar 27, 2023

jlaur commented Mar 28, 2023

ccutrer commented Mar 28, 2023