Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Improve shutterRun calibration #14357

Merged
merged 4 commits into from
May 7, 2023

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Feb 6, 2023

Impreved shutterRun parameter automatic calibration by subtracting some fiexd (500ms) and relative (2%) timing to the measured shutter run time. Updated README section to explain better shutterRun calibration.
This should fix #14215.

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 8, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openwebnet-bticino-legrand-binding-beta/129775/1

@mvalla mvalla requested a review from lolodomo February 12, 2023 18:12
@mvalla
Copy link
Contributor Author

mvalla commented Mar 11, 2023

@lolodomo can you check also this one? thanks!

@wborn wborn changed the title [openwebnet] improved shutterRun calibration [openwebnet] Improve shutterRun calibration Mar 17, 2023
@mvalla
Copy link
Contributor Author

mvalla commented Mar 27, 2023

@lolodomo can you check also this one, left behind? thanks!

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only few comments from changes in README

bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla requested a review from lolodomo May 7, 2023 14:59
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 5fe6d32 into openhab:main May 7, 2023
@lolodomo lolodomo added this to the 4.0 milestone May 7, 2023
@mvalla mvalla deleted the openwebnet-shutterRun branch May 7, 2023 17:44
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
* [openwebnet] improved shutterRun calibration and README
* [openwebnet] added Thing status detail when bridge is offline

--------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
* [openwebnet] improved shutterRun calibration and README
* [openwebnet] added Thing status detail when bridge is offline

--------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [openwebnet] improved shutterRun calibration and README
* [openwebnet] added Thing status detail when bridge is offline

--------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openwebnet] Shutter state going from 0 to UNDEF after auto-stop from actuator
3 participants