-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwebnet] Improve shutterRun calibration #14357
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openwebnet-bticino-legrand-binding-beta/129775/1 |
@lolodomo can you check also this one? thanks! |
@lolodomo can you check also this one, left behind? thanks! |
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
6ac0bef
to
189d8aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only few comments from changes in README
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
* [openwebnet] improved shutterRun calibration and README * [openwebnet] added Thing status detail when bridge is offline -------- Signed-off-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
* [openwebnet] improved shutterRun calibration and README * [openwebnet] added Thing status detail when bridge is offline -------- Signed-off-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Matt Myers <mmyers75@icloud.com>
* [openwebnet] improved shutterRun calibration and README * [openwebnet] added Thing status detail when bridge is offline -------- Signed-off-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Impreved shutterRun parameter automatic calibration by subtracting some fiexd (500ms) and relative (2%) timing to the measured shutter run time. Updated README section to explain better shutterRun calibration.
This should fix #14215.