[evcc] Adjust to evcc version 0.123.1

[lucaarn]

After the update to evcc version 0.123.0 the structure of the api changed:

• url for limit energy and soc changed
• minimum soc and a plan are not longer part of the loadpoint
  -> Instead of that there is a new endpoint for the vehicles, where you can setup a plan with a plan limit soc and a plan time as well as a vehicle specific minimum soc

In order to fit the new api I fixed some issues and implemented a vehicle object. It is possible that the api focusses with coming version even more on vehicles than the loadpoints.

Fixes #16098

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
660 York Street, Suite 102,
San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

org.openhab.binding.evcc-4.2.0-SNAPSHOT.zip

[florian-h05]

Thank you for your PR, and thanks for updating the binding.

I’ve stopped keeping up with evcc‘s API change because I unfortunately I never started using evcc in production - blame the manufacturer of my wallbox because the announced Web API was never released.

Code looks good in general, please have a look at my comments.

[florian-h05]

Thanks for addressing my review!

I have a few (final) comments:

[florian-h05]

We are getting close to the finish line!
At least from my review perspective, the add-on maintainers also have to take a look at this.

[florian-h05]

LGTM, thanks and congratulations to your first contribution!

IMHO this is ready to get merged.
@jlaur Can you please have a look or are you busy?

@lucaarn FYI I have just pushed a small commit to re-arrange the thing-types.xml regarding the comment I requested.

[MikeTheTux]

There are 2 findings open. After addressing those, we should be ready to go from my perspective.
I would like to get this one done in order to move forward with #15744 as well as #15644.

[MikeTheTux]

@lucaarn, I proposed a check-in in order to fix the loadpoint-vehicleName channel:

The API parameter is called vehicleName, not vehicleTitle:

vehicleName is the former "vehicle-id", vehicleTitle is "<vehicleName>.vehicleTitle"

With this change we loose again the shared channel type between loadpoint and vehicle, but I guess this make sense in order to highlight the differences between the two channels and to align with the official API.

[MikeTheTux]

In order to automatize the upgrade efforts, upgrade instructions shall be implemented:
https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types

They will also make the removeChannel calls redundant:

removeChannel(CHANNEL_LOADPOINT_HAS_VEHICLE, channelGroup);
removeChannel("minSoC", channelGroup);
removeChannel("targetEnergy", channelGroup);
removeChannel("targetSoC", channelGroup);
removeChannel("targetTime", channelGroup);
removeChannel("targetTimeEnabled", channelGroup);

[florian-h05]

For Things with statically defined channels in the thing-type.xml upgrade instructions should be provided, but the evcc binding dynamically creates the channels from the code, so no upgrade instructions are needed and they also wouldn’t work I think.

[florian-h05]

Thanks, just a few minor comments:

[florian-h05]

@MikeTheTux Can you please regenerate the default translations?
mvn i18n:generate-default-translations -pl :org.openhab.binding.evcc

[MikeTheTux]

@MikeTheTux Can you please regenerate the default translations? mvn i18n:generate-default-translations -pl :org.openhab.binding.evcc

done

[MikeTheTux]

For Things with statically defined channels in the thing-type.xml upgrade instructions should be provided, but the evcc binding dynamically creates the channels from the code, so no upgrade instructions are needed and they also wouldn’t work I think.

agree. the current implementation removing outdated channels is the way to go

[MikeTheTux]

I think I'm done from my end.
Who could do a final review and merge?

[florian-h05]

I can do a review, but since I am only the evcc binding maintainer and no add-ons maintainer I cannot merge.
After my review, I will ping the add-on maintainers, they can then either do their own review or trust my review.

[florian-h05]

Overall LGTM, just some minor findings:

[MikeTheTux]

In the meanwhile I implemented #15744 on-top of this branch.
The impact on the channel handling is quite big.

Shall I ...

1. commit my changes into this PR?
   1.1. Pro: single manual migration efforts for the users
   1.2. Con: potential merge of this PR gets even further delayed
2. create a parallel PR?
3. wait until this PR is merged and then create a new PR?

[florian-h05]

LGTM, thanks!

@openhab/add-ons-maintainers Can you please review and merge this PR? I already did a full review as the evcc add-on maintainer.

[florian-h05]

Please go for 3.

What really speaks against 1 is IMO that this PR is not really your PR, and it is already pretty big and want to avoid it growing bigger.

[lsiepel]

Besides this i18n comment, also note that some channels are removed and it depends on an external software upgrade. That makes this PR a breaking change. Please create a warning message at the openHAB distro repo to warn users when upgrading.