Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[evcc] Adjust to evcc version 0.123.1 #16114

Merged
merged 24 commits into from
Feb 5, 2024
Merged

[evcc] Adjust to evcc version 0.123.1 #16114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d68f47b
updated url of setTargetEnergy and setTargetSoC to match evcc version…
lucaarn Dec 25, 2023
151cec0
removed minSoc from Loadpoint (since evcc 0.123.0 part of vehicle)
lucaarn Dec 25, 2023
07696f2
renamed from targetEnergy to limitEnergy to match new evcc version
lucaarn Dec 25, 2023
7d4f5a0
renamed from targetSoC to limitSoC to match new evcc version
lucaarn Dec 25, 2023
bf332a4
implementation of vehicle object to match new evcc version 0.123.1 ->…
lucaarn Dec 25, 2023
bf39488
updated readme
lucaarn Dec 25, 2023
99855b5
fixed typo and resolved comments
lucaarn Dec 27, 2023
df71b37
resolved suggested fixes
lucaarn Dec 28, 2023
c387a5e
remove of channels used in previous version
lucaarn Dec 28, 2023
6f7c58b
thing-types cleanup, removed redundant code
lucaarn Dec 28, 2023
8162830
Reorder comments in thing-types.xml
florian-h05 Dec 28, 2023
5635393
fix loadpoint vehicleName channel
MikeTheTux Jan 31, 2024
199f5df
2023 -> 2024
MikeTheTux Jan 31, 2024
a985c8b
kWH -> kWh
MikeTheTux Jan 31, 2024
9c5c609
added batteryDischargeControl and batteryMode
MikeTheTux Feb 1, 2024
777e974
added bufferSoC bufferStartSoC residualPower channels
MikeTheTux Feb 1, 2024
ad6f7f7
review finding
MikeTheTux Feb 1, 2024
ee24819
review finding
MikeTheTux Feb 1, 2024
fcd2ccc
added new channels to README.md
MikeTheTux Feb 1, 2024
8d403c8
review findings
MikeTheTux Feb 2, 2024
d0401c5
improved some categories
MikeTheTux Feb 2, 2024
c9da7d6
implemented review findings
MikeTheTux Feb 2, 2024
2a0ac93
removed unused parameter
MikeTheTux Feb 3, 2024
ba2da7e
reverted changes in evcc_de.properties
MikeTheTux Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.evcc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Thing evcc:device:demo "evcc Demo" [url="https://demo.evcc.io", refreshInterval=

```java
// General
Number:Energy evcc_batteryCapacity "Battery Capacity [%.0f kWH]" <energy> {channel="evcc:device:demo:general#batteryCapacity"}
Number:Energy evcc_batteryCapacity "Battery Capacity [%.0f kWh]" <energy> {channel="evcc:device:demo:general#batteryCapacity"}
Number:Power evcc_batteryPower "Battery Power [%.1f kW]" <energy> {channel="evcc:device:demo:general#batteryPower"}
Number:Dimensionless evcc_batterySoC "Battery SoC [%d %%]" <batterylevel> {channel="evcc:device:demo:general#batterySoC"}
Number:Dimensionless evcc_batteryPrioritySoC "Battery Priority SoC [%d %%]" <batterylevel> {channel="evcc:device:demo:general#batteryPrioritySoC"}
Expand Down
2 changes: 1 addition & 1 deletion ...ab.binding.evcc/src/main/java/org/openhab/binding/evcc/internal/EvccBindingConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class EvccBindingConstants {
public static final String CHANNEL_LOADPOINT_VEHICLE_PRESENT = "vehiclePresent";
public static final String CHANNEL_LOADPOINT_VEHICLE_RANGE = "vehicleRange";
public static final String CHANNEL_LOADPOINT_VEHICLE_SOC = "vehicleSoC";
public static final String CHANNEL_LOADPOINT_VEHICLE_TITLE = "loadpointVehicleTitle";
public static final String CHANNEL_LOADPOINT_VEHICLE_TITLE = "vehicleTitle";
public static final String CHANNEL_VEHICLE_TITLE = "vehicleTitle";
public static final String CHANNEL_VEHICLE_MIN_SOC = "vehicleMinSoC";
public static final String CHANNEL_VEHICLE_LIMIT_SOC = "vehicleLimitSoC";
Expand Down
2 changes: 1 addition & 1 deletion ...org.openhab.binding.evcc/src/main/java/org/openhab/binding/evcc/internal/EvccHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ private void createChannelsLoadpoint(int loadpointId) {
}

private void createChannelsVehicle(String vehicleName) {
final String channelGroup = "vehicle" + vehicleName;
final String channelGroup = CHANNEL_GROUP_ID_VEHICLE + vehicleName;
createChannel(CHANNEL_VEHICLE_TITLE, channelGroup, CHANNEL_TYPE_UID_VEHICLE_TITLE, CoreItemFactory.STRING);
createChannel(CHANNEL_VEHICLE_MIN_SOC, channelGroup, CHANNEL_TYPE_UID_VEHICLE_MIN_SOC, "Number:Dimensionless");
createChannel(CHANNEL_VEHICLE_LIMIT_SOC, channelGroup, CHANNEL_TYPE_UID_VEHICLE_LIMIT_SOC,
Expand Down
2 changes: 0 additions & 2 deletions bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/i18n/evcc.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ channel-type.evcc.vehicleRange.label = Vehicle Range
channel-type.evcc.vehicleRange.description = Battery range for EV
channel-type.evcc.vehicleSoC.label = Vehicle SoC
channel-type.evcc.vehicleSoC.description = Current State of Charge of EV
channel-type.evcc.loadpointVehicleTitle.label = Vehicle Title
channel-type.evcc.loadpointVehicleTitle.description = Name of EV connected to Loadpoint
channel-type.evcc.vehicleTitle.label = Vehicle Title
channel-type.evcc.vehicleTitle.description = Name of EV
channel-type.evcc.vehicleMinSoC.label = Vehicle Charging min SoC
Expand Down
2 changes: 0 additions & 2 deletions bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/i18n/evcc_de.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ channel-type.evcc.vehicleRange.label = Fahrzeug Reichweite
channel-type.evcc.vehicleRange.description = Fahrzeug-Batterie Reichweite
channel-type.evcc.vehicleSoC.label = Fahrzeug Ladestand
channel-type.evcc.vehicleSoC.description = Aktueller Ladestand der Fahrzeug-Batterie
channel-type.evcc.loadpointVehicleTitle.label = Fahrzeug Name
channel-type.evcc.loadpointVehicleTitle.description = Name des Fahrzeugs (verbunden mit Ladepunkt)
channel-type.evcc.vehicleTitle.label = Fahrzeug Name
channel-type.evcc.vehicleTitle.description = Name des Fahrzeugs
channel-type.evcc.vehicleMinSoC.label = Minimaler Ladestand Fahrzeug
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.evcc/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
florian-h05 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@
<category>BatteryLevel</category>
<state pattern="%.0f %unit%" readOnly="true"/>
</channel-type>
<channel-type id="loadpointVehicleTitle">
<channel-type id="vehicleTitle">
florian-h05 marked this conversation as resolved.
Show resolved Hide resolved
<item-type>String</item-type>
<label>Vehicle Title</label>
<description>Name of EV</description>
MikeTheTux marked this conversation as resolved.
Show resolved Hide resolved
Expand Down