Remove openhab-transport-http feature dependencies #16202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <github@maindrain.net>
|
I just noticed openhab-transport-mdns was also added to openhab-runtime-base in OH 2 (openhab/openhab-core#81) so those feature dependencies could also be removed. WDYT? It probably got added because the MDNSAnnouncer is also used so OH can be discovered. See: /features/karaf/openhab-core/src/main/feature/feature.xml There may already be many add-ons that depend on these features without having these feature deps in their feature.xml file. |
J-N-K
approved these changes
Jan 4, 2024
|
Yes, the mdns feature should also be removed. |
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Jan 4, 2024
The following features are already dependencies of openhab-runtime-base: * openhab-core-base * openhab-core-model-item * openhab-core-model-script * openhab-transport-mdns See also: openhab#16202 (comment) Signed-off-by: Wouter Born <github@maindrain.net>
Cybso
pushed a commit
to Cybso/openhab-addons
that referenced
this pull request
Jan 5, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Remove redundant feature dependencies The following features are already dependencies of openhab-runtime-base: * openhab-core-base * openhab-core-model-item * openhab-core-model-script * openhab-transport-mdns See also: #16202 (comment) * Remove redundant openhab.tp-jackson and openhab.tp-jaxb feature dependencies Signed-off-by: Wouter Born <github@maindrain.net>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies. See: * openhab/openhab-core#344 * openhab#16181 (comment) Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Remove redundant feature dependencies The following features are already dependencies of openhab-runtime-base: * openhab-core-base * openhab-core-model-item * openhab-core-model-script * openhab-transport-mdns See also: openhab#16202 (comment) * Remove redundant openhab.tp-jackson and openhab.tp-jaxb feature dependencies Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openhab-transport-http feature dependency is redundant since OH 2.3 when it was added to the openhab-runtime-base feature dependencies.
See: