Remove redundant feature dependencies #16204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following features are already dependencies of openhab-runtime-base: * openhab-core-base * openhab-core-model-item * openhab-core-model-script * openhab-transport-mdns See also: openhab#16202 (comment) Signed-off-by: Wouter Born <github@maindrain.net>
wborn
requested review from
pravussum,
andylintner,
ccutrer,
yfre,
grro,
mlobstein,
cweitkamp,
kaikreuzer,
markus7017,
peuter,
stefan-hoehn,
ibaton,
marcelrv,
Markinus,
tavalin,
andrewfg,
Cossey,
clinique,
lolodomo,
MikeJMajor,
jwveldhuis,
marvkis,
tratho,
morph166955 and
GiviMAD
as code owners
J-N-K
reviewed
Jan 4, 2024
bundles/org.openhab.binding.denonmarantz/src/main/feature/feature.xml
Outdated
Show resolved
Hide resolved
GiviMAD
reviewed
Jan 4, 2024
GiviMAD
approved these changes
Jan 4, 2024
mlobstein
approved these changes
Jan 4, 2024
…dencies Signed-off-by: Wouter Born <github@maindrain.net>
wborn
requested review from
jochen314,
Skinah,
daMihe and
FlorianSW
as code owners
|
Was the mdns added recently? I had issues when first building androidtv because I hadn't included it. |
See #16202 (comment) |
stefan-hoehn
approved these changes
Jan 5, 2024
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Remove redundant feature dependencies The following features are already dependencies of openhab-runtime-base: * openhab-core-base * openhab-core-model-item * openhab-core-model-script * openhab-transport-mdns See also: openhab#16202 (comment) * Remove redundant openhab.tp-jackson and openhab.tp-jaxb feature dependencies Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following features are already dependencies of openhab-runtime-base:
See also: #16202 (comment)