Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yamahareceiver] Fix ChannelTypeProvider #16278

Merged
merged 2 commits into from
Jan 14, 2024
Merged

[yamahareceiver] Fix ChannelTypeProvider #16278

merged 2 commits into from
Jan 14, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 14, 2024

Related to #16107

@J-N-K
[yamahareceiver] Fix ChannelTypeProvider
dabe4d2 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jan 14, 2024
J-N-K referenced this pull request Jan 14, 2024
@J-N-K
Adapt to core changes (ThingHandlerService) (#16107)
3136425 
Related to: openhab/openhab-core#3957

Signed-off-by: Jan N. Klug <github@klug.nrw>
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Jan 14, 2024
@florian-h05
Copy link
Contributor

Thanks @J-N-K, unfortunately, that does not fully fix it, now the problem occurs with the other provider.
I created a PR to your repo to fix that one as well: J-N-K#23.

@florian-h05
[yamaha] Fix remaining ChannelTypeProvider (#23)
6988f87 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@J-N-K J-N-K marked this pull request as ready for review January 14, 2024 17:12
@J-N-K J-N-K requested a review from zarusz as a code owner January 14, 2024 17:12
florian-h05
florian-h05 approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jlaur
jlaur approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 1c67114 into openhab:main Jan 14, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Jan 14, 2024
@J-N-K J-N-K deleted the yamaha branch January 14, 2024 21:00
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
@J-N-K @andrasU
[yamahareceiver] Fix ChannelTypeProvider (openhab#16278)
1ecf6a0 
* [yamahareceiver] Fix ChannelTypeProvider
* [yamaha] Fix remaining ChannelTypeProvider (openhab#23)

Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@J-N-K @austvik
[yamahareceiver] Fix ChannelTypeProvider (openhab#16278)
e8d308e 
* [yamahareceiver] Fix ChannelTypeProvider
* [yamaha] Fix remaining ChannelTypeProvider (openhab#23)

Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@florian-h05 florian-h05 florian-h05 approved these changes

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@J-N-K @florian-h05 @jlaur