Refactor ThingHandlerService to an OSGi component prototype #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-N-K
changed the title
|
Thanks for picking it up! It looks good to me so far. 👍 |
Signed-off-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Signed-off-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
thinghandlerservice-osgi
branch
from
8812da3
to
7a3dd91
Compare
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
@wborn @kaikreuzer I would like to see this merged "soon", because the corresponding PR in openhab-addons will create a lot of merge conflicts each time something is changed in a discovery service. I'll now create a PR for the documentation how to do thing discovery right. |
kaikreuzer
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Thanks for picking this up! Lgtm as far as I can tell.
I leave it to @wborn to have another look and merge it, if he is happy with it.
wborn
requested changes
Jan 2, 2024
...ry/src/main/java/org/openhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/org/openhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/org/openhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/org/openhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/org/openhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/org/openhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...openhab.core.thing/src/main/java/org/openhab/core/thing/binding/BaseThingHandlerFactory.java
Outdated
Show resolved
Hide resolved
...openhab.core.thing/src/main/java/org/openhab/core/thing/binding/BaseThingHandlerFactory.java
Outdated
Show resolved
Hide resolved
...openhab.core.thing/src/main/java/org/openhab/core/thing/binding/BaseThingHandlerFactory.java
Outdated
Show resolved
Hide resolved
...openhab.core.thing/src/main/java/org/openhab/core/thing/binding/BaseThingHandlerFactory.java
Outdated
Show resolved
Hide resolved
…enhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
…enhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
…enhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
…enhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
…enhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
…enhab/core/config/discovery/AbstractThingHandlerDiscoveryService.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
…thing/binding/BaseThingHandlerFactory.java Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Done |
wborn
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Jan 3, 2024
Related to: openhab/openhab-core#3957 Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Thank you @J-N-K , I will adjust the openweathermap binding to take benefit of this new feature. Just one question: what will happen for non official bindings already using ThingHandlerService, will they be broken ? |
|
They need to be adjusted accordingly. |
So something to clearly announce when releasing version 4.2... |
Cybso
pushed a commit
to Cybso/openhab-addons
that referenced
this pull request
Jan 5, 2024
Related to: openhab/openhab-core#3957 Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Jan 5, 2024
Caused by openhab#3957 Signed-off-by: Wouter Born <github@maindrain.net>
Merged
J-N-K
pushed a commit
that referenced
this pull request
Jan 5, 2024
Caused by #3957 Signed-off-by: Wouter Born <github@maindrain.net>
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
…3957) Also-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com> Signed-off-by: J-N-K <github@klug.nrw> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
Caused by openhab#3957 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Related to: openhab/openhab-core#3957 Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1941
Since Connor is no longer available I decided to pick up the PR and enhance it. A very good example why we should go this way is openhab/openhab-addons#16037. It implements a
TheKeyTranslationProvider.javajust to pass it from the handler factory to the thing handler and then to theThinghandlerServicefor localization of the discovery results. There is already similar code in the repository. This is only necessary because we can't inject OSGi services directly to the discovery services.I started with two implementations in openhab-addons (openhab/openhab-addons#16107) and would like to hear comments from @openhab/core-maintainers before I start a bigger refactoring in openhab-addons.