[radiobrowser] Initial contribution #16392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skinah
added
new binding
Skinah
changed the title
lsiepel
requested changes
Feb 12, 2024
...adiobrowser/src/main/java/org/openhab/binding/radiobrowser/internal/RadioBrowserHandler.java
Show resolved
Hide resolved
...adiobrowser/src/main/java/org/openhab/binding/radiobrowser/internal/RadioBrowserHandler.java
Outdated
Show resolved
Hide resolved
...adiobrowser/src/main/java/org/openhab/binding/radiobrowser/internal/RadioBrowserHandler.java
Outdated
Show resolved
Hide resolved
...adiobrowser/src/main/java/org/openhab/binding/radiobrowser/internal/api/RadioBrowserApi.java
Outdated
Show resolved
Hide resolved
...adiobrowser/src/main/java/org/openhab/binding/radiobrowser/internal/api/RadioBrowserApi.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
…nhab/binding/radiobrowser/internal/RadioBrowserBindingConstants.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
…nhab/binding/radiobrowser/internal/RadioBrowserBindingConstants.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
…nhab/binding/radiobrowser/internal/api/RadioBrowserApi.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
…nhab/binding/radiobrowser/internal/RadioBrowserHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
…nhab/binding/radiobrowser/internal/RadioBrowserHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
…-INF/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
@lsiepel Thank you for the review, I have address all comments now. |
lsiepel
reviewed
Feb 17, 2024
...adiobrowser/src/main/java/org/openhab/binding/radiobrowser/internal/api/RadioBrowserApi.java
Show resolved
Hide resolved
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
lsiepel
approved these changes
Feb 19, 2024
|
I cannot find any more bugs, and a small number of users have reported it works on forum, so let's merge. |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* initial code Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new binding to navigate and find internet radio broadcasts.
This functionality has been built in to Home Assistant for > 2 years, so it scores high on how many systems use it, as it's installed by default and they need to opt out. 71.6% of their systems at this point in time due to this.
So I feel its time we have the ability for users to come across and have similar ability, done in a different and hopefully better way that has actually helpful documentation.
I feel this is far more flexible than HA's current implementation, which is funny as it is now 2 years on and basic stuff did not get added that users are asking for.
In this binding you can apply multiple filters at a time and can automate the filter changes as they are channels. You can filter to USA + Texas + Spanish + Polka Music to probably get no results with that combo, but its flexible to turn the > 45,000 radio stations down to a short list to try streaming by applying multiple filters.
I added a widget to make using it easier, as a URL text string is not useful for anyone.
https://community.openhab.org/t/radio-browser-basic-widget-for-finding-internet-radio-streams-with-the-ui/153783