Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radiobrowser] Initial contribution #16392

Merged
merged 47 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
2f04cf1
initial code
Skinah Feb 6, 2024
085bd4e
working
Skinah Feb 7, 2024
4360614
improvements
Skinah Feb 8, 2024
36474ac
Add genres
Skinah Feb 10, 2024
e429766
Add more genres
Skinah Feb 10, 2024
50a1972
improvements
Skinah Feb 10, 2024
4523a37
basic readme
Skinah Feb 10, 2024
e468c51
remove NPE warns and update readme.
Skinah Feb 11, 2024
052e229
cleanup for merge
Skinah Feb 11, 2024
a88cd0d
spotless fix
Skinah Feb 11, 2024
90efcb1
bug fixes
Skinah Feb 11, 2024
132ae9d
Station searches added to the readme
Skinah Feb 11, 2024
d744d87
minor changes
Skinah Feb 12, 2024
ab25817
remove commented out code
Skinah Feb 12, 2024
8bc57ee
Order by votes
Skinah Feb 12, 2024
736b2a9
review changes 1
Skinah Feb 13, 2024
d54f4bc
Update bundles/org.openhab.binding.radiobrowser/README.md
Skinah Feb 13, 2024
debc44b
Update bundles/org.openhab.binding.radiobrowser/README.md
Skinah Feb 13, 2024
fc4087f
Update bundles/org.openhab.binding.radiobrowser/README.md
Skinah Feb 13, 2024
ff45025
Update bundles/org.openhab.binding.radiobrowser/src/main/java/org/ope…
Skinah Feb 13, 2024
877d176
Update bundles/org.openhab.binding.radiobrowser/src/main/java/org/ope…
Skinah Feb 13, 2024
2d3dad7
changes 2
Skinah Feb 13, 2024
e12668b
Merge branch 'radio' of https://github.com/Skinah/openhab-addons into…
Skinah Feb 13, 2024
05d38a9
Update bundles/org.openhab.binding.radiobrowser/src/main/resources/OH…
Skinah Feb 13, 2024
79b2174
fix pom
Skinah Feb 13, 2024
9533c8c
Merge branch 'radio' of https://github.com/Skinah/openhab-addons into…
Skinah Feb 13, 2024
d36bbb3
Update bundles/org.openhab.binding.radiobrowser/src/main/java/org/ope…
Skinah Feb 13, 2024
7e03ac1
Update bundles/org.openhab.binding.radiobrowser/src/main/java/org/ope…
Skinah Feb 13, 2024
e4836f0
review changes 3
Skinah Feb 13, 2024
d05a2f1
Update bundles/org.openhab.binding.radiobrowser/src/main/java/org/ope…
Skinah Feb 13, 2024
7a145d3
more changes
Skinah Feb 13, 2024
b6d86f1
remove unused channels
Skinah Feb 13, 2024
5a6f56e
spotless
Skinah Feb 13, 2024
391e53d
use http
Skinah Feb 13, 2024
dbfc8b9
Merge branch 'radio' of https://github.com/Skinah/openhab-addons into…
Skinah Feb 13, 2024
a95c8ed
bug fix
Skinah Feb 13, 2024
4d10856
Update bundles/org.openhab.binding.radiobrowser/README.md
Skinah Feb 13, 2024
70f6ff6
Add recent and HTTPS
Skinah Feb 14, 2024
66fbacb
Merge branch 'radio' of https://github.com/Skinah/openhab-addons into…
Skinah Feb 14, 2024
5325554
update readme
Skinah Feb 14, 2024
ec74193
Update bundles/org.openhab.binding.radiobrowser/src/main/resources/OH…
Skinah Feb 15, 2024
42966a8
bug fixes for forum reported bugs.
Skinah Feb 17, 2024
7760c3c
Merge branch 'radio' of https://github.com/Skinah/openhab-addons into…
Skinah Feb 17, 2024
d3badcc
Add more genres
Skinah Feb 17, 2024
77935f9
update readme
Skinah Feb 17, 2024
fd738cc
Remove multiple stations to give cleaner list.
Skinah Feb 17, 2024
1d363f3
Update station ch when recent station is selected.
Skinah Feb 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ public void updateStations() throws ApiException {

private @Nullable Station searchStationName(String name) throws ApiException {
try {
String returnContent = sendGetRequest("/json/stations/byname/" + name);
String returnContent = sendGetRequest(
"/json/stations/byname/" + URLEncoder.encode(name, "UTF-8").replace("+", "%20"));
lsiepel marked this conversation as resolved.
Show resolved Hide resolved
Station[] stations = gson.fromJson(returnContent, Station[].class);
if (stations == null || stations.length == 0) {
return null;
Expand All @@ -258,6 +259,8 @@ public void updateStations() throws ApiException {
throw new ApiException("Server did not reply with a valid json");
} catch (IllegalArgumentException e) {
logger.warn("IllegalArgumentException:{}", e.getMessage());
} catch (UnsupportedEncodingException e) {
logger.warn("UnsupportedEncodingException:{}", e.getMessage());
}
return null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
<option value="oldies">oldies</option>
<option value="pop">pop</option>
<option value="punk">punk</option>
<option value="reggae ">reggae</option>
<option value="reggae">reggae</option>
<option value="rock">rock</option>
<option value="soul">soul</option>
<option value="sports">sports</option>
Expand Down