Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[intesis] Session Handling improved #16549

Closed
wants to merge 0 commits into from
Closed

[intesis] Session Handling improved #16549

wants to merge 0 commits into from

Conversation

fd0cwp
Copy link
Contributor

@fd0cwp fd0cwp commented Mar 19, 2024

I have changed the login process so that the binding now only logs in at the beginning and logs out at the end of the lifetime. If a request fails due to a missing login or an invalid session ID, a new login attempt is made.

This ensures that

  • Several requests can be sent in direct succession (if I switch the air conditioning from cooling to heating, I also want to change the slats at the same time)
  • Less traffic is generated as there is not a constant logout and login again
  • Ideally, the login credentials should only be visible once at startup

Last change: login and logout is now running asynchronously in a scheduled task (#16476).

Signed-off-by: Christoph fd0cwp@gmx.de

@jlaur
Copy link
Contributor

jlaur commented Mar 19, 2024

@fd0cwp - there are no changes, perhaps a merge and/or rebase went wrong?

@fd0cwp fd0cwp requested a review from hmerk as a code owner March 19, 2024 20:10
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Mar 19, 2024
jlaur
jlaur reviewed Mar 19, 2024
View reviewed changes
...g.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisHomeHandler.java Outdated
// start background initialization:
scheduler.submit(() -> {
logger.trace("trying to log in - current session ID: {}", sessionId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this PR, but rather the previous one as well: When the binding is started for the first time, there will be no session id, since this is obtained when logging in for the first time, correct? I'm wondering if you should clear the session id in logout, since that should invalidate it? And - in that case - there would be no reason to log it here in initialize.

@fd0cwp
Copy link
Contributor Author

fd0cwp commented Mar 19, 2024

I do not understand this GIT handling. 😔

@fd0cwp
Copy link
Contributor Author

fd0cwp commented Mar 19, 2024

@jlaur: Can you please help me with this DCO issue? I do not know how to fix it.

@jlaur
Copy link
Contributor

jlaur commented Mar 19, 2024 •
edited

Can you please help me with this DCO issue? I do not know how to fix it.

Sure. If you click "Details" right next to the DCO line, you will be taken to page with instructions how to rebase your PR and fix the missing sign-off. I just checked, and these instructions seem pretty accurate so I don't have anything to add. Let me know if you encounter any issues.

@fd0cwp fd0cwp closed this Mar 20, 2024
@fd0cwp fd0cwp mentioned this pull request Mar 20, 2024
Closed
@fd0cwp
Copy link
Contributor Author

fd0cwp commented Mar 20, 2024

Sorry, I don*t get this GIT handling.
I tried it the way how it is described in the DCO docu but it didn't work, I only now saw that I closed this PR. I do not know how I did this unintentionally.
However, as many changes were shown by other people, I started from "scratch" and submitted a new PR (#16551).

@jlaur jlaur mentioned this pull request Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@hmerk hmerk Awaiting requested review from hmerk

@cweitkamp cweitkamp Awaiting requested review from cweitkamp

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer

@mherwege mherwege Awaiting requested review from mherwege

@marcelrv marcelrv Awaiting requested review from marcelrv

@ssalonen ssalonen Awaiting requested review from ssalonen

@antroids antroids Awaiting requested review from antroids

@BjoernLange BjoernLange Awaiting requested review from BjoernLange

@gerrieg gerrieg Awaiting requested review from gerrieg

@wborn wborn Awaiting requested review from wborn

@GiviMAD GiviMAD Awaiting requested review from GiviMAD

@mlobstein mlobstein Awaiting requested review from mlobstein

@kgoderis kgoderis Awaiting requested review from kgoderis

@lolodomo lolodomo Awaiting requested review from lolodomo

@octa22 octa22 Awaiting requested review from octa22

@mvalla mvalla Awaiting requested review from mvalla

@clinique clinique Awaiting requested review from clinique

@andrewfg andrewfg Awaiting requested review from andrewfg

@holgerfriedrich holgerfriedrich Awaiting requested review from holgerfriedrich

@stefan-hoehn stefan-hoehn Awaiting requested review from stefan-hoehn

@trokohl trokohl Awaiting requested review from trokohl

@Andy2003 Andy2003 Awaiting requested review from Andy2003

@florian-h05 florian-h05 Awaiting requested review from florian-h05

@maniac103 maniac103 Awaiting requested review from maniac103

@sibbi77 sibbi77 Awaiting requested review from sibbi77

@mhilbush mhilbush Awaiting requested review from mhilbush

@Hilbrand Hilbrand Awaiting requested review from Hilbrand

@HolgerHees HolgerHees Awaiting requested review from HolgerHees

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fd0cwp @jlaur