Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intesis] Session Handling improved #16551

Closed
wants to merge 1 commit into from
Closed

[intesis] Session Handling improved #16551

wants to merge 1 commit into from

Conversation

fd0cwp
Copy link
Contributor

@fd0cwp fd0cwp commented Mar 20, 2024

I have changed the login process so that the binding now only logs in at the beginning and logs out at the end of the lifetime. If a request fails due to a missing login or an invalid session ID, a new login attempt is made.

This ensures that

  • Several requests can be sent in direct succession (if I switch the air conditioning from cooling to heating, I also want to change the slats at the same time)
  • Less traffic is generated as there is not a constant logout and login again
  • Ideally, the login credentials should only be visible once at startup

Last change: login and logout is now running asynchronously in a scheduled task (#16476).

As I was not able to fix PR #16549, I try to fix it by starting from scratch.

Signed-off-by: Christoph fd0cwp@gmx.de

I have changed the login process so that the binding now only logs in at the beginning and logs out at the end of the lifetime. If a request fails due to a missing login or an invalid session ID, a new login attempt is made.

This ensures that
- Several requests can be sent in direct succession (if I switch the air conditioning from cooling to heating, I also want to change the slats at the same time)
- Less traffic is generated as there is not a constant logout and login again
- Ideally, the login credentials should only be visible once at startup

Last change: login and logout is now running asynchronously in a scheduled task (#16476).

Signed-off-by: Christoph <fd0cwp@gmx.de>
@fd0cwp
Copy link
Contributor Author

fd0cwp commented Mar 20, 2024

@jlaur, @lsiepel: fyi

@fd0cwp fd0cwp closed this by deleting the head repository Mar 20, 2024
@fd0cwp
Copy link
Contributor Author

fd0cwp commented Mar 21, 2024

Somebody does not want that I include the changes. 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant