[sunspec] Modbus: SunSpec Binding initial contribution #4220

mrbig · 2018-11-11T22:48:41Z

[modbus] SunSpec bundle - add support for SunSpec compatible inverters and meters

SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc.

The goal of this work is to add user friendly support of these devices to openHAB.

The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle.

Related issue: #3216

In this PR two model types are supported: inverters and meters. The structure allows for easy extension with other model types.

This PR contains two more commits to the Modbus binding: one adds the framework for auto discovery, and the other handles a minor issue where connected items to the Modbus bridge did not get notified about bridge changes.

I'm submitting my work for initial review and to get your feedback. Thank you for reviewing my work.

openhab-bot · 2018-12-30T12:27:30Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/modbus-2-x-tcp-errors-on-startup/61707/4

openhab-bot · 2019-01-05T12:05:55Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/modbus-and-system-air/6212/88

This seems to be necessary to get the children notified about the change Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

Created discovery service based on the implementation in the bluetooth bundle Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

SunSpec is a Modbus based specification for solar inverters, electricity maters, batteries and other connected appliance. This protocol allows monitoring of these devices and retrieving live data. This new binding extends the Modbus binding with the SunSpec specific things. Currently two new type of things are added: inverters (single, split, three-phase) and meters (single, split, wye/delta connected) Items are automatically discovered at an endpoint. Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

mrbig · 2019-01-26T14:29:07Z

Just a quick update: I've fixed a reported null pointer issue, rebased the PR to the current master and updated the licence texts according the up to date standards

openhab-bot · 2019-03-21T17:16:02Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab1-2-nilan-heatpump/23538/72

davidgraeff · 2019-03-21T17:25:38Z

addons/binding/org.openhab.binding.modbus.sunspec/ESH-INF/config/config-descriptions.xml

+	</config-description>
+
+
+</config-description:config-descriptions>


davidgraeff · 2019-03-21T17:25:45Z

addons/binding/org.openhab.binding.modbus.sunspec/ESH-INF/thing/inverter-channel-groups.xml

+		</channels>
+	</channel-group-type>
+
+</thing:thing-descriptions>


davidgraeff · 2019-03-21T17:26:12Z

addons/binding/org.openhab.binding.modbus.sunspec/ESH-INF/thing/inverter-channel-types.xml

+	</channel-type>
+
+</thing:thing-descriptions>
+


whitespace in last line

davidgraeff · 2019-03-21T17:26:30Z

addons/binding/org.openhab.binding.modbus.sunspec/ESH-INF/thing/meter-channel-groups.xml

+		</channels>
+	</channel-group-type>
+
+</thing:thing-descriptions>


davidgraeff · 2019-03-21T17:27:01Z

addons/binding/org.openhab.binding.modbus.sunspec/ESH-INF/thing/meter-channel-groups.xml

+	xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">
+
+	<channel-group-type id="meter-ac-general">
+		<label>Summary</label>


Why no description? :)

davidgraeff · 2019-03-21T17:32:28Z

...sunspec/src/main/java/org/openhab/binding/modbus/sunspec/internal/SunSpecHandlerFactory.java

+     *
+     * @param manager the modbus manager from org.openhab.io.transport.modbus package
+     */
+    @Reference(service = ModbusManager.class, cardinality = ReferenceCardinality.MANDATORY, policy = ReferencePolicy.STATIC, unbind = "unsetManager")


Please remove unbind (its implicit) and policy. The default is reasonable. Also MANDATORY is default.

davidgraeff · 2019-03-21T17:34:10Z

...unspec/src/main/java/org/openhab/binding/modbus/sunspec/internal/block/CommonModelBlock.java

+ */
+public class CommonModelBlock extends AbstractSunSpecMessageBlock {
+
+    /**


If possible, can you use immutable classes (everything set in the constructor, everything public final, no getters, no setters)? That helps for thread safety but also for reviewing, because less lines of boilerplate code.

davidgraeff · 2019-03-21T17:35:17Z

.../java/org/openhab/binding/modbus/sunspec/internal/discovery/SunspecDiscoveryParticipant.java

+        try {
+            new SunspecDiscoveryProcess(handler, listener).detectModel();
+        } catch (EndpointNotInitializedException ex) {
+            logger.debug("Could not start discovery process");


Raise to "warn". Its an actual error that should be highlighted in the logs don't you think.
And also: Add the exception as last argument. That adds a stacktrace and the exception message to the log.

davidgraeff · 2019-03-21T17:35:36Z

...nspec/src/main/java/org/openhab/binding/modbus/sunspec/internal/handler/InverterHandler.java

+    }
+
+    /**
+     *


davidgraeff · 2019-03-21T17:35:49Z

...nspec/src/main/java/org/openhab/binding/modbus/sunspec/internal/handler/InverterHandler.java

+     */
+    private InverterModelParser parser = new InverterModelParser();
+    /**
+     * Logger instance


commented the obvious

davidgraeff · 2019-03-21T17:39:14Z

A binding of more than 5000 LOC is hard to review. I have noticed that you are doing two things in here as well.

I know this is a bit more work (although not really), but will help to merge things faster. Can you make a separate PR for extending modbus first and then reduce this PR?

I have left some inline comments. You sometimes comment the obvious which increases the code size. And you are using getters/setters although they could be avoided with immutable classes and other means. Please try to reduce the code size if you find more places.

mrbig · 2019-03-24T08:47:14Z

Dear @davidgraeff
Thank you very much for your review.

I understand that reviewing this much of change at once can be hard. I tried to help this work by organizing my work into commits by the goal of the change. So modbus changes are commits f86056 and ed1ac0 and the rest is the new binding. So if you like that better, I can quickly split this into two separate pull requests.

And you are using getters/setters although they could be avoided with immutable classes and other means.

I'm in a bit trouble with this request. SunSpec model block can have 10-50 properties at least. Changing these to immutable classes as you requested would result in classes with a constructor with that many parameters, which is very hard to read and work with. Also that would need the controller plane to do first everything in local variables before instantiating the data object. I hardly believe this would reduce code size.

On the other side if our goal is thread safety and real immutable classes, then we could use chainable setters that return a copy of the object with the selected property altered. That would work something like the BigDecimal. This would make the user side a bit more compact, so instead of this:

        MeterModelBlock block = new MeterModelBlock();

        block.setSunspecDID(...);

        block.setLength(...);

        block.setAcCurrentTotal(...);

        block.setAcCurrentPhaseA(...);

        block.setAcCurrentPhaseB(...);

        block.setAcCurrentPhaseC(...);

        block.setAcCurrentSF(...);

        block.setAcVoltageLinetoNAverage(...);

one could write this:

        MeterModelBlock block = new MeterModelBlock()
            .setSunspecDID(...)
            .setLength(...)
            .setAcCurrentTotal(...)
            .setAcCurrentPhaseA(...)
            .setAcCurrentPhaseB(...)
            .setAcCurrentPhaseC(...)
            .setAcCurrentSF(...)
            .setAcVoltageLinetoNAverage(...)
            [...]

But apart of the removed new lines this does not save code either.

One more design goal was to leave room for implementation divergences. It's very likely that there will be manufacturers that diverge from the standard either by purpose or by mistake.

With the current architecture my goal was to have a clear separation of concerns:
_Parser classes are there to convert raw byte arrays to java types and to handle any implementation errors
_Block classes are there to act as DTO-s, to store the parsed data
_Handler classes are responsible to forward parsed values to the right channel and group of the thing.

The most code could be eliminated by removing the parser/block layer, but this would result in overcrowded handler classes.

Do you have any ideas which way to go from here?

davidgraeff · 2019-03-24T09:11:09Z

I understand that reviewing this much of change at once can be hard. I tried to help this work by organizing my work into commits by the goal of the change. So modbus changes are commits f86056 and ed1ac0 and the rest is the new binding. So if you like that better, I can quickly split this into two separate pull requests.

That would be awesome. The thing is: I can only accept the entire PR or nothing.
And I would rather merge in smaller pieces that I'm sure of.

Do you have any ideas which way to go from here?

If the code is indeed modularized, then multiple PRs are very doable, I guess? Like in:

The modbus library changes
The basics of the new binding
More parsers/block layers

_Block classes are there to act as DTO-s, to store the parsed data

Can you have those in a "model" or "dto" package? That has been established as an accepted pattern

With the current architecture my goal was to have a clear separation of concerns:

The architecture is quite good, it is just the pure size of the PR.

ssalonen · 2019-04-22T11:12:05Z

Note that #5498 will break this PR since ModbusBitUtilities.extractStateFromRegisters will now return State, not DecimalType.

Since this PR uses that method with integer valuetypes, it is safe to cast to DecimalType.

EDIT: API is changing still a bit (not settling on Optional<DecimalType>), refer to PR for more details.

mrbig · 2019-04-23T08:15:34Z

Thank you @ssalonen. I've put this on hold for a while until issue #5005 gets worked out. Then I'll do the necessary refactoring.

ramack · 2019-08-09T20:33:35Z

@mrbig the description of you bundle sounds promising and I am looking forward to try it. Do you already have plans to get this finally merged?

ramack · 2019-10-27T08:56:00Z

#5498 and #5005 are both closed. So is there some progress here? - I'd really love to have that, as today I have a very longish and unsatisfying manual ModBus-config for my Fronius solar inverter and this Binding seems to be perfectly solving this.

mrbig · 2019-10-30T22:46:15Z

Thank you @ramack for your follow up on this. I started to reorganize the code to match up the new bundle organization, and to be able to split up into smaller PR-s.
I do not plan to do big changes to the logic itself, so if you are able to try out the current version on a 2.4 install and report back any issues you find would be a great help.

Hilbrand · 2019-10-31T09:09:16Z

@mrbig FYI in case you didn't see it. There is a tutorial on the forum to guide you with the migration to the new build system:
https://community.openhab.org/t/tutorial-migrate-your-binding-to-the-maven-bnd-based-build-system/81389?u=hilbrand

SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

Raketenschnitzel · 2019-11-18T14:57:50Z

I am also interested in this binding. The PR is 16 days old now.
Is there any progress in the reviewing?
I unfortunately can't do it myself. The only thing i could offer is testing it on a real device, what i am already doing but only making slow progress.

SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

mrbig · 2020-03-13T07:41:53Z

I close this PR, because I'm sure in this form it will not be merged.

I'll keep posting refactored versions step by step once they get approved.

Anyone interested in this binding please look at the following pull requests: #6331, #6994, #7432, #7441

SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: #3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: Eugen Freiter <freiter@gmx.de>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: CSchlipp <christian@schlipp.de>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: Daan Meijer <daan@studioseptember.nl>

* [sunspec] Modbus: SunSpec bundle basic version SunSpec is an open standard for solar inverters and other related devices to share data about their internal state. The standard is implemented by several vendors like ABB, Fronius, SMA, Schneider Electric, Solaredge, etc. The goal of this work is to add user friendly support of these devices to openHAB. The standard is built on the Modbus protocol, so this work is heavily based on the Modbus binding. Also the Bluetooth binding and several of it's solutions were taken as an example how to extend an already existing binding with a new bundle. Related issue: openhab#3216 This is a stripped down version of a SunSpec bundle aimed to ease reviewing. Original PW with all the features can be found here: https://github.com/openhab/openhab2-addons/pull/4220 This version contains only a limited support for single phase inverters, but no auto discovery or any other fancy features are included. Other changes from my original PR: - migrated to the new build system - using NonNull values wherever possible - modell classes were moved to a dto package and highly simplified - other minor code changes Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

wborn added the new binding If someone has started to work on a binding. For a new binding PR. label Nov 11, 2018

wborn changed the title ~~SunSpec support~~ [sunspec] Modbus: SunSpec Binding initial contribution Dec 18, 2018

mrbig requested a review from a team as a code owner January 19, 2019 02:13

mrbig mentioned this pull request Jan 25, 2019

[modbus] Made constants and handler packages internal #4685

Merged

mrbig force-pushed the 3216-binding-sunspec-modbus branch 2 times, most recently from e215b97 to 99816ae Compare January 25, 2019 00:59

wborn mentioned this pull request Jan 25, 2019

Revert 4685 modbus internal #4704

Merged

mrbig added 4 commits January 26, 2019 11:32

[modbus] Change bridge to offline during reinitialization

f860564

This seems to be necessary to get the children notified about the change Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

[modbus] Added discovery service

ed1ac08

Created discovery service based on the implementation in the bluetooth bundle Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

[sunspec] fixed null pointer exception

dc271a8

Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

mrbig force-pushed the 3216-binding-sunspec-modbus branch from 56fdd56 to 64d658c Compare January 26, 2019 10:35

mrbig added 2 commits January 26, 2019 12:10

[sunspec] Updated version number and copyright notice

e609b20

Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

[sunspec] Updated README with enableDiscovery

0d0f297

Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>

mrbig force-pushed the 3216-binding-sunspec-modbus branch from 64d658c to 0d0f297 Compare January 26, 2019 12:05

davidgraeff reviewed Mar 21, 2019

View reviewed changes

This was referenced Mar 25, 2019

[modbus] Change bridge to offline during reinitialization #5244

Merged

[modbus] Added discovery service #5246

Merged

ssalonen mentioned this pull request Apr 22, 2019

[modbus] handle floating point NaN and inf gracefully #5498

Merged

ssalonen mentioned this pull request Aug 7, 2019

[heliosventilation] Helios Ventilation Binding initial contribution #5831

Closed

mrbig mentioned this pull request Nov 2, 2019

[modbus][sunspec] Initial contribution #6331

Merged

Hilbrand added the awaiting other PR Depends on another PR label Jan 23, 2020

mrbig closed this Mar 13, 2020

mrbig mentioned this pull request Apr 22, 2020

[modbus][sunspec] Support for SunSpec meters #7441

Merged

wborn removed the awaiting other PR Depends on another PR label Dec 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sunspec] Modbus: SunSpec Binding initial contribution #4220

[sunspec] Modbus: SunSpec Binding initial contribution #4220

mrbig commented Nov 11, 2018

openhab-bot commented Dec 30, 2018

openhab-bot commented Jan 5, 2019

mrbig commented Jan 26, 2019

openhab-bot commented Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019 •

edited

Loading

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff Mar 21, 2019

davidgraeff commented Mar 21, 2019 •

edited

Loading

mrbig commented Mar 24, 2019

davidgraeff commented Mar 24, 2019 •

edited

Loading

ssalonen commented Apr 22, 2019 •

edited

Loading

mrbig commented Apr 23, 2019

ramack commented Aug 9, 2019

ramack commented Oct 27, 2019

mrbig commented Oct 30, 2019

Hilbrand commented Oct 31, 2019

Raketenschnitzel commented Nov 18, 2019

mrbig commented Mar 13, 2020 •

edited

Loading

		</config-description>


		</config-description:config-descriptions>

+                  }
+                  /**
+                   *

		</channel-type>

		</thing:thing-descriptions>

[sunspec] Modbus: SunSpec Binding initial contribution #4220

[sunspec] Modbus: SunSpec Binding initial contribution #4220

Conversation

mrbig commented Nov 11, 2018

openhab-bot commented Dec 30, 2018

openhab-bot commented Jan 5, 2019

mrbig commented Jan 26, 2019

openhab-bot commented Mar 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidgraeff Mar 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidgraeff commented Mar 21, 2019 • edited Loading

mrbig commented Mar 24, 2019

davidgraeff commented Mar 24, 2019 • edited Loading

ssalonen commented Apr 22, 2019 • edited Loading

mrbig commented Apr 23, 2019

ramack commented Aug 9, 2019

ramack commented Oct 27, 2019

mrbig commented Oct 30, 2019

Hilbrand commented Oct 31, 2019

Raketenschnitzel commented Nov 18, 2019

mrbig commented Mar 13, 2020 • edited Loading

davidgraeff Mar 21, 2019 •

edited

Loading

davidgraeff commented Mar 21, 2019 •

edited

Loading

davidgraeff commented Mar 24, 2019 •

edited

Loading

ssalonen commented Apr 22, 2019 •

edited

Loading

mrbig commented Mar 13, 2020 •

edited

Loading