Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus] Made constants and handler packages internal #4685

Merged
merged 1 commit into from
Jan 24, 2019
Merged

[modbus] Made constants and handler packages internal #4685

merged 1 commit into from
Jan 24, 2019

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 24, 2019

@wborn
[modbus] Made constants and handler packages internal
8b07f7a 
See eclipse-archived/smarthome#4330

Signed-off-by: Wouter Born <eclipse@maindrain.net>
@kaikreuzer kaikreuzer merged commit 02929f4 into openhab:master Jan 24, 2019
@wborn wborn deleted the modbus-internal branch January 24, 2019 22:26
@mrbig
Copy link

mrbig commented Jan 25, 2019

Dear @wborn
I'd like to ask you to revert this change in favor of an upcoming pull request: #4220
I've earlier requested these things to be public, please see pr #4077
I'm going to extend the modbus bundle with more user friendly functionalities, and for those I need the binding id, the ModbusEndpointThingHandler and the relevant EndpointNotInitializedException to be public.
These changes were designed alike to the bluetooth binding where the modbus binding could serve as a basis for device specific bindings.

Thank you.

wborn added a commit that referenced this pull request Jan 25, 2019
@wborn
Revert "[modbus] Made constants and handler packages internal (#4685)"
043a3dd 
This reverts commit 02929f4.
@wborn wborn mentioned this pull request Jan 25, 2019
Merged
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@wborn @Pshatsillo
[modbus] Made constants and handler packages internal (openhab#4685)
fb434fb 
See eclipse-archived/smarthome#4330

Signed-off-by: Wouter Born <eclipse@maindrain.net>
Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@wborn @ne0h
[modbus] Made constants and handler packages internal (openhab#4685)
ea39008 
See eclipse-archived/smarthome#4330

Signed-off-by: Wouter Born <eclipse@maindrain.net>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wborn @mrbig @kaikreuzer