[amazonechocontrol] Add features to control smart devices connected to the Amazon Echo #6140

lkn94 · 2019-09-27T19:57:34Z

Add smart home functions to the amazonechocontrol binding. Users are able to control smart devices connected to Amazon Alexa:

turn on/off your lights
change the color
control groups of lights or just single bulbs
receive the current state of the lights
turn on/off smart plugs

A first beta version of these functions can be found in the openhab community.

Fix json parsing Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Improve error handling Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Remove unused Exception Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb) Signed-off-by: Michael Geramb <mail@michael-geramb.at>

…he smart bulbs

Added new functions for the binding

Formatting change Signed-off-by: Michael Geramb <mail@michael-geramb.at>

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Smart home

…nto original

Original

Bugfixed amazon echo/smart home discovery

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Test smart home device list

Merge master Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Merge of openhab master and improve readme

TravisBuddy · 2019-11-20T18:21:49Z

Travis tests were successful

Hey @lkn94,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

mgeramb · 2019-11-20T18:31:39Z

Looks now good to me, thank you!

mgeramb

Looks now good to me, thank you

cpmeister

This is an impressive amount of work. Thanks for doing this!

cpmeister · 2020-03-29T04:30:48Z

...ontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/smarthome/Constants.java

+    public static Map<String, Function<String, HandlerBase>> HandlerFactory = new HashMap<String, Function<String, HandlerBase>>() {
+        private static final long serialVersionUID = 1L;
+        {
+            put(HandlerPowerController.INTERFACE, (s) -> new HandlerPowerController());
+            put(HandlerBrightnessController.INTERFACE, (s) -> new HandlerBrightnessController());
+            put(HandlerColorController.INTERFACE, (s) -> new HandlerColorController());
+            put(HandlerColorTemperatureController.INTERFACE, (s) -> new HandlerColorTemperatureController());
+            put(HandlerSecurityPanelController.INTERFACE, (s) -> new HandlerSecurityPanelController());
+            put(HandlerAcousticEventSensor.INTERFACE, (s) -> new HandlerAcousticEventSensor());
+            put(HandlerTemperatureSensor.INTERFACE, (s) -> new HandlerTemperatureSensor());
+            put(HandlerPercentageController.INTERFACE, (s) -> new HandlerPercentageController());
+            put(HandlerPowerLevelController.INTERFACE, (s) -> new HandlerPowerLevelController());
+        }
+    };


I'd rather you initialize this map as part of static initialization rather than an anonymous HashMap constructor.

cpmeister · 2020-03-29T04:33:09Z

.../main/java/org/openhab/binding/amazonechocontrol/internal/discovery/AmazonEchoDiscovery.java

@@ -53,7 +61,7 @@

    @Nullable
    ScheduledFuture<?> startScanStateJob;
-    long activateTimeStamp;
+    static @Nullable Long activateTimeStamp;


why static?

cpmeister · 2020-03-29T04:37:47Z

...rol/src/main/java/org/openhab/binding/amazonechocontrol/internal/handler/AccountHandler.java

+
+        Connection currentConnection = connection;
+        if (currentConnection == null) {
+            return new ArrayList<SmartHomeBaseDevice>();


If the returned type is not meant to be mutable, please return Collections.emptyList() instead.

cpmeister · 2020-03-29T04:37:53Z

...rol/src/main/java/org/openhab/binding/amazonechocontrol/internal/handler/AccountHandler.java

+        }
+
+        if (!forceUpdate && this.smartHomeDeviceHandlers.isEmpty() && shouldDiscoverSmartHomeDevices() == 0) {
+            return new ArrayList<SmartHomeBaseDevice>();


cpmeister · 2020-03-29T04:48:44Z

...trol/src/main/java/org/openhab/binding/amazonechocontrol/internal/smarthome/HandlerBase.java

+        return channels.containsKey(channelId);
+    }
+
+    protected abstract String[] GetSupportedInterface();


Please use camelcase for method names

Suggested change

protected abstract String[] GetSupportedInterface();

protected abstract String[] getSupportedInterface();

cpmeister · 2020-03-29T04:52:10Z

...in/java/org/openhab/binding/amazonechocontrol/internal/smarthome/HandlerColorController.java

+ *
+ * @author Lukas Knoeller, Michael Geramb
+ */
+public class HandlerColorController extends HandlerBase {


Please add @NonNullByDefault
Make sure to add this to any other handler classes as well.

cpmeister · 2020-03-29T04:53:18Z

...in/java/org/openhab/binding/amazonechocontrol/internal/smarthome/HandlerColorController.java

+    final static ChannelInfo color = new ChannelInfo("color" /* propertyName */ , "color" /* ChannelId */,
+            CHANNEL_TYPE_COLOR /* Channel Type */ , ITEM_TYPE_COLOR /* Item Type */);
+
+    final static ChannelInfo colorProperties = new ChannelInfo("colorProperties" /* propertyName */ ,
+            "colorName" /* ChannelId */, CHANNEL_TYPE_COLOR_NAME /* Channel Type */ , ITEM_TYPE_STRING /* Item Type */);
+
+    @Nullable
+    HSBType lastColor;
+    @Nullable
+    String lastColorName;


Can these be made private?
Please update elsewhere where applicable.

cpmeister · 2020-03-29T04:58:15Z

...main/java/org/openhab/binding/amazonechocontrol/internal/smarthome/JsonSmartHomeDevices.java

+        public @Nullable DriverIdentity driverIdentity;
+    }
+
+    static class DriverIdentity {


not public?

cpmeister · 2020-03-29T05:04:21Z

.../binding/amazonechocontrol/internal/smarthome/SmartHomeDeviceStateGroupUpdateCalculator.java

+    static final boolean isDebug = java.lang.management.ManagementFactory.getRuntimeMXBean().getInputArguments()
+            .toString().indexOf("-agentlib:jdwp") > 0;


You shouldn't be accessing jvm params in the bindings, if you want to do this do it through a config instead.

cpmeister · 2020-03-29T05:06:53Z

...java/org/openhab/binding/amazonechocontrol/internal/smarthome/SmartHomeDevicesDiscovery.java

+@NonNullByDefault
+public class SmartHomeDevicesDiscovery extends AbstractDiscoveryService implements ExtendedDiscoveryService {
+
+    AccountHandler accountHandler;


Please make sure to make fields private if possible.

J-N-K · 2020-06-18T16:57:19Z

@lkn94, are willing to continue here? I could provide assistance, if needed.

lkn94 · 2020-06-22T07:15:49Z

@lkn94, are willing to continue here? I could provide assistance, if needed.

I wanna continue but I don't have enough time at the moment. So the binding must wait ;)

Michael Geramb and others added 30 commits May 11, 2019 13:12

[amazonechocontrol]

7c839a7

Fix json parsing Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

[amazonechocontrol]

35154c1

Improve error handling Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

[amazonechocontrol]

94494da

Remove unused Exception Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb) Signed-off-by: Michael Geramb <mail@michael-geramb.at>

Merge branch 'master' of https://github.com/openhab/openhab2-addons

d75261f

Merge branch 'master' of https://github.com/openhab/openhab2-addons

eef3b2e

Changes for new build system

43e8144

Original

611b9fd

Bugfixed for new version and merge request

bbdcbf8

Added license information and author

987d8eb

Added contributor and readme information

b2d9d0f

Uncommented test comment for production use

286eb47

Removed the waitForUpdate variable - not used

336a7e1

Added two configurations params for pulling interval and activating t…

4b8a520

…he smart bulbs

Merge branch 'master' of https://github.com/openhab/openhab2-addons

01f74fb

Merge branch 'SmartHome' into original

1860326

Merge pull request #2 from lkn94/original

59c9d18

Added new functions for the binding

[amazonechocontrol]

7e234da

Formatting change Signed-off-by: Michael Geramb <mail@michael-geramb.at>

[amazonechocontrol]

08d8636

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

[amazonechocontrol]

35434d9

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

[amazonechocontrol]

717cded

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

[amazonechocontrol]

1f352a4

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

[amazonechocontrol]

0b9b438

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Merge pull request #1 from mgeramb/SmartHome

3dd6b57

Smart home

Bugfixed discovery

208d6f5

Merge branch 'original' of https://github.com/lkn94/openhab2-addons i…

5def872

…nto original

Bugfixed wrong entries of the amazon echo devices as lights

0ea5cde

Merge pull request #2 from lkn94/original

4d44bda

Original

Merge pull request #3 from lkn94/SmartHome

a0f751b

Bugfixed amazon echo/smart home discovery

[amazonechocontrol]

73796fb

Fix for Announcment Channel Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Merge pull request #3 from mgeramb/TestSmartHomeDeviceList

340e4f6

Test smart home device list

Michael Geramb and others added 6 commits November 17, 2019 21:15

Merge branch 'master' of https://github.com/openhab/openhab2-addons

417f3f8

[amazonechocontrol]

b42de5d

Merge master Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

Merge pull request #11 from mgeramb/SmartHomeDeviceHandling

f2ae580

Merge of openhab master and improve readme

Removed unused file

892b51b

Removed unused file

11ce859

Error fixes

306f57b

mgeramb approved these changes Nov 20, 2019

View reviewed changes

mgeramb requested review from wborn, davidgraeff and kaikreuzer November 20, 2019 21:24

martinvw changed the base branch from master to 2.5.x January 13, 2020 13:42

openhab deleted a comment from TravisBuddy Jan 13, 2020

martinvw added the cre Coordinated Review Effort label Jan 13, 2020

cpmeister requested changes Mar 29, 2020

View reviewed changes

cpmeister added the awaiting feedback label Apr 23, 2020

mgeramb mentioned this pull request Jun 16, 2020

[amazonechocontrol] fix memory/thread leak and failing connection #7919

Merged

J-N-K mentioned this pull request Jun 21, 2020

[amazonechocontrol] add support for smarthome devices #7969

Merged

kaikreuzer force-pushed the 2.5.x branch from 536fc42 to 3ab1af1 Compare June 21, 2020 16:12

Hilbrand removed the cre Coordinated Review Effort label Sep 18, 2020

kaikreuzer added migrate to OH3 and removed migrate to OH3 labels Sep 20, 2020

J-N-K closed this Sep 20, 2020

J-N-K mentioned this pull request Jan 2, 2022

[amazonechocontrol] Fix refresh time for skill connected devices #11943

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[amazonechocontrol] Add features to control smart devices connected to the Amazon Echo #6140

[amazonechocontrol] Add features to control smart devices connected to the Amazon Echo #6140

lkn94 commented Sep 27, 2019

TravisBuddy commented Nov 20, 2019

mgeramb commented Nov 20, 2019

mgeramb left a comment

cpmeister left a comment

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

cpmeister Mar 29, 2020

J-N-K commented Jun 18, 2020

lkn94 commented Jun 22, 2020

	protected abstract String[] GetSupportedInterface();
	protected abstract String[] getSupportedInterface();

		static final boolean isDebug = java.lang.management.ManagementFactory.getRuntimeMXBean().getInputArguments()
		.toString().indexOf("-agentlib:jdwp") > 0;

[amazonechocontrol] Add features to control smart devices connected to the Amazon Echo #6140

[amazonechocontrol] Add features to control smart devices connected to the Amazon Echo #6140

Conversation

lkn94 commented Sep 27, 2019

TravisBuddy commented Nov 20, 2019

Travis tests were successful

mgeramb commented Nov 20, 2019

mgeramb left a comment

Choose a reason for hiding this comment

cpmeister left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

J-N-K commented Jun 18, 2020

lkn94 commented Jun 22, 2020