[vallox] Vallox Binding initial contribution #6459

gitMiguel · 2019-11-27T12:27:39Z

Vallox Binding initial contribution.

Continuing https://github.com/openhab/openhab2-addons/pull/1560. See also discussion about different models of vallox units https://github.com/openhab/openhab2-addons/pull/2990.
This is a partial rewrite from #1560 and my goal is to have the Vallox MV binding combined to this so then we would have a single Vallox binding. Work is still in progress but as a beginner with java I would like a maintainers review/opinion and guide me to the right direction if needed.
@SuperOok can you take a look and give your comments as this is your original work.
Also tagging @bjoernbrings to get some comments about combining these two.

Download from jfrog: org.openhab.binding.vallox-2.5.7-SNAPSHOT.jar
Or install from marketplace: Exlipse Markeplace Vallox binding
Discussion: community.openhab.org/t/new-vallox-binding-wip/86425

Todo:

~~Readme~~
~~Integrate Vallox MV Binding~~
~~Test serial communication~~
~~Finalize serial communication.~~
~~Modify cache.~~
~~Provide download link for testing. Eclipse marketplace and direct link.~~

Signed-off-by: Miika Jukka miikajukka@gmail.com (github: gitMiguel)

Closes #1559

openhab-bot · 2019-11-27T21:32:58Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-vallox-binding-wip/86425/1

gitMiguel · 2019-12-01T19:02:52Z

Hi,

As you can see I made a new commit and I'm almost done. I finalized the serial connection part but haven't had a chance to test it properly. Getting serial port over ethernet to work has given me headaches. When setting serial port parameters the implementation is throwing UnsupportedCommOperationException. Maybe @Hilbrand you could take a look if it might be something in my code that's not working. The code is much based on DSMR binding.

/Miika

Edit:

Looks like serial port parameters are in the wrong order 🤦‍♂️
I'll also adjust threshold and timeout values.

Hilbrand · 2019-12-02T19:13:11Z

I never implemented a fix in the DSMR binding. I stranded in a discussion on how this should be implemented eclipse-archived/smarthome#6280 I still think this should be handled in core. In another binding they simply wrapped the problematic methods. See #4372

gitMiguel · 2019-12-03T22:41:04Z

I never implemented a fix in the DSMR binding. I stranded in a discussion on how this should be implemented eclipse/smarthome#6280 I still think this should be handled in core. In another binding they simply wrapped the problematic methods. See #4372

Hmm I got this working with: Vallox ->RS485 ->USB -> RPi3 -> ser2net -> My desktop running Win 10 with HW Virtual serial port VSP3 -> Eclipse IDE.

I'm quite unfamiliar with low level serial implementation in java but looks like it's using RxTx and both enableReceiveThreshold() and enableReceiveTimeout() are working as expected.

gitMiguel · 2019-12-04T23:59:53Z

@bjoernbrings could you take a look at this and see if you approve the way that I combined these two bindings. I also formatted all channels and groups to lowerCamelCase. Should this also be done to MV channels or is it a breaking change? Check also the README and valloxmv_de.properties.

gitMiguel · 2019-12-09T19:54:17Z

I'm done so far and ready for reviews.

I'll leave UoM implementation for later.

Edit:
Squashed all commits and rebased onto master.

bjoernbrings · 2019-12-29T23:07:12Z

Seems to me like a merge of a new binding (for the old system) with 'my' old binding (for the new system) without any change in or reuse of overlapping functionality. I'm totally fine with it.

Though I'm in principle a bit unsure what should should apply when there should be one binding or several

one per vendor => this merge is the way to go
only merge when there is overlapping functionality => we should keep it seperate

I'm personally happy with both solutions

gitMiguel · 2020-01-09T08:33:08Z

The binding count only increases over time and merging these two keeps the count one less?

gitMiguel · 2020-01-10T20:11:06Z

@bjoernbrings what is the potential issue with backwards compatibility?

Hilbrand · 2020-01-10T20:26:31Z

The thing id changes from valloxmv to vallox. Meaning users have to recreate the things. This means not backward compatible. Meaning if the valloxmv is going to be merged in here the original binding should be moved (see comment below) because it's not desired to have 2 versions of the same code here. hence the it's not backward compatible.

The additions between this binding and the valloxmv binding doesn't seem to share much code. So it's not conclusive if this should be combined. However if it's going to be shared I would prefer to first move the valloxmv binding to the new thing id and put valloxmv code in a specific valloxmv package and in a second commit or pull request put the se specific code in a valloxse (or us just vm and se) package to better separate which code belongs to what. With the current pr you basically let the reviewers review the complete original valloxmv for a second time, because it's very time consuming to figure out what is from the original code and what is added.

gitMiguel · 2020-01-10T20:39:05Z

Understood but who makes the decision then? Might be better to leave these separated.

TravisBuddy · 2020-06-11T19:02:38Z

Travis tests were successful

Hey @gitMiguel,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

- Fix log statement and remove null check suppressions Signed-off-by: Miika Jukka <miikajukka@gmail.com>

- ChannelMapper from Map to Enum (ChannelDescriptor) - Remove excess null suppressions - Remove ByteBuffer - Remove leftover try-catch clauses - Change cache map key from Byte to ChannelDescriptor - Change runnables to private methods and apply method reference - Convert to primitives where applicable - Logging and thing status fixes - Bump version to 2.5.4-SNAPSHOT Signed-off-by: Miika Jukka <miikajukka@gmail.com>

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

... null check suppression from sendTelegram() Signed-off-by: Miika Jukka <github@lantee.eu>

- Remove scheduler from connectors and use dedicated threads - Switch to atomic booleans - Remove efficiency channels. Calculation formula outdated. - Address ChannelDescriptor with static maps - Pass ValloxConnector from HandlerFactory and remove ConnectorFactory - Remove unused methods and constants - Ensure that Cache returns null where values are missing - Other smaller fixes Signed-off-by: Miika Jukka <github@lantee.eu>

...temperature, humidity and DC fan adjustment channels. Signed-off-by: Miika Jukka <github@lantee.eu>

Signed-off-by: Miika Jukka <github@lantee.eu>

- Clean constants file Signed-off-by: Miika Jukka <github@lantee.eu>

Signed-off-by: Miika Jukka <github@lantee.eu>

TravisBuddy · 2020-07-01T10:29:16Z

Travis tests were successful

Hey @gitMiguel,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

gitMiguel · 2020-08-24T12:29:38Z

Sorry but I don't have any time to finish this. Still hoping to get back and finish it somewhere in the future.

openhab-bot · 2022-09-02T16:38:56Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/vallox-se-binding/86425/59

gitMiguel requested a review from a team as a code owner November 27, 2019 12:27

wborn added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Nov 27, 2019

gitMiguel mentioned this pull request Nov 27, 2019

[Discussion] Updated build available gitMiguel/openhab-addons#1

Closed

gitMiguel force-pushed the master branch from 5ea907f to 43bd8a5 Compare December 2, 2019 15:20

gitMiguel force-pushed the master branch 2 times, most recently from 08bb923 to d49c873 Compare December 7, 2019 22:54

gitMiguel changed the title ~~[vallox][WIP] Vallox Binding initial contribution~~ [vallox] Vallox Binding initial contribution Dec 9, 2019

gitMiguel force-pushed the master branch from bfdd40c to 59453bd Compare December 9, 2019 20:25

gitMiguel changed the base branch from master to 2.5.x January 9, 2020 08:30

gitMiguel force-pushed the master branch 2 times, most recently from 4d8166c to 1fab8f3 Compare January 9, 2020 10:01

bjoernbrings added (potentially) not backward compatible and removed work in progress A PR that is not yet ready to be merged labels Jan 9, 2020

openhab deleted a comment from TravisBuddy Jan 13, 2020

kaikreuzer force-pushed the 2.5.x branch from 536fc42 to 3ab1af1 Compare June 21, 2020 16:12

gitMiguel and others added 22 commits July 1, 2020 13:21

[Vallox] Vallox binding initial commit

4ae221a

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Bump version to 2.5.2-SNAPSHOT

edadc75

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Cleanup and readme update

2d855ed

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Remove troubleshoot section from README

ca2d69c

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Bump version to 2.5.3-SNAPSHOT

36919f6

- Fix log statement and remove null check suppressions Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Revert @nullable removal from SerialPortManager

2353bef

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Address latest review comments and requests

f4c97ce

Signed-off-by: Miika Jukka <miikajukka@gmail.com>

[Vallox] Remove try-catch clause from listener handling and...

be77a69

... null check suppression from sendTelegram() Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Implement UoM for...

ccaa51b

...temperature, humidity and DC fan adjustment channels. Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Update README.md

cb95eaf

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Bump version to 2.5.5-SNAPSHOT

e075afd

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Fix DecimalType handling

f252334

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Revert usage of dedicated threads.

e744df7

- Clean constants file Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Address latest review comments

694b423

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Minor cleanup

105806a

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Fix wrong boolean value

e50c901

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Local variable fix in SerialConnector

bb3d15e

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Version bump to 2.5.6-SNAPSHOT

3c7d1ad

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Address latest review comments

8f535cb

Signed-off-by: Miika Jukka <github@lantee.eu>

[Vallox] Version bump to 2.5.7-SNAPSHOT

a91b457

Signed-off-by: Miika Jukka <github@lantee.eu>

gitMiguel force-pushed the master branch from 633b7f7 to a91b457 Compare July 1, 2020 10:26

gitMiguel closed this Aug 24, 2020

gitMiguel deleted the master branch September 10, 2023 20:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vallox] Vallox Binding initial contribution #6459

[vallox] Vallox Binding initial contribution #6459

gitMiguel commented Nov 27, 2019 •

edited

Loading

openhab-bot commented Nov 27, 2019

gitMiguel commented Dec 1, 2019 •

edited

Loading

Hilbrand commented Dec 2, 2019

gitMiguel commented Dec 3, 2019

gitMiguel commented Dec 4, 2019 •

edited

Loading

gitMiguel commented Dec 9, 2019 •

edited

Loading

bjoernbrings commented Dec 29, 2019

gitMiguel commented Jan 9, 2020

gitMiguel commented Jan 10, 2020

Hilbrand commented Jan 10, 2020

gitMiguel commented Jan 10, 2020

TravisBuddy commented Jun 11, 2020

TravisBuddy commented Jul 1, 2020

gitMiguel commented Aug 24, 2020

openhab-bot commented Sep 2, 2022

[vallox] Vallox Binding initial contribution #6459

[vallox] Vallox Binding initial contribution #6459

Conversation

gitMiguel commented Nov 27, 2019 • edited Loading

Vallox Binding initial contribution.

Todo:

openhab-bot commented Nov 27, 2019

gitMiguel commented Dec 1, 2019 • edited Loading

Edit:

Hilbrand commented Dec 2, 2019

gitMiguel commented Dec 3, 2019

gitMiguel commented Dec 4, 2019 • edited Loading

gitMiguel commented Dec 9, 2019 • edited Loading

bjoernbrings commented Dec 29, 2019

gitMiguel commented Jan 9, 2020

gitMiguel commented Jan 10, 2020

Hilbrand commented Jan 10, 2020

gitMiguel commented Jan 10, 2020

TravisBuddy commented Jun 11, 2020

Travis tests were successful

TravisBuddy commented Jul 1, 2020

Travis tests were successful

gitMiguel commented Aug 24, 2020

openhab-bot commented Sep 2, 2022

gitMiguel commented Nov 27, 2019 •

edited

Loading

gitMiguel commented Dec 1, 2019 •

edited

Loading

gitMiguel commented Dec 4, 2019 •

edited

Loading

gitMiguel commented Dec 9, 2019 •

edited

Loading