Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[innogysmarthome] Added guard against null value #6920

Merged
merged 1 commit into from
Jan 28, 2020
Merged

[innogysmarthome] Added guard against null value #6920

merged 1 commit into from
Jan 28, 2020

Conversation

Hilbrand
Copy link
Member

Fixes #6918

@Hilbrand
[innogysmarthome] Added guard against null value
4ff8593 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Jan 27, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @Hilbrand,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cweitkamp
cweitkamp approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 9ca31cc into openhab:2.5.x Jan 28, 2020
@Hilbrand Hilbrand deleted the issue-6918 branch January 28, 2020 22:06
@RalphSester RalphSester mentioned this pull request Jan 29, 2020
Closed
andibraeu pushed a commit to andibraeu/openhab-addons that referenced this pull request Feb 17, 2020
@Hilbrand @andibraeu
[innogysmarthome] Added guard against null value (openhab#6920)
bd6f041 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@kaikreuzer kaikreuzer added this to the 2.5.2 milestone Feb 19, 2020
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
@Hilbrand @leluna
[innogysmarthome] Added guard against null value (openhab#6920)
8000b36 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@Hilbrand @Hans-Reiner
[innogysmarthome] Added guard against null value (openhab#6920)
c437854 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@Hilbrand @markus7017
[innogysmarthome] Added guard against null value (openhab#6920)
7dd7a9e 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Hilbrand @andrewfg
[innogysmarthome] Added guard against null value (openhab#6920)
c6c63ab 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Hilbrand @andrewfg
[innogysmarthome] Added guard against null value (openhab#6920)
286d006 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Hilbrand @andrewfg
[innogysmarthome] Added guard against null value (openhab#6920)
6f70fe4 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Hilbrand @andrewfg
[innogysmarthome] Added guard against null value (openhab#6920)
99ac8aa 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Hilbrand @DaanMeijer
[innogysmarthome] Added guard against null value (openhab#6920)
7d66ffa 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Hilbrand @markus7017
[innogysmarthome] Added guard against null value (openhab#6920)
cd2013d 
Fixes openhab#6918

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvw martinvw martinvw approved these changes

@cweitkamp cweitkamp cweitkamp approved these changes

@ollie-dev ollie-dev Awaiting requested review from ollie-dev ollie-dev is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.

[innogysmarthome] Low-Battery Channel causes Bridge-Offline
5 participants
@Hilbrand @TravisBuddy @martinvw @cweitkamp @kaikreuzer