Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mqtt] (Re)Add outgoing format for OnOffValues #6968

Merged
merged 2 commits into from
Feb 7, 2020
Merged

[mqtt] (Re)Add outgoing format for OnOffValues #6968

merged 2 commits into from
Feb 7, 2020

Conversation

jochen314
Copy link
Contributor

Fix for #6933

Sorry, I somehow thought, that a format would not be needed, as the string values can be changed.
I did not think about a device which expects a different value than the one it sends....

@jochen314
6933: add outgoing format for OnOffValues
596fa66 
Signed-off-by: Jochen Klein <git@jochen.susca.de>
@TravisBuddy
Copy link

Travis tests were successful

Hey @jochen314,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@crnjan
Copy link
Contributor

crnjan commented Feb 7, 2020

Maybe we could add the same for OpenCloseValue?

@jochen314
Also do it for OpenCloseValue
9f916e9 
Signed-off-by: Jochen Klein <git@jochen.susca.de>
@TravisBuddy
Copy link

Travis tests were successful

Hey @jochen314,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@martinvw martinvw merged commit f8744d5 into openhab:2.5.x Feb 7, 2020
boehan pushed a commit to boehan/openhab-addons that referenced this pull request Feb 15, 2020
@jochen314 @boehan
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
0671751 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
andibraeu pushed a commit to andibraeu/openhab-addons that referenced this pull request Feb 17, 2020
@jochen314 @andibraeu
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
740dc25 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
@kaikreuzer kaikreuzer added this to the 2.5.2 milestone Feb 19, 2020
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Feb 19, 2020
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
@jochen314 @leluna
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
e1eda4b 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@jochen314 @Hans-Reiner
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
83d661d 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@jochen314 @markus7017
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
4ab518c 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@jochen314 @J-N-K
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
a7882d9 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jochen314 @andrewfg
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
9815af2 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jochen314 @andrewfg
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
544f12e 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jochen314 @andrewfg
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
feb59f3 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jochen314 @andrewfg
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
f56e131 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@jochen314 @DaanMeijer
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
d7b79ef 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@jochen314 @markus7017
[mqtt] (Re)Add outgoing format for OnOffValues (openhab#6968)
d8fbd8f 
* add outgoing format for OnOffValues ( fixes openhab#6933)
* add outgoing format for OpenCloseValue

Signed-off-by: Jochen Klein <git@jochen.susca.de>
@jochen314 jochen314 deleted the 6933 branch October 18, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvw martinvw martinvw approved these changes

@J-N-K J-N-K J-N-K approved these changes

@davidgraeff davidgraeff Awaiting requested review from davidgraeff davidgraeff is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@jochen314 @TravisBuddy @crnjan @martinvw @J-N-K @kaikreuzer