Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bluetooth] Increased discovery timeout from 5 sec to 10 sec #7156

Merged
merged 1 commit into from
Mar 13, 2020
Merged

[bluetooth] Increased discovery timeout from 5 sec to 10 sec #7156

merged 1 commit into from
Mar 13, 2020

Conversation

paulianttila
Copy link
Contributor

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila pauli.anttila@gmail.com

@paulianttila
[bluetooth] Increased discovery timeout from 5 sec to 10 sec
0098e4f 
Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
@paulianttila
Copy link
Contributor Author

@cpmeister, Airthings devices have almost 50 characteristic, which takes around 5 sec to do service discovery. Not sure what is common amount of characteristic is other bluetooth devices? I increased the timeout to 10 seconds, so there is a room for more complicated devices.

@TravisBuddy
Copy link

Travis tests were successful

Hey @paulianttila,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit dd60073 into openhab:2.5.x Mar 13, 2020
@paulianttila paulianttila deleted the bluetooth-discovery-timeout branch March 14, 2020 10:46
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Mar 18, 2020
@kaikreuzer kaikreuzer added this to the 2.5.3 milestone Mar 18, 2020
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
@paulianttila @leluna
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
143074e 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@paulianttila @Hans-Reiner
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
6dbf950 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@paulianttila @markus7017
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
e4b44f1 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@paulianttila @LoungeFlyZ
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
0ce62cb 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@paulianttila @J-N-K
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
3f6539a 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@paulianttila @andrewfg
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
6dc39d3 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@paulianttila @andrewfg
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
cd6b999 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@paulianttila @andrewfg
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
00b8da9 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@paulianttila @andrewfg
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
deca729 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@paulianttila @DaanMeijer
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
22ae262 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@paulianttila @markus7017
[bluetooth] Increased discovery timeout from 5 sec to 10 sec (openhab…
5688509 
…#7156)

Airthings service discovery takes around 5 seconds when device is very
close to bluetooth dongle. Timeouts have been seen multiple times.
Increased timeout to increase probability for successful service
discovers during connection oriented device discovery.

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@paulianttila @TravisBuddy @cpmeister @kaikreuzer