[netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
robnielsen
requested review from
clinique,
cweitkamp and
lolodomo
as code owners
lolodomo
requested changes
Apr 12, 2020
...inding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAMainHandler.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAModule1Handler.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAModule3Handler.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAModule3Handler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/station.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
|
Something I forgot in my initial review, please enhance the examples in the documentation (new items + sitemap) |
|
@lolodomo, I added updated the documentation with new items and sitemap, along with removing the unneeded Common Problems section. |
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
lolodomo
requested changes
Apr 12, 2020
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/station.xml
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
cpmeister
requested changes
Apr 13, 2020
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/StationUtils.java
Outdated
Show resolved
Hide resolved
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/StationUtils.java
Outdated
Show resolved
Hide resolved
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/StationUtils.java
Outdated
Show resolved
Hide resolved
cpmeister
added
the
enhancement
|
Except one, all my review comments have been taken into account. |
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
|
@lolodomo, sorry about that. fixed now. |
lolodomo
reviewed
Apr 13, 2020
...netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoModuleHandler.java
Outdated
Show resolved
Hide resolved
cpmeister
reviewed
Apr 13, 2020
...inding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAMainHandler.java
Outdated
Show resolved
Hide resolved
cpmeister
requested changes
Apr 13, 2020
.../src/main/java/org/openhab/binding/netatmo/internal/handler/AbstractNetatmoThingHandler.java
Outdated
Show resolved
Hide resolved
cpmeister
requested changes
Apr 13, 2020
.../src/main/java/org/openhab/binding/netatmo/internal/handler/AbstractNetatmoThingHandler.java
Outdated
Show resolved
Hide resolved
cpmeister
requested changes
Apr 13, 2020
...netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoModuleHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
cpmeister
reviewed
Apr 13, 2020
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
cpmeister
reviewed
Apr 13, 2020
cpmeister
reviewed
Apr 13, 2020
...netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoModuleHandler.java
Outdated
Show resolved
Hide resolved
Travis tests were successfulHey @robnielsen, |
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #6890 for weather station and indoor, outdoor, and rain modules. Implemented min, max and sum for 1 day, 1 week and 1 month. Does not include wind since don't have access to a wind module, nor does it contain translations to French or German.
The Netatmo api can be found at https://dev.netatmo.com/apidocumentation/weather#getmeasure.