-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules #7345
Conversation
…ion and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments for me
...inding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAMainHandler.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAModule1Handler.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAModule3Handler.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAModule3Handler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/station.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
Something I forgot in my initial review, please enhance the examples in the documentation (new items + sitemap) |
@lolodomo, I added updated the documentation with new items and sitemap, along with removing the unneeded Common Problems section. |
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments
bundles/org.openhab.binding.netatmo/src/main/resources/ESH-INF/thing/station.xml
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/StationUtils.java
Outdated
Show resolved
Hide resolved
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/StationUtils.java
Outdated
Show resolved
Hide resolved
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/StationUtils.java
Outdated
Show resolved
Hide resolved
Except one, all my review comments have been taken into account. |
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
@lolodomo, sorry about that. fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question
...netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoModuleHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me now
...inding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/station/NAMainHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/netatmo/internal/handler/AbstractNetatmoThingHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/netatmo/internal/handler/AbstractNetatmoThingHandler.java
Outdated
Show resolved
Hide resolved
...netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoModuleHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
...netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/NetatmoModuleHandler.java
Outdated
Show resolved
Hide resolved
Travis tests were successfulHey @robnielsen, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: Eugen Freiter <freiter@gmx.de>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: CSchlipp <christian@schlipp.de>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
…ion and indoor, outdoor, and rain modules (openhab#7345) * [netatmo] Added day, week, and month measurements to the weather station and indoor, outdoor, and rain modules Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
This PR implements #6890 for weather station and indoor, outdoor, and rain modules. Implemented min, max and sum for 1 day, 1 week and 1 month. Does not include wind since don't have access to a wind module, nor does it contain translations to French or German.
The Netatmo api can be found at https://dev.netatmo.com/apidocumentation/weather#getmeasure.