[innogysmarthome] Fix possible resource leak #8080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Travis tests were successfulHey @lolodomo, |
lolodomo
force-pushed
the
innogy_wsclientstop
branch
from
55a0485
to
efec76f
Compare
Travis tests were successfulHey @lolodomo, |
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
innogy_wsclientstop
branch
from
efec76f
to
1d13aac
Compare
Travis tests were successfulHey @lolodomo, |
J-N-K
approved these changes
Jul 8, 2020
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de>
|
@lolodomo This fix seems to have negative side-effects. :-( The line "client.stop();" causes that the method org.openhab.binding.innogysmarthome.internal.InnogyWebSocket#onClose() is called with status "1006" (Status.NO_CLOSE or Status.ABNORMAL) and that causes that the a reconnect attempt is executed. That leads to an infinite loop (at least since my pull-request #8186 which fixed that no reconnect attempts were executed ... ;-)). Why is the status 1006 (NO_CLOSE / ABNORMAL) when this issue should fix false closed websockets? How can it get closed with status 1000 (NORMAL)? |
|
You can revert my change if it leads to a problem. |
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: MPH80 <michael@hazelden.me>
Hilbrand
pushed a commit
that referenced
this pull request
Aug 20, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak #8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes #8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
taboneclayton
pushed a commit
to taboneclayton/openhab-addons
that referenced
this pull request
Aug 23, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Signed-off-by: Clayton Tabone <taboneclayton@gmail.com>
This was referenced Aug 27, 2020
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Related to openhab#8027 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* When an error occurs, it is waited at least for 30 seconds to avoid too many requests (on re-occurring errors). * Workaround for side-effect of "Fix possible resource leak openhab#8080" - Improved by not rescheduling when the close/stop was actively triggered by the binding (in this case there is already a reschedule triggered) * NPE fixed * Code-Optimization Closes openhab#8182 Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8027
Signed-off-by: Laurent Garnier lg.hc@free.fr