Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rotel] Thread name format updated #8238

Merged
merged 1 commit into from
Aug 2, 2020
Merged

[rotel] Thread name format updated #8238

merged 1 commit into from
Aug 2, 2020

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Aug 1, 2020

Related to #8216

Signed-off-by: Laurent Garnier lg.hc@free.fr

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
[rotel] Thread name format updated
0f50d7c 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a side comment the initialization of the field connector seems like a hack to satisfy null warnings as that first initialization doesn't seem to be actually used.

@Hilbrand Hilbrand merged commit bd4d96a into openhab:2.5.x Aug 2, 2020
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 2, 2020

Yes, that's true.

@lolodomo lolodomo deleted the rotel_threadname2 branch August 2, 2020 14:55
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@lolodomo @MPH80
[rotel] Thread name format updated (openhab#8238)
dc27a0c 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: MPH80 <michael@hazelden.me>
bern77 pushed a commit to bern77/openhab-addons that referenced this pull request Aug 6, 2020
@lolodomo @bern77
[rotel] Thread name format updated (openhab#8238)
a9fe3d9 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Bernhard <bern77@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[rotel] Thread name format updated (openhab#8238)
b9537fe 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[rotel] Thread name format updated (openhab#8238)
891c315 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[rotel] Thread name format updated (openhab#8238)
b3a1699 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[rotel] Thread name format updated (openhab#8238)
b647286 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[rotel] Thread name format updated (openhab#8238)
974ba6b 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@lolodomo @CSchlipp
[rotel] Thread name format updated (openhab#8238)
3471684 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[rotel] Thread name format updated (openhab#8238)
8f39a21 
Related to openhab#8216

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @TravisBuddy @Hilbrand