Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boschshc] Initial contribution - Bindings for Bosch Smart Home devices #8371

Closed
wants to merge 121 commits into from
Closed

[boschshc] Initial contribution - Bindings for Bosch Smart Home devices #8371

wants to merge 121 commits into from
+3,866 −0

Commits on Aug 31, 2020

  1. Initial code from create_openhab_binding_skeleton.sh 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    31102cc View commit details
    Browse the repository at this point in the history

  2. Proof-of-concept: receive list of rooms and list of devices from cont… 

    …roller

Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    bb22e17 View commit details
    Browse the repository at this point in the history

  3. Added subscribe and longPoll API calls 

    This gives basic functionality to receive updates from the Bosch Smart Home Controller

Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f81c8a0 View commit details
    Browse the repository at this point in the history

  4. Added classes representing data from the longPoll RPC call 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    59f41b0 View commit details
    Browse the repository at this point in the history

  5. Made long poll API call asynchronous 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    60d529e View commit details
    Browse the repository at this point in the history

  6. Added bridge + reorganized code 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f1eb73d View commit details
    Browse the repository at this point in the history

  7. Fixed compilation errors after refactoring 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    497ebee View commit details
    Browse the repository at this point in the history

  8. Updating the power switch state works for a single hard-coded device 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    68a7a20 View commit details
    Browse the repository at this point in the history

  9. Support multiple power switches: bridge ask handlers for their bosch IDs 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    462c3a4 View commit details
    Browse the repository at this point in the history

  10. Can now switch lights + refresh light state on REFRESH 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f0bae5e View commit details
    Browse the repository at this point in the history

  11. Reduce debug output 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    f99ce7c View commit details
    Browse the repository at this point in the history

  12. Added meta information for Bosch binding 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    b03fdb6 View commit details
    Browse the repository at this point in the history

  13. Set binding online only if fetching rooms and devices worked 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    e672824 View commit details
    Browse the repository at this point in the history

  14. Replaced hard-coded IP address with configuration from things file 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    1f7bef4 View commit details
    Browse the repository at this point in the history

  15. Fixes after rebasing on 2.5.x branch 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7c142bd View commit details
    Browse the repository at this point in the history

  16. Put keystore where openhab user can access it 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a6a0616 View commit details
    Browse the repository at this point in the history

  17. Attempt to get a new subscription ID when the old one is invalidated 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7ae51ee View commit details
    Browse the repository at this point in the history

  18. Better install script 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3ee7c8c View commit details
    Browse the repository at this point in the history

  19. Asynchronously get subscription ID 

    Otherwise, code would get stuck on requesting second subscription ID
Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    263730e View commit details
    Browse the repository at this point in the history

  20. Initial steps towards pairing 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    98c1636 View commit details
    Browse the repository at this point in the history

  21. Doesn't compile because of bouncycastle - compiles if commented out 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7996f0b View commit details
    Browse the repository at this point in the history

  22. Bumped version 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    5f29e07 View commit details
    Browse the repository at this point in the history

  23. Added basic support for multiple devices to support Twinguard 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    8afb3f6 View commit details
    Browse the repository at this point in the history

  24. Support for power meter in power switches + all values from Twinguard 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    d281fff View commit details
    Browse the repository at this point in the history

  25. Add window contact to the list of supported things 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    926aae4 View commit details
    Browse the repository at this point in the history

  26. Updated README to indicate new supported devices 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    80d3970 View commit details
    Browse the repository at this point in the history

  27. Added missing file 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    526f2d2 View commit details
    Browse the repository at this point in the history

  28. Added motion detector thing 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    64a0cd4 View commit details
    Browse the repository at this point in the history

  29. All devices support RefreshType now 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3384722 View commit details
    Browse the repository at this point in the history

  30. Cleanup - removed pairing related stuff that doesn't work 

    Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    24409ec View commit details
    Browse the repository at this point in the history

  31. Fixed a weird bug where InWallSwitchHandler was not an instance of SH… 

    …CHandler

Signed-off-by: Stefan Kaestle <stefan@mad-kow.de>
    @stefan-kaestle @coeing
    stefan-kaestle authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    ad997d9 View commit details
    Browse the repository at this point in the history

  32. Update BoschSHCBridgeHandler.java 

    fixed HTTP request URL to get rooms from SHC

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3b39ea3 View commit details
    Browse the repository at this point in the history

  33. Add handler for Bosch Shutter Control to get and set its open level 

    Signed-off-by: Christian Oeing <christian.oeing@scalamat.de>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    fd42c5a View commit details
    Browse the repository at this point in the history

  34. Auto update of .classpath by IDE 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9c5d78b View commit details
    Browse the repository at this point in the history

  35. Handle PercentType command to set a specific shutter level 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    752feee View commit details
    Browse the repository at this point in the history

  36. Put service name in constant instead of using it hard coded twice 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    5b7234a View commit details
    Browse the repository at this point in the history

  37. Refactor putState method of BoschSHCBridgeHandler 

    Remove unnecessary parts of the request like Gateway ID and put some general logic into separate methods to reuse them in other functions later

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    1f4ec04 View commit details
    Browse the repository at this point in the history

  38. Send operation state STOPPED to stop shutter from moving 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    46dbe35 View commit details
    Browse the repository at this point in the history

  39. Add shutter control to supported devices in README.md 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    edbdf60 View commit details
    Browse the repository at this point in the history

  40. Add null reference check to avoid a NullReferenceException in Shutter… 

    …ControlHandler if device state couldn't be fetched

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    396ece1 View commit details
    Browse the repository at this point in the history

  41. Add TemperatureLevelService 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    d518407 View commit details
    Browse the repository at this point in the history

  42. Add ThermostatHandler 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    50993db View commit details
    Browse the repository at this point in the history

  43. Add valve tappet position channel to thermostat via ValveTappet service 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3d54b79 View commit details
    Browse the repository at this point in the history

  44. Add service registration for BoschSHCHandler, so the state updates ar… 

    …e automatically calling the registered state update callback of the handler

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    b36558a View commit details
    Browse the repository at this point in the history

  45. Add affectedChannels to service registration and handle RefreshType d… 

    …irectly in BoschSHCHandler

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    125510a View commit details
    Browse the repository at this point in the history

  46. Cleaned up DeviceStatusUpdate class 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0aa9faf View commit details
    Browse the repository at this point in the history

  47. added Bosch SHC certs 

    added public certificates from https://github.com/BoschSmartHome/bosch-shc-api-docs/tree/master/best_practice

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    4578cc6 View commit details
    Browse the repository at this point in the history

  48. added pairing support 

    added support for keystore creation and pairing
documented the process in readme
refactoring of httpClient to take care of SSL context

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7c717af View commit details
    Browse the repository at this point in the history

  49. Add RoomClimateControlService and ClimateControlHandler 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    357393d View commit details
    Browse the repository at this point in the history

  50. Handle command to set setpoint temperature and move conversion from s… 

    …ervice state data to thing states into service state classes

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    375b2d1 View commit details
    Browse the repository at this point in the history

  51. Remove unnecessary imports from ThermostatHandler.java 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    Christian Oeing authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7871074 View commit details
    Browse the repository at this point in the history

  52. Make new service and handler @NonNullByDefault 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    ffd8e44 View commit details
    Browse the repository at this point in the history

  53. Added comments for climate control service, handler and base service … 

    …and handler

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    c423a18 View commit details
    Browse the repository at this point in the history

  54. Add missing comments on new classes and their methods 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    bb2dc6a View commit details
    Browse the repository at this point in the history

  55. Make registerService method of BoschSHCHandler private and adjust usages 

    Derived handlers should use createService instead.

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    43ca090 View commit details
    Browse the repository at this point in the history

  56. Throw an error instead of returning null for method getBridgeHandler … 

    …of BoschSHCHandler

This allows for fewer null checks after the initialization of a handler.

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a0fb240 View commit details
    Browse the repository at this point in the history

  57. Add @author tags in JavaDoc of new classes 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    70bc046 View commit details
    Browse the repository at this point in the history

  58. Ran mvn spotless:apply to apply correct code formatting 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    c967418 View commit details
    Browse the repository at this point in the history

  59. Fixed missing imports in BoschSHCService.java 

    This was caused by a too quick merge of me.

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    65c9afa View commit details
    Browse the repository at this point in the history

  60. Fixed warnings about null annotations 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    846bf5c View commit details
    Browse the repository at this point in the history

  61. Add @NonNullByDefault to all handlers 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a8d5744 View commit details
    Browse the repository at this point in the history

  62. added license header by executing mvn license:format 

    Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    241b958 View commit details
    Browse the repository at this point in the history

  63. #16 Adjust logger usages to not be too verbose 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    35579ac View commit details
    Browse the repository at this point in the history

  64. #10 Remove obsolete parse-things.py script 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    57456aa View commit details
    Browse the repository at this point in the history

  65. #29 Remove dev scripts install.sh and run.sh scripts 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    d80920d View commit details
    Browse the repository at this point in the history

  66. added author name to each class comment 

    Added the author(s) and small comment to each class based on the git
history and if necessary created the basis class comment body.

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    d5d8203 View commit details
    Browse the repository at this point in the history

  67. added license header for new files 

    Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    dd6d904 View commit details
    Browse the repository at this point in the history

  68. run mvn spotless check/apply 

    Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @coeing
    GerdZanker authored and coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    836b085 View commit details
    Browse the repository at this point in the history

  69. #24 Catch error response when trying to get state of a service of a d… 

    …evice and throw specific error instead of returning invalid state object

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    709a598 View commit details
    Browse the repository at this point in the history

  70. #24 Run mvn spotless:apply and mvn license:format to respect coding g… 

    …uidelines

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    07dd05d View commit details
    Browse the repository at this point in the history

  71. #5 Update README.md with up-to-date information about the setup of th… 

    …e binding

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    e6e159e View commit details
    Browse the repository at this point in the history

  72. #31 Typo in README.md 

    Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing @GerdZanker
    coeing and GerdZanker committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0d1757f View commit details
    Browse the repository at this point in the history

  73. Add detailed description of the system password to provide in README.md 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Co-authored-by: Gerd Zanker <gerd.zanker@web.de>
    @coeing @GerdZanker
    coeing and GerdZanker committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    339a7c3 View commit details
    Browse the repository at this point in the history

  74. Fix non-initialized member of @NonNullByDefault class ValveTappetServ… 

    …iceState

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0489759 View commit details
    Browse the repository at this point in the history

  75. #7 Moved each device to a separate subfolder inside devices folder 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    c121d21 View commit details
    Browse the repository at this point in the history

  76. #44 Adjust version of org.openhab.addons.reactor.bundles to 2.5.9-SNA… 

    …PSHOT in pom.xml

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3d5625f View commit details
    Browse the repository at this point in the history

  77. #45 Increase year in copyright headers 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    72be345 View commit details
    Browse the repository at this point in the history

  78. #45 Remove several obsolete loggers and fix logging of exceptions 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    21d8c6c View commit details
    Browse the repository at this point in the history

  79. #45 Fixed some code analysis warnings 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    1504f5c View commit details
    Browse the repository at this point in the history

  80. #45 Ran mvn spotless:apply 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3c8021f View commit details
    Browse the repository at this point in the history

  81. #45 Revert adding @NonNullByDefault to BoschSHCConfiguration 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    2efa2ce View commit details
    Browse the repository at this point in the history

  82. #47 Fixed code analysis warnings 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    ec5f294 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. updated text files based on pull request feedback 

    Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker
    GerdZanker committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    399c262 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Applied only suggested string text changes and few trivial code changes

Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @Hilbrand @fwolter
    3 people committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    6c47fc6 View commit details
    Browse the repository at this point in the history

  3. Improved comments and changed visibility 

    code review findings improved related to code comments
and public/private visibility of variables
removed example properties file and class path entries

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker
    GerdZanker committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    a4893fd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. added @NonNullByDefault annotation where necessary and easy possible 

    in addition minor improvements like
removed TODO for code refactoring
used BoschSHCException instead of Error in one place
Renamed internal Error class to ErroInfo
ran spotless:apply

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker
    GerdZanker committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    f02b007 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. use SIUnits 

    replaced all Celcius units with eclipse SIUnits

Co-authored-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker @Hilbrand
    GerdZanker and Hilbrand committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    a3a6784 View commit details
    Browse the repository at this point in the history

  2. change logging and GSON related code 

    increased many log levels
avoid creating new GSON instances in derived handler subclasses
changed catch code to avoid stack trace dumps

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker
    GerdZanker committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    87a52a9 View commit details
    Browse the repository at this point in the history

  3. Add @NonNullByDefault to BoschSHCConfiguration class and remove obsol… 

    …ete usages of configuration in handlers

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    41cc874 View commit details
    Browse the repository at this point in the history

  4. Throw BoschSHCExceptions instead of generic Errors and handle them du… 

    …ring creation of services

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    0e293ad View commit details
    Browse the repository at this point in the history

  5. Use Class::new supplier function instead of deprecated Class.newInsta… 

    …nce() method

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    8791e0b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Remove @NonNullByDefault from inner classes and unused logger member … 

    …to remove compile warnings

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    a288d1a View commit details
    Browse the repository at this point in the history

  2. Use Base64.getEncoder().encodeToString instead of Base64.getEncoder()… 

    ….encode and a manual conversion to String

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    fcdf57a View commit details
    Browse the repository at this point in the history

  3. Add @NonNullByDefault annotation to BoschSHCBridgeConfiguration and c… 

    …heck for empty password and ip address in configuration

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    433ac00 View commit details
    Browse the repository at this point in the history

  4. Use try-with-resources to auto-close streams for key store creation 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    383a8e7 View commit details
    Browse the repository at this point in the history

  5. Move data transfer objects of bridge into dto folder 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    a086229 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Add thing type ids and channel type ids to README.md 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    75e8ffa View commit details
    Browse the repository at this point in the history

  2. Move thing configurations out of thing-types.xml and into configs.xml… 

    …. Remove deprecated required element and use attribute instead.

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4aa3fc7 View commit details
    Browse the repository at this point in the history

  3. Adjust some elements, units, descriptions and labels in configs.xml a… 

    …nd thing-types.xml

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b2b7ad8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Move url and request creation from BoschSHCBridgeHandler to BoschHttp… 

    …Client to reuse it inside BoschHttpClient

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    ec6d1fe View commit details
    Browse the repository at this point in the history

  2. Add default timeout to request to smart home controller 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    037addc View commit details
    Browse the repository at this point in the history

  3. Make httpClient of BoschSHCBridgeHandler @nullable and use BoschHttpC… 

    …lient createUrl and createRequest methods where possible

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    2ab5c11 View commit details
    Browse the repository at this point in the history

  4. Make gson field in BoschSHCBridgeHandler final 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    13a9105 View commit details
    Browse the repository at this point in the history

  5. Simplify getDevices method of BoschSHCBridgeHandler 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    046c804 View commit details
    Browse the repository at this point in the history

  6. Use getContentAsString() instead of getContent() plus manual conversi… 

    …on to String

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    75b5cdb View commit details
    Browse the repository at this point in the history

  7. Use instanceof instead of isInstance(...) in BoschSHCBridgeHandler 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    339ff2d View commit details
    Browse the repository at this point in the history

  8. Add registerService method to BoschSHCHandler to register already cre… 

    …ated services, so they can be created in the constructor of a handler and do not have to be @nullable

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    8976d2a View commit details
    Browse the repository at this point in the history

  9. Using simpler String.format instead of MessageFormatter in BoschSHCBr… 

    …idgeHandler

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    f020916 View commit details
    Browse the repository at this point in the history

  10. Move ShutterControlState into dto subfolder and remove @NonNullByDefa… 

    …ult annotation

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    fdcdb9b View commit details
    Browse the repository at this point in the history

  11. Make bridgeHandler and deviceId in BoschSHCService @nullable 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    890ab0d View commit details
    Browse the repository at this point in the history

  12. Move DTOs in dto subfolders and remove @NonNullByDefault annotations … 

    …from them

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    df93d9b View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Add texts for errors during initialization of bridge 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5091727 View commit details
    Browse the repository at this point in the history

  2. Migrate PowerSwitch to new service architecture to get rid of BoschSH… 

    …CBridgeHandler.updateSwitchState

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    d7d9d2e View commit details
    Browse the repository at this point in the history

  3. Remove obsolete null parameter from subscription request 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    6178537 View commit details
    Browse the repository at this point in the history

  4. Removed obsolete TODO about hard-coded data which does not exist anymore 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    7953fb5 View commit details
    Browse the repository at this point in the history

  5. Use lambda for response handling of long poll 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    89ddf38 View commit details
    Browse the repository at this point in the history

  6. Remove obsolete @nonnull annotations in BoschSHCBridgeHandler 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    f401c5f View commit details
    Browse the repository at this point in the history

  7. Throw http exceptions when trying to request state from a device to s… 

    …et the thing to offline

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e45ab13 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. Add state options for combined-rating, temperature-rating and humidit… 

    …y-rating channels

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    fc375bf View commit details
    Browse the repository at this point in the history

  2. Fix several minor static code analysis warnings 

    Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
    @coeing
    coeing committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    49c9bb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. fix HTTP client issue, improve connection logging, add Developers mar… 

    …kdown

the HTTPClient requests were broken
updated exception handling and logging for connection and pairing
describing source of certificates

Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
    @GerdZanker
    GerdZanker committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    49303a6 View commit details
    Browse the repository at this point in the history