Enable and apply Spotless #8401
Conversation
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
wborn
requested review from
3cky,
9037568,
alexf2015,
andrewfg,
bjoernbrings,
bobadair,
BobRak,
caffineehacker,
cdjackson,
chaton78,
claell,
clinique,
Confectrician,
Cossey,
cpmeister,
CrackerStealth,
crnjan,
cschneider,
cweitkamp,
davidgraeff,
DerOetzi,
digitaldan,
dominicdesu,
druciak,
fa2k and
FlorianSW
as code owners
| If the | ||
| last level cannot be determined, the value of onLevel will be used instead. |
There was a problem hiding this comment.
I don't understand why it made this change, The line isn't as long as the one above it, and the break was inserted in a very odd place.
There was a problem hiding this comment.
Yes I also noticed that and have now created #8413 to improve the formatting. It seems to format well when all text is on one line but seems to bug when there is still room left on previous lines.
|
@wborn It seems this broke our sandbox/release build since the version plugin changes the poms in a way that spotless complains, see https://ci.openhab.org/view/Sandbox/job/sandbox-openhab2-release/1634/consoleFull. What can we do about that? |
|
The quick fix is probably adding A nicer fix would be if the pipeline wouldn't touch the formatting or would run spotless:apply so we don't have to manually do this after every release. WDYT @pfink? |
Signed-off-by: Wouter Born <github@maindrain.net>
Related to openhab/openhab-addons#8401 Signed-off-by: Kai Kreuzer <kai@openhab.org>
Related to openhab/openhab-addons#8401 Signed-off-by: Kai Kreuzer <kai@openhab.org>
Related to openhab/openhab-addons#8401 Signed-off-by: Kai Kreuzer <kai@openhab.org>
Related to openhab/openhab-addons#8401 Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
Let's enable and apply Spotless.
Replaces #8068
The issues Spotless found in the
feature.xmlare resolved by making sure theopenhab_wst_feature_file.prefsinclude config matches.I suggest to do follow up PRs for any further improvements.
That way we can quickly merge this PR and it doesn't turn into a merge conflict magnet. 🧲 😉