Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature file aggregation #8422

Merged
merged 1 commit into from Sep 7, 2020
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Sep 7, 2020

The footer doesn't use tabs or proper indentation so after the aggregated feature file was generated a subsequent build would fail.

Related to #8401

@wborn wborn requested a review from a team September 7, 2020 11:48
The footer doesn't use tabs or proper indentation so after the aggregated feature file was generated a subsequent build would fail.

Signed-off-by: Wouter Born <github@maindrain.net>
@Hilbrand Hilbrand added the infrastructure Build system and Karaf related issues and PRs label Sep 7, 2020
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinvw martinvw merged commit ff3b37e into openhab:2.5.x Sep 7, 2020
@wborn wborn deleted the spotless-features branch September 7, 2020 19:07
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
The footer doesn't use tabs or proper indentation so after the aggregated feature file was generated a subsequent build would fail.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added this to the 2.5.9 milestone Sep 18, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
The footer doesn't use tabs or proper indentation so after the aggregated feature file was generated a subsequent build would fail.

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
The footer doesn't use tabs or proper indentation so after the aggregated feature file was generated a subsequent build would fail.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants