Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unifiedremote] Initial contribution #8494

Closed
wants to merge 5,312 commits into from
Closed

[unifiedremote] Initial contribution #8494

wants to merge 5,312 commits into from

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Sep 19, 2020

Unified Remote Binding.

This binding allow send some command to the unified remote server through its web client interface.
It create some channels to control the mouse, some navigation keys, some media keys, and not much more.

Good day. This is my first contribution to this amazing product. Some days ago I started search for a way to control my computer with openHAB and I decided to try to write this binding that seems to finally be working.
Please let me know if there are any suggestions to improve the binding as I'm still getting in touch with this technology. I will also open a thread in the Add-ons forum pointing to this pr, in case someone wants to try it or have an idea for a better implementation. Thanks in advance for your time.

J-N-K and others added 30 commits July 12, 2020 23:40
@J-N-K
adjust loglevel (#7935)
4a8a7cf 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K
fix possible resource leak (#8035)
3179ead 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@Hilbrand
Added apache commons and joda time to forbidden packages. (#8113)
aee9bea 
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@yfre
[homekit] add support for window covering without inversion (#8110)
4ffecf9 
* add support window covering without inversion
* fix typo in README and apply spotless
* address feedback

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@J-N-K
[mail] ensure thing actions work all the time (#8118)
8ccef8e 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@lolodomo
[hue] Thing actions still working after a bundle restart (#8115)
ecb58c1 
Related to openhab/openhab-core#1265

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@clinique
[VolvoOnCall] Reliable implementation of thing actions (#8117)
547bd11 
* Enhancing action method call for Issue #8116

Signed-off-by: clinique <gael@lhopital.org>
@lolodomo
[hue] Add support for hue scene activation (#8098)
fbf0aaf 
* [hue] Add support for hue scene activation

Closes #6043

This is the continuation of the PR #7540

95% of credits go to leluna

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Also-by: leluna <hengrui.jiang@googlemail.com>
@yfre
[homekit] add support for light sensors (#8121)
5193728 
* add light sensor support
* update readme

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@robnielsen
[insteon] added commands to monitor and send messages to devices (#8087)
e8f8a5a 
Signed-off-by: Rob Nielsen <rob.nielsen@yahoo.com>
@mhilbush
[doorbird] Implement actions fix (#8122)
09c207e 
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@krikk
[shelly] it is called "Shelly 3EM" not "Shelly EM3" (#8119)
1ad2d6a 
corrected the Product name in the docu, perhaps we should also rename the page name itself...
@druciak
[satel] Thing actions restart fix (#8128)
ca7f03f 
Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
@lolodomo
[netatmo] Discovery: remove older results (#8126)
6084c1f 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@bobadair
[alarmdecoder] Workaround for thing actions bug (#8130)
1d5beac 
* [alarmdecoder] Doc update
* [alarmdecoder] Workaround for thing actions bug
* [alarmdecoder] Fix exception message

Signed-off-by: Bob Adair <bob.github@att.net>
@yfre
[homekit] add support for air quality sensor (#8125)
60f3c93 
* add air quality sensor
* add example to README

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre
[homekit] fix group handling (#8058)
f058445 
* fix group handling

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@DerOetzi
[scale] fix NPE in transformation (#8124)
2fca998 
Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>t>
@lolodomo
[lgwebos] Improved WebSocket reconnect/disconnect (#8038)
a2ebab6 
Related to #8027

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
[tibber] Partial revert of PR 8033 (#8071)
02f2131 
Related to #8027

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
[heos] Workaround for thing actions bug (#8136)
15645c5 
Related to #8116

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@m-idler
[hyperion] add all default effects to example (#8135)
1df94cd 
signed-off-by: Marcel Idler <poeppe87@hotmail.com>
@lolodomo
[onkyo] Workaround for thing actions bug (#8134)
afd6a02 
Related to #8116

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
[telegram] Workaround for thing actions bug (#8141)
32d8ce6 
Related to #8116

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
[MQTT] Workaround for thing actions bug (#8140)
23f60ce 
* [MQTT] Workaround for thing actions bug

Related to #8116

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@Rossko57
[homekit] Fix typo in example config in README.md (#8146)
dea5d73 
group name gCooller -> gCooler
No sign off accepted under small documentation change exemption.
@Trinitus01
[amazonechocontrol] fix login to account (#8139)
53fe653 
* fixed: Work around Amazon Security changes and make proxy working again (2)

Signed-off-by: Tom Blum (Trinitus01) <trinitus01@googlemail.com>
@mlobstein
[radiothermostat] Workaround for thing actions bug (#8145)
01d0127 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@lolodomo
[pushbullet] Workaround for thing actions bug (#8143)
565396e 
Related to #8116

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@Novanic
[netatmo] Support for favorite weather stations (#8112)
24ec74e 
Closes #8020 
Closes #8111 

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
cweitkamp and others added 14 commits September 15, 2020 15:34
@cweitkamp
Fixed add-ons port build (#8473)
b3db0cb 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@wborn
Fix add-ons port (#8474)
7960a52 
This deprecated method constructor was removed in OH3.

Signed-off-by: Wouter Born <github@maindrain.net>
@markus7017
[magentatv] Initial contribution (aka EntertainTV) (#7864)
efa357f 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
[gree] Minor improvements (#8472)
2758ab4 
* Adding retries for status pool and api request
* README updated
* Implements #8330: Swing Up/Down values 0-11
* Missing text resources added for V-SwingUpDown 7-11

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
[gree] Don't set status to OFFLINE when already OFFLINE (#8476)
aa2cdfb 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
[gree] Fix endless loop in command handler (previous PR) (#8481)
4485b62 
* Don't set status to OFFLINE when already OFFLINE
* Avoid endless loop on command

Signed-off-by: Markus Michels <markus7017@gmail.com>
@mlobstein
[kaleidescape] update README.md for individual thing types (#8480)
52e5b07 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@GiviMAD
Merge pull request #1 from openhab/2.5.x
159f91d 
Merge base branch
@marcelrv
[miio] add automatic tokens to miio MDNSDiscoveryParticipant (#8463)
7352a18 
* [miio] add automatic tokens to miio MDNSDiscoveryParticipant

* get tokens from cloud if possible and add them during discovery.
(similar to the other discovery method)

* [miio] Update from feedback on cloudconnector in discovery

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@cpmeister
Revert "[miio] add automatic tokens to miio MDNSDiscoveryParticipant (#…
c44c568 
…8463)" (#8484)

This reverts commit 7352a18.
@marcelrv
[miio] Control channel for Vacuum 1C STYTJ01ZHM (dreame.vacuum.mc1808) (
a0f09db 
#8477)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@cweitkamp
[max] Added 'ThingActions' to handle reboot and other Cube actions (#…
bbe3104 
…7526)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@marcelrv
[miio] add automatic tokens to miio MDNSDiscoveryParticipant (#8485)
0be7864 
* [miio] add automatic tokens to miio MDNSDiscoveryParticipant

* get tokens from cloud if possible and add them during discovery.
(similar to the other discovery method)
* [miio] Update from feedback on cloudconnector in discovery

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@GiviMAD
Merge pull request #2 from openhab/2.5.x
e49579b 
merge base branch
@GiviMAD GiviMAD requested a review from a team as a code owner September 19, 2020 16:34
@TravisBuddy
Copy link

TravisBuddy commented Sep 19, 2020 •
edited
Loading

Travis tests have failed

Hey @GiviMAD,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@fwolter fwolter added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 19, 2020
@GiviMAD
unified remote binding initial implementation
43198f8 
Signed-off-by: Miguel <miguelwork92@gmail.com>
@Hilbrand
Copy link
Member

Thank you for adding this binding. I have a first question. Does it only support sending commands to the remote or can you also read the status. For example if it's playing, what the volume is, etc? That does have an impact on the channel design in the binding. That's why I ask.

@GiviMAD
Copy link
Member Author

GiviMAD commented Sep 20, 2020

Hi Hilbrand. Thanks for your reply. No, it doesn't support read the status. The channels I mapped are unidirectional to the server as it doesn't provide any state information in the responses.

@GiviMAD
Fix some warnings
4fcbb2d 
Signed-off-by: Miguel <miguelwork92@gmail.com>
@GiviMAD
fix readme
38781bd 
Signed-off-by: Miguel <miguelwork92@gmail.com>
@Hilbrand
Copy link
Member

If you only can send commands you should model the channel with command options. You could simply reduce this to 1 channel with all the options (maybe with the exception of the mouse position as it accepts a dynamic value). See this documentation on how such a channel would look like in xml: https://www.openhab.org/docs/developer/bindings/thing-xml.html#command-description

@kaikreuzer kaikreuzer closed this Sep 20, 2020
@openhab openhab deleted a comment from openhab-bot Sep 20, 2020
@kaikreuzer
Copy link
Member

Not sure why Github has closed this PR (it wasn't me in person...), but please see #8512 on how to proceed now.

FTR, the automatic code migration has created this code, which should give you an easy start for a new PR against main. Thanks!

@GiviMAD
Copy link
Member Author

GiviMAD commented Sep 21, 2020

Ok, I will do. I also will reduce the number of channels of the binding as suggested by Hilbrand. Thanks for your help guys.

@GiviMAD GiviMAD mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet