[unifiedremote] Initial contribution

[GiviMAD]

Copied from initial pr(#8494):

Unified Remote Binding.

This binding allow send some command to the unified remote server through its web client interface.
It create some channels to control the mouse, some navigation keys, some media keys, and not much more.

Good day. This is my first contribution to this amazing product. Some days ago I started search for a way to control my computer with openHAB and I decided to try to write this binding that seems to finally be working.
Please let me know if there are any suggestions to improve the binding as I'm still getting in touch with this technology. I will also open a thread in the Add-ons forum pointing to this pr, in case someone wants to try it or have an idea for a better implementation. Thanks in advance for your time.

download binding jar

[TravisBuddy]

Travis tests were successful

Hey @GiviMAD,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[fwolter]

Thanks for your contribution! I reviewed your code and found only minor things. Good code in general.

[fwolter]

There are some markdown warnings left. You could take a look at target/code-analysis/report.html.

[fwolter]

LGTM

[fwolter]

Can you fix the conflicting CODEOWNERS file?

[GiviMAD]

Done!

[cpmeister]

Can you fix the conflicting pom.xml file?

[GiviMAD]

the build finally works!

[cpmeister]

Almost done, just resolve these warnings and you are finished!

[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[70,36] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[73,36] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[80,21] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[106,61] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[115,21] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[118,41] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteHandler.java:[136,13] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.unifiedremote/src/main/java/org/openhab/binding/unifiedremote/internal/UnifiedRemoteDiscoveryService.java:[100,20] The value of the field org.openhab.binding.unifiedremote.internal.UnifiedRemoteDiscoveryService.UnifiedRemoteUdpDiscovery.ServerInfo.publicIp is not used

To deal with the null warnings you should assign the field to a local variable and perform your operations on that local variable instead.

[GiviMAD]

I think I get rid of all the warnings. Please also note I make a small change in the catch clause in the fie UnifiedRemoteHandler.java to consider the thing as offline is the TimeoutException is thrown. And thanks for the tip on how to deal with the nullable type warnings,I wasn't sure about how to solve those.

[cpmeister]

I thought I was done before, but I took another look and found these two things.
These will be my last change suggestions through so fix these and I'll approve and merge this.
Thanks for all your work!

[GiviMAD]

Done! Please note I change the exception control in the UnifiedRemoteHandler.java again, I was testing the binding this morning in my home installation of openHAB (arm Kubernetes cluster) and I'm getting a NotRouteToHostException when thing turns offline. Sorry for the late change and thanks for your help reviewing the pr.

[cpmeister]

Done