-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt-homeassistant] Add JOSNPath and JINJA as requirements for MQTT HA #9572
Conversation
If it‘s a requirement, it should be installed automatically by adding a dependency to the feature. |
@J-N-K No, we do not support dependencies between add-ons. |
@kaikreuzer Why is that? I‘m pretty sure it would work. |
Many reasons, in general known as dependency hell. |
Ruh roh! This was done a long time ago when the transformations were part of ESH... |
@mhilbush Thanks. I knew I saw that somewhere. |
I got caught out by the missing JINJA requirement, and in the last month I have seen at least 2 people in the forum asking why it does not work correctly with Tasmota devices. I am happy to change the feature.xml and do the testing but only if this is the recommended way forward? https://community.openhab.org/t/mqtt-config-with-auto-discovery/109955 |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, the right way is to document it and not to add it to the features.xml.
@fundef1 Can you sign-off your commit or post the sign-off message here if that is easier for you? See https://www.openhab.org/docs/developer/contributing.html#sign-your-work |
Signed-off-by: Jo Degraef jo.degraef@addestino.be |
…b#9572) Signed-off-by: Jo Degraef <jo.degraef@addestino.be> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
…b#9572) Signed-off-by: Jo Degraef <jo.degraef@addestino.be>
…b#9572) Signed-off-by: Jo Degraef <jo.degraef@addestino.be>
cfr. forum post: https://community.openhab.org/t/mqtt-homeassistant-thing-detected-no-channel/111775/