Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt-homeassistant] Add JOSNPath and JINJA as requirements for MQTT HA #9572

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

fundef1
Copy link
Contributor

@fundef1 fundef1 commented Dec 29, 2020

@J-N-K
Copy link
Member

J-N-K commented Dec 29, 2020

If it‘s a requirement, it should be installed automatically by adding a dependency to the feature.

@kaikreuzer
Copy link
Member

@J-N-K No, we do not support dependencies between add-ons.
We might think about moving transformations to core, though and allow them to be required by add-ons, similar to the io-transport features - but that'll be a bigger change.

@J-N-K
Copy link
Member

J-N-K commented Dec 29, 2020

@kaikreuzer Why is that? I‘m pretty sure it would work.

@kaikreuzer
Copy link
Member

Many reasons, in general known as dependency hell.

@mhilbush
Copy link
Contributor

Ruh roh! This was done a long time ago when the transformations were part of ESH...

@J-N-K
Copy link
Member

J-N-K commented Dec 29, 2020

@mhilbush Thanks. I knew I saw that somewhere.

@Skinah
Copy link
Contributor

Skinah commented Dec 31, 2020

I got caught out by the missing JINJA requirement, and in the last month I have seen at least 2 people in the forum asking why it does not work correctly with Tasmota devices. I am happy to change the feature.xml and do the testing but only if this is the recommended way forward?

https://community.openhab.org/t/mqtt-config-with-auto-discovery/109955

@Skinah Skinah changed the title add JOSNPath and JINJA as requirements for MQTT HA [mqtt-homeassistant] Add JOSNPath and JINJA as requirements for MQTT HA Jan 2, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-mqtt-homeassistant-discovered-aquara-window-contact-not-working/113861/4

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the right way is to document it and not to add it to the features.xml.

@fwolter
Copy link
Member

fwolter commented Jan 13, 2021

@fundef1 Can you sign-off your commit or post the sign-off message here if that is easier for you? See https://www.openhab.org/docs/developer/contributing.html#sign-your-work

@fundef1
Copy link
Contributor Author

fundef1 commented Jan 14, 2021

Signed-off-by: Jo Degraef jo.degraef@addestino.be

@fwolter fwolter merged commit d95fc92 into openhab:main Jan 14, 2021
@fwolter fwolter added this to the 3.1 milestone Jan 14, 2021
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…b#9572)

Signed-off-by: Jo Degraef <jo.degraef@addestino.be>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…b#9572)

Signed-off-by: Jo Degraef <jo.degraef@addestino.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants